Cutlery/invoiceninja
1
0
Fork 0
mirror of https://github.com/invoiceninja/invoiceninja.git synced 2025-06-05 08:24:37 -04:00
Code Issues Packages Projects Releases Wiki Activity

Work on validation for unique invoice numbers

Browse Source
This commit is contained in:
David Bomba 2020-08-12 20:11:13 +10:00
parent c2a32e48df
commit b113859690
2 changed files with 75 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
app/Http/Requests/Invoice/UpdateInvoiceRequest.php
View File

@ -54,6 +54,9 @@ class UpdateInvoiceRequest extends Request
$rules['id'] = new LockedInvoiceRule($this->invoice); $rules['id'] = new LockedInvoiceRule($this->invoice);
if($this->input('number'))
$rules['number'] = 'unique:invoices,number,' . $this->id . ',id,company_id,' . $this->invoice->company_id;
return $rules; return $rules;
} }

72
tests/Feature/InvoiceTest.php
View File

@ -145,4 +145,76 @@ class InvoiceTest extends TestCase
$response->assertStatus(200); $response->assertStatus(200);
} }
public function testUniqueNumberValidation()
{
/* stub a invoice in the DB that we will use to test against later */
$invoice = factory(\App\Models\Invoice::class)->create([
'user_id' => $this->user->id,
'client_id' => $this->client->id,
'company_id' => $this->company->id,
'number' => 'test',
]);
/* Test fire new invoice */
$data = [
'client_id' => $this->client->hashed_id,
'number' => 'dude'
];
$response = $this->withHeaders([
'X-API-SECRET' => config('ninja.api_secret'),
'X-API-TOKEN' => $this->token,
])->post('/api/v1/invoices/', $data)
->assertStatus(200);
$arr = $response->json();
$this->assertEquals('dude', $arr['data']['number']);
/*test validation fires*/
$data = [
'client_id' => $this->client->hashed_id,
'number' => 'test'
];
try{
$response = $this->withHeaders([
'X-API-SECRET' => config('ninja.api_secret'),
'X-API-TOKEN' => $this->token,
])->put('/api/v1/invoices/' . $arr['data']['id'], $data)
->assertStatus(302);
} catch (ValidationException $e) {
$message = json_decode($e->validator->getMessageBag(), 1);
info("inside update invoice validator");
info($message);
$this->assertNotNull($message);
}
$data = [
'client_id' => $this->client->hashed_id,
'number' => 'style'
];
/* test number passed validation*/
$response = $this->withHeaders([
'X-API-SECRET' => config('ninja.api_secret'),
'X-API-TOKEN' => $this->token,
])->put('/api/v1/invoices/' . $arr['data']['id'], $data)
->assertStatus(200);
$data = [
'client_id' => $this->client->hashed_id,
'number' => 'style'
];
/* Make sure we can UPDATE using the same number*/
$response = $this->withHeaders([
'X-API-SECRET' => config('ninja.api_secret'),
'X-API-TOKEN' => $this->token,
])->put('/api/v1/invoices/' . $arr['data']['id'], $data)
->assertStatus(200);
}
} }