From e0261c602d6d110d06ed153b01968326e3242c47 Mon Sep 17 00:00:00 2001 From: David Bomba Date: Mon, 1 May 2023 08:07:41 +1000 Subject: [PATCH 1/3] Minor fixes for CSV imports --- app/Import/Definitions/BankTransactionMap.php | 6 +++--- app/Import/Definitions/ExpenseMap.php | 6 +++--- app/Import/Definitions/VendorMap.php | 6 +++--- app/Import/Providers/BaseImport.php | 3 ++- app/Import/Transformer/Bank/BankTransformer.php | 6 +++--- app/Import/Transformer/Csv/ClientTransformer.php | 6 +++--- app/Import/Transformer/Csv/ExpenseTransformer.php | 6 +++--- app/Import/Transformer/Csv/InvoiceTransformer.php | 6 +++--- app/Import/Transformer/Csv/PaymentTransformer.php | 6 +++--- app/Import/Transformer/Csv/QuoteTransformer.php | 6 +++--- .../Transformer/Csv/RecurringInvoiceTransformer.php | 6 +++--- app/Import/Transformer/Csv/VendorTransformer.php | 6 +++--- app/Import/Transformer/Freshbooks/ClientTransformer.php | 4 ++-- app/Import/Transformer/Freshbooks/InvoiceTransformer.php | 6 +++--- app/Import/Transformer/Invoice2Go/InvoiceTransformer.php | 6 +++--- app/Import/Transformer/Invoicely/ClientTransformer.php | 4 ++-- app/Import/Transformer/Invoicely/InvoiceTransformer.php | 6 +++--- app/Import/Transformer/Wave/ClientTransformer.php | 4 ++-- app/Import/Transformer/Wave/ExpenseTransformer.php | 6 +++--- app/Import/Transformer/Wave/InvoiceTransformer.php | 2 +- app/Import/Transformer/Wave/VendorTransformer.php | 4 ++-- app/Import/Transformer/Zoho/ClientTransformer.php | 4 ++-- app/Import/Transformer/Zoho/InvoiceTransformer.php | 6 +++--- app/Mail/Client/ClientStatement.php | 1 - app/Services/Client/Statement.php | 8 ++++---- 25 files changed, 65 insertions(+), 65 deletions(-) diff --git a/app/Import/Definitions/BankTransactionMap.php b/app/Import/Definitions/BankTransactionMap.php index b6482926ee8c..fb30efd891f0 100644 --- a/app/Import/Definitions/BankTransactionMap.php +++ b/app/Import/Definitions/BankTransactionMap.php @@ -1,10 +1,10 @@ transform($raw_invoice); - + $invoice_data['user_id'] = $this->company->owner()->id; + $invoice_data['line_items'] = $this->cleanItems( $invoice_data['line_items'] ?? [] ); diff --git a/app/Import/Transformer/Bank/BankTransformer.php b/app/Import/Transformer/Bank/BankTransformer.php index bff66a30e895..d9377edc09de 100644 --- a/app/Import/Transformer/Bank/BankTransformer.php +++ b/app/Import/Transformer/Bank/BankTransformer.php @@ -1,10 +1,10 @@ $this->data['body'], 'body' => $this->data['body'], - 'whitelabel' => $this->data['whitelabel'], 'settings' => $this->data['settings'], 'whitelabel' => $this->data['whitelabel'], 'logo' => $this->data['logo'], diff --git a/app/Services/Client/Statement.php b/app/Services/Client/Statement.php index db1fcb0cd899..e315b5e7d464 100644 --- a/app/Services/Client/Statement.php +++ b/app/Services/Client/Statement.php @@ -245,17 +245,17 @@ class Statement switch ($status) { case 'all': return [Invoice::STATUS_SENT, Invoice::STATUS_PARTIAL, Invoice::STATUS_PAID]; - break; + case 'paid': return [Invoice::STATUS_PAID]; - break; + case 'unpaid': return [Invoice::STATUS_SENT, Invoice::STATUS_PARTIAL]; - break; + default: return [Invoice::STATUS_SENT, Invoice::STATUS_PARTIAL, Invoice::STATUS_PAID]; - break; + } } From 89092fbb965c96089a1f01340c47dc778194a200 Mon Sep 17 00:00:00 2001 From: David Bomba Date: Mon, 1 May 2023 08:26:00 +1000 Subject: [PATCH 2/3] Update Translations --- lang/en/texts.php | 12 ++++++++++++ 1 file changed, 12 insertions(+) diff --git a/lang/en/texts.php b/lang/en/texts.php index 7499b0386f21..03f5170af4d7 100644 --- a/lang/en/texts.php +++ b/lang/en/texts.php @@ -5068,6 +5068,18 @@ $LANG = array( 'tax_exempt' => 'Tax Exempt', 'late_fee_added_locked_invoice' => 'Late fee for invoice :invoice added on :date', 'lang_Khmer' => 'Khmer', + 'routing_id' => 'Routing ID', + 'enable_e_invoice' => 'Enable E-Invoice', + 'e_invoice_type' => 'E-Invoice Type', + 'reduced_tax' => 'Reduced Tax', + 'override_tax' => 'Override Tax', + 'zero_rated' => 'Zero Rated', + 'reverse_tax' => 'Reverse Tax', + 'updated_tax_category' => 'Successfully updated the tax category', + 'updated_tax_categories' => 'Successfully updated the tax categories', + 'set_tax_category' => 'Set Tax Category', + 'payment_manual' => 'Payment Manual', + 'expense_payment_type' => 'Expense Payment Type', ); From e7730931cb73f31f8cc759b86cc12e64afc41402 Mon Sep 17 00:00:00 2001 From: David Bomba Date: Mon, 1 May 2023 15:40:56 +1000 Subject: [PATCH 3/3] Ignore pdf generation when using github actions --- tests/Pdf/PdfServiceTest.php | 3 +++ 1 file changed, 3 insertions(+) diff --git a/tests/Pdf/PdfServiceTest.php b/tests/Pdf/PdfServiceTest.php index 4bba1ff7b01d..625783cef598 100644 --- a/tests/Pdf/PdfServiceTest.php +++ b/tests/Pdf/PdfServiceTest.php @@ -36,6 +36,9 @@ class PdfServiceTest extends TestCase public function testPdfGeneration() { + if(config('ninja.testvars.travis')) + $this->markTestSkipped(); + $invitation = $this->invoice->invitations->first(); $service = (new PdfService($invitation))->boot();