Cutlery/invoiceninja
1
0
Fork 0
mirror of https://github.com/invoiceninja/invoiceninja.git synced 2025-07-08 08:24:39 -04:00
Code Issues Packages Projects Releases Wiki Activity

Process Invoice Numbers which includes letters

Browse Source 
-Using custom Invoice Number Patterns like R-ABC-P224301 breaks the QR Bill Generation
-This solution loops through the Invoice Number and translates letter into ASCII
-Makes sure that the field Additional Information not shows the wrong content
This commit is contained in:
checkitsedo 2022-10-30 23:27:16 +01:00 committed by GitHub
parent 577f2a4809
commit b2e3ea53d0
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 39 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

37
app/Helpers/SwissQr/SwissQrGenerator.php
View File

@ -105,14 +105,41 @@ class SwissQrGenerator
// Add payment reference // Add payment reference
// This is what you will need to identify incoming payments. // This is what you will need to identify incoming payments.
if(stripos($this->invoice->number, "Live-") === 0) if(stripos($this->invoice->number, "Live-") === 0)
{ {
// we're currently in preview status. Let's give a dummy reference for now // we're currently in preview status. Let's give a dummy reference for now
$invoice_number = "123456789"; $invoice_number = "123456789";
} }
else else
{ {
$invoice_number = $this->invoice->number; $tempInvoiceNumber = $this->invoice->number;
$tempInvoiceNumber = preg_replace('/[^A-Za-z0-9]/', '', $tempInvoiceNumber);
$tempInvoiceNumber = substr($tempInvoiceNumber, 1);
$calcInvoiceNumber = "";
$array = str_split($tempInvoiceNumber);
foreach($array as $char)
{
if (is_numeric($char))
{
//
}
else
{
if ($char)
{
$char = strtolower($char);
$char = ord($char) - 96;
}
else
{
return 0;
}
}
$calcInvoiceNumber .= $char;
}
$invoice_number = $calcInvoiceNumber;
} }
if(strlen($this->company->present()->besr_id()) > 1) if(strlen($this->company->present()->besr_id()) > 1)
@ -141,7 +168,7 @@ class SwissQrGenerator
// Optionally, add some human-readable information about what the bill is for. // Optionally, add some human-readable information about what the bill is for.
$qrBill->setAdditionalInformation( $qrBill->setAdditionalInformation(
QrBill\DataGroup\Element\AdditionalInformation::create( QrBill\DataGroup\Element\AdditionalInformation::create(
$this->invoice->public_notes ? substr($this->invoice->public_notes, 0, 139) : ctrans('texts.invoice_number_placeholder', ['invoice' => $invoice_number]) $this->invoice->public_notes ? substr($this->invoice->public_notes, 0, 139) : ctrans('texts.invoice_number_placeholder', ['invoice' => $this->invoice->number])
) )
); );