From b6ba6fccda3c95b867a76e60757b855103aef206 Mon Sep 17 00:00:00 2001
From: Hillel Coren <hillelcoren@gmail.com>
Date: Wed, 21 Feb 2018 15:21:27 +0200
Subject: [PATCH] Prevent duplicat submissions

---
 resources/views/master.blade.php                |  1 +
 .../payments/braintree/credit_card.blade.php    | 17 ++++++++++-------
 resources/views/payments/credit_card.blade.php  |  7 ++++++-
 .../payments/stripe/bank_transfer.blade.php     | 10 +++++++++-
 .../views/payments/stripe/credit_card.blade.php | 11 +++++++++--
 .../views/payments/wepay/credit_card.blade.php  |  6 ++++++
 6 files changed, 41 insertions(+), 11 deletions(-)

diff --git a/resources/views/master.blade.php b/resources/views/master.blade.php
index 7eb6878acfdd..906e6cdd2b4c 100644
--- a/resources/views/master.blade.php
+++ b/resources/views/master.blade.php
@@ -271,6 +271,7 @@
 
 <script type="text/javascript">
     NINJA.formIsChanged = {{ isset($formIsChanged) && $formIsChanged ? 'true' : 'false' }};
+    NINJA.formIsSubmitted = false;
 
     $(function () {
         $('form.warn-on-exit input, form.warn-on-exit textarea, form.warn-on-exit select').change(function () {
diff --git a/resources/views/payments/braintree/credit_card.blade.php b/resources/views/payments/braintree/credit_card.blade.php
index 9373b72fb1a2..ad0878989379 100644
--- a/resources/views/payments/braintree/credit_card.blade.php
+++ b/resources/views/payments/braintree/credit_card.blade.php
@@ -55,19 +55,22 @@
                     }
                 },
                 onPaymentMethodReceived: function(e) {
+                    if (NINJA.formIsSubmitted) {
+                        event.preventDefault();
+                        return false;
+                    }
+                    NINJA.formIsSubmitted = true;
+
+                    // Disable the submit button to prevent repeated clicks
+                    $form.find('button').prop('disabled', true);
+                    $('#js-error-message').hide();
+
                     // Insert the token into the form so it gets submitted to the server
                     $form.append($('<input type="hidden" name="sourceToken"/>').val(e.nonce));
                     // and submit
                     $form.get(0).submit();
                 }
             });
-            $('.payment-form').submit(function(event) {
-                var $form = $(this);
-
-                // Disable the submit button to prevent repeated clicks
-                $form.find('button').prop('disabled', true);
-                $('#js-error-message').hide();
-            });
         });
     </script>
 @stop
diff --git a/resources/views/payments/credit_card.blade.php b/resources/views/payments/credit_card.blade.php
index 07a4e8c2a91e..b0e9624c3b41 100644
--- a/resources/views/payments/credit_card.blade.php
+++ b/resources/views/payments/credit_card.blade.php
@@ -47,9 +47,14 @@
 
         $(function() {
             $('.payment-form').submit(function(event) {
-                var $form = $(this);
+                if (NINJA.formIsSubmitted) {
+                    event.preventDefault();
+                    return false;
+                }
+                NINJA.formIsSubmitted = true;
 
                 // Disable the submit button to prevent repeated clicks
+                var $form = $(this);
                 $form.find('button').prop('disabled', true);
 
                 return true;
diff --git a/resources/views/payments/stripe/bank_transfer.blade.php b/resources/views/payments/stripe/bank_transfer.blade.php
index 35690db9bb6e..2925b501ac94 100644
--- a/resources/views/payments/stripe/bank_transfer.blade.php
+++ b/resources/views/payments/stripe/bank_transfer.blade.php
@@ -9,7 +9,15 @@
         $(function() {
             var countries = {!! Cache::get('countries')->pluck('iso_3166_2','id') !!};
             $('.payment-form').submit(function(event) {
-                if($('[name=plaidAccountId]').length)return;
+                if ($('[name=plaidAccountId]').length) {
+                    return false;
+                }
+
+                event.preventDefault();
+                if (NINJA.formIsSubmitted) {
+                    return false;
+                }
+                NINJA.formIsSubmitted = true;
 
                 var $form = $(this);
 
diff --git a/resources/views/payments/stripe/credit_card.blade.php b/resources/views/payments/stripe/credit_card.blade.php
index 0d428625736e..9ae03559466d 100644
--- a/resources/views/payments/stripe/credit_card.blade.php
+++ b/resources/views/payments/stripe/credit_card.blade.php
@@ -8,9 +8,16 @@
         <script type="text/javascript">
             Stripe.setPublishableKey('{{ $accountGateway->getPublishableStripeKey() }}');
             $(function() {
-                var countries = {!! Cache::get('countries')->pluck('iso_3166_2','id') !!};
                 $('.payment-form').unbind('submit').submit(function(event) {
-                    if($('[name=plaidAccountId]').length)return;
+                    event.preventDefault();
+                    if (NINJA.formIsSubmitted) {
+                        return false;
+                    }
+                    NINJA.formIsSubmitted = true;
+
+                    if ($('[name=plaidAccountId]').length) {
+                        return;
+                    }
 
                     var $form = $(this);
 
diff --git a/resources/views/payments/wepay/credit_card.blade.php b/resources/views/payments/wepay/credit_card.blade.php
index 3e8e8c62df2f..911c11d55e52 100644
--- a/resources/views/payments/wepay/credit_card.blade.php
+++ b/resources/views/payments/wepay/credit_card.blade.php
@@ -11,6 +11,12 @@
             WePay.set_endpoint('{{ WEPAY_ENVIRONMENT }}');
             var $form = $('.payment-form');
             $('.payment-form').submit(function(event) {
+                event.preventDefault();
+                if (NINJA.formIsSubmitted) {
+                    return false;
+                }
+                NINJA.formIsSubmitted = true;
+
                 var data = {
                     client_id: {{ WEPAY_CLIENT_ID }},
                     user_name: $('#first_name').val() + ' ' + $('#last_name').val(),