From ce3bf784cae9787f6da2fce7ef59629d465d71a6 Mon Sep 17 00:00:00 2001
From: David Bomba <turbo124@gmail.com>
Date: Sun, 22 Jan 2023 09:45:46 +1100
Subject: [PATCH] Tests for refactoring entity file names and formatting entity
 numbers for file names

---
 app/Models/BaseModel.php             |  2 +-
 tests/Unit/EntityTranslationTest.php | 30 ++++++++++++++++++++++++++--
 2 files changed, 29 insertions(+), 3 deletions(-)

diff --git a/app/Models/BaseModel.php b/app/Models/BaseModel.php
index d9f8d345d2a5..366b717b3951 100644
--- a/app/Models/BaseModel.php
+++ b/app/Models/BaseModel.php
@@ -188,7 +188,7 @@ class BaseModel extends Model
 
     public function numberFormatter()
     {
-        $number = strlen($this->number) >= 1 ? class_basename($this) . "_" . $this->number : class_basename($this) . "_" . Str::random(5); 
+        $number = strlen($this->number) >= 1 ? $this->translate_entity() . "_" . $this->number : class_basename($this) . "_" . Str::random(5); 
 
         $formatted_number =  mb_ereg_replace("([^\w\s\d\-_~,;\[\]\(\).])", '', $number);
         
diff --git a/tests/Unit/EntityTranslationTest.php b/tests/Unit/EntityTranslationTest.php
index 82a1cc12738a..4922b0e48d10 100644
--- a/tests/Unit/EntityTranslationTest.php
+++ b/tests/Unit/EntityTranslationTest.php
@@ -20,6 +20,7 @@ use App\Models\Invoice;
 use App\Models\Payment;
 use App\Models\Product;
 use App\Models\Project;
+use App\Models\PurchaseOrder;
 use App\Models\Quote;
 use App\Models\RecurringExpense;
 use App\Models\RecurringInvoice;
@@ -27,8 +28,6 @@ use App\Models\RecurringQuote;
 use App\Models\Task;
 use App\Models\User;
 use App\Models\Vendor;
-use Illuminate\Foundation\Testing\DatabaseTransactions;
-use Tests\MockAccountData;
 use Tests\TestCase;
 
 /**
@@ -70,6 +69,7 @@ class EntityTranslationTest extends TestCase
             'company_id' => $company->id,
             'user_id' => $u->id,
             'client_id' => $client->id,
+            'number' => 'xxx',
         ]);
 
         $expense = Expense::factory()->create([
@@ -82,6 +82,7 @@ class EntityTranslationTest extends TestCase
             'company_id' => $company->id,
             'user_id' => $u->id,
             'client_id' => $client->id,
+            'number' => 'xxx',
         ]);
 
         $payment = Payment::factory()->create([
@@ -105,6 +106,7 @@ class EntityTranslationTest extends TestCase
             'company_id' => $company->id,
             'user_id' => $u->id,
             'client_id' => $client->id,
+            'number' => 'xxx',
         ]);
 
         $recurring_expense = RecurringExpense::factory()->create([
@@ -117,6 +119,7 @@ class EntityTranslationTest extends TestCase
             'company_id' => $company->id,
             'user_id' => $u->id,
             'client_id' => $client->id,
+            'number' => 'xxx',
         ]);
 
         $recurring_quote = RecurringQuote::factory()->create([
@@ -131,11 +134,19 @@ class EntityTranslationTest extends TestCase
             'client_id' => $client->id,
         ]);
 
+
         $vendor = Vendor::factory()->create([
             'company_id' => $company->id,
             'user_id' => $u->id,
         ]);
 
+        $po = PurchaseOrder::factory()->create([
+            'company_id' => $company->id,
+            'user_id' => $u->id,
+            'vendor_id' => $vendor->id,
+            'number' => 'xxx',
+        ]);
+
         $this->assertEquals(ctrans('texts.user'), $u->translate_entity());
         $this->assertEquals(ctrans('texts.company'), $company->translate_entity());
         $this->assertEquals(ctrans('texts.client'), $client->translate_entity());
@@ -151,5 +162,20 @@ class EntityTranslationTest extends TestCase
         $this->assertEquals(ctrans('texts.recurring_quote'), $recurring_quote->translate_entity());
         $this->assertEquals(ctrans('texts.task'), $task->translate_entity());
         $this->assertEquals(ctrans('texts.vendor'), $vendor->translate_entity());
+        $this->assertEquals(ctrans('texts.purchase_order'), $po->translate_entity());
+
+        $this->assertEquals(str_replace(" ", "_", ctrans('texts.purchase_order')) . "_xxx.pdf", $po->getFileName());
+        $this->assertEquals(str_replace(" ", "_", ctrans('texts.credit')) . "_xxx.pdf", $credit->getFileName());
+        $this->assertEquals(str_replace(" ", "_", ctrans('texts.invoice')) . "_xxx.pdf", $invoice->getFileName());
+        $this->assertEquals(str_replace(" ", "_", ctrans('texts.quote')) . "_xxx.pdf", $quote->getFileName());
+        $this->assertEquals(str_replace(" ", "_", ctrans('texts.recurring_invoice')) . "_xxx.pdf", $recurring_invoice->getFileName());
+
+        $this->assertEquals(str_replace(" ", "_", ctrans('texts.recurring_invoice')) . "_xxx", $recurring_invoice->numberFormatter());
+        $this->assertEquals(str_replace(" ", "_", ctrans('texts.credit')) . "_xxx", $credit->numberFormatter());
+        $this->assertEquals(str_replace(" ", "_", ctrans('texts.invoice')) . "_xxx", $invoice->numberFormatter());
+        $this->assertEquals(str_replace(" ", "_", ctrans('texts.quote')) . "_xxx", $quote->numberFormatter());
+        $this->assertEquals(str_replace(" ", "_", ctrans('texts.purchase_order')) . "_xxx", $po->numberFormatter());
+
+
     }
 }