Fixes for deleted payments leaking on invoices

This commit is contained in:
David Bomba 2023-07-27 17:49:22 +10:00
parent 44bf2d851e
commit d29a91e508

View File

@ -650,20 +650,20 @@ class BaseExport
} }
if($column == 'amount') if($column == 'amount')
return $entity->payments()->exists() ? $entity->payments()->sum('paymentables.amount') : ctrans('texts.unpaid'); return $entity->payments()->exists() ? $entity->payments()->withoutTrashed()->sum('paymentables.amount') : ctrans('texts.unpaid');
if($column == 'refunded') { if($column == 'refunded') {
return $entity->payments()->exists() ? $entity->payments()->sum('paymentables.refunded') : 0; return $entity->payments()->exists() ? $entity->payments()->withoutTrashed()->sum('paymentables.refunded') : '';
} }
if($column == 'applied') { if($column == 'applied') {
$refunded = $entity->payments()->sum('paymentables.refunded'); $refunded = $entity->payments()->withoutTrashed()->sum('paymentables.refunded');
$amount = $entity->payments()->sum('paymentables.amount'); $amount = $entity->payments()->withoutTrashed()->sum('paymentables.amount');
return $entity->payments()->exists() ? ($amount - $refunded) : 0; return $entity->payments()->withoutTrashed()->exists() ? ($amount - $refunded) : '';
} }
$payment = $entity->payments()->first(); $payment = $entity->payments()->withoutTrashed()->first();
if(!$payment) if(!$payment)
return ''; return '';