From cf4316b5ab5707d40eba291138eac3966aec2ce8 Mon Sep 17 00:00:00 2001 From: David Bomba Date: Sat, 9 Oct 2021 18:07:05 +1100 Subject: [PATCH 01/26] Allow disconnect from Stripe Connect --- app/Http/Controllers/StripeController.php | 14 ++++++++++++++ app/PaymentDrivers/StripePaymentDriver.php | 5 +++++ app/Utils/HtmlEngine.php | 3 +++ routes/api.php | 1 + 4 files changed, 23 insertions(+) diff --git a/app/Http/Controllers/StripeController.php b/app/Http/Controllers/StripeController.php index 61d412a1c29f..1f303b7fc39d 100644 --- a/app/Http/Controllers/StripeController.php +++ b/app/Http/Controllers/StripeController.php @@ -17,9 +17,11 @@ use App\Jobs\Util\StripeUpdatePaymentMethods; use App\Libraries\MultiDB; use App\Models\Client; use App\Models\CompanyGateway; +use App\Utils\Traits\MakesHash; class StripeController extends BaseController { + use MakesHash; private $stripe_keys = ['d14dd26a47cecc30fdd65700bfb67b34', 'd14dd26a37cecc30fdd65700bfb55b23']; @@ -75,4 +77,16 @@ class StripeController extends BaseController return response()->json(['message' => 'Unauthorized'], 403); } + + public function disconnect(string $company_gateway_id) + { + + $company_gateway = CompanyGateway::where('company_id', auth()->user()->company()->id) + ->where('id', $this->decodePrimaryKey($company_gateway_id)) + ->whereIn('gateway_key', $this->stripe_keys) + ->firstOrFail(); + + return $company_gateway->driver()->disconnect(); + + } } \ No newline at end of file diff --git a/app/PaymentDrivers/StripePaymentDriver.php b/app/PaymentDrivers/StripePaymentDriver.php index 604a4a89c5ba..181bed60cb36 100644 --- a/app/PaymentDrivers/StripePaymentDriver.php +++ b/app/PaymentDrivers/StripePaymentDriver.php @@ -636,6 +636,11 @@ class StripePaymentDriver extends BaseDriver 'stripe_user_id' => $this->company_gateway->getConfigField('account_id'), ]); + $config = $this->company_gateway->getConfig(); + $config->account_id = ""; + $this->company_gateway->setConfig($config); + $this->company_gateway->save(); + } catch(\Exception $e){ throw new StripeConnectFailure('Unable to disconnect Stripe Connect'); diff --git a/app/Utils/HtmlEngine.php b/app/Utils/HtmlEngine.php index 03d8ffc1a2d6..de8cd6698856 100644 --- a/app/Utils/HtmlEngine.php +++ b/app/Utils/HtmlEngine.php @@ -203,6 +203,7 @@ class HtmlEngine if ($this->entity->partial > 0) { $data['$balance_due'] = ['value' => Number::formatMoney($this->entity->partial, $this->client) ?: ' ', 'label' => ctrans('texts.partial_due')]; $data['$balance_due_raw'] = ['value' => $this->entity->partial, 'label' => ctrans('texts.partial_due')]; + $data['$amount_raw'] = ['value' => $this->entity->partial, 'label' => ctrans('texts.partial_due')]; $data['$due_date'] = ['value' => $this->translateDate($this->entity->partial_due_date, $this->client->date_format(), $this->client->locale()) ?: ' ', 'label' => ctrans('texts.'.$this->entity_string.'_due_date')]; } else { @@ -210,10 +211,12 @@ class HtmlEngine if($this->entity->status_id == 1){ $data['$balance_due'] = ['value' => Number::formatMoney($this->entity->amount, $this->client) ?: ' ', 'label' => ctrans('texts.balance_due')]; $data['$balance_due_raw'] = ['value' => $this->entity->amount, 'label' => ctrans('texts.balance_due')]; + $data['$amount_raw'] = ['value' => $this->entity->amount, 'label' => ctrans('texts.amount')]; } else{ $data['$balance_due'] = ['value' => Number::formatMoney($this->entity->balance, $this->client) ?: ' ', 'label' => ctrans('texts.balance_due')]; $data['$balance_due_raw'] = ['value' => $this->entity->balance, 'label' => ctrans('texts.balance_due')]; + $data['$amount_raw'] = ['value' => $this->entity->amount, 'label' => ctrans('texts.amount')]; } } diff --git a/routes/api.php b/routes/api.php index 8e230cf3bf27..96e445e4a169 100644 --- a/routes/api.php +++ b/routes/api.php @@ -199,6 +199,7 @@ Route::group(['middleware' => ['api_db', 'token_auth', 'locale'], 'prefix' => 'a Route::post('stripe/import_customers', 'StripeController@import')->middleware('password_protected')->name('stripe.import'); Route::post('stripe/verify', 'StripeController@verify')->middleware('password_protected')->name('stripe.verify'); + Route::post('stripe/disconnect/{company_gateway_id}', 'StripeController@disconnect')->middleware('password_protected')->name('stripe.disconnect'); Route::resource('subscriptions', 'SubscriptionController'); Route::post('subscriptions/bulk', 'SubscriptionController@bulk')->name('subscriptions.bulk'); From f41b49ad7ec581c2f9a3877d7fedbcc651ecf350 Mon Sep 17 00:00:00 2001 From: Lars Kusch Date: Sat, 9 Oct 2021 10:09:04 +0200 Subject: [PATCH 02/26] Implement Stripe Giropay --- app/Models/Gateway.php | 3 +- app/Models/GatewayType.php | 5 +- app/PaymentDrivers/Stripe/GIROPAY.php | 141 ++++++++++++++++++ app/PaymentDrivers/StripePaymentDriver.php | 7 + .../js/clients/payments/stripe-giropay.js | 57 +++++++ 5 files changed, 211 insertions(+), 2 deletions(-) create mode 100644 app/PaymentDrivers/Stripe/GIROPAY.php create mode 100644 resources/js/clients/payments/stripe-giropay.js diff --git a/app/Models/Gateway.php b/app/Models/Gateway.php index 8bd0b64eb09f..5c34d4cf057b 100644 --- a/app/Models/Gateway.php +++ b/app/Models/Gateway.php @@ -104,7 +104,8 @@ class Gateway extends StaticModel GatewayType::ALIPAY => ['refund' => false, 'token_billing' => false], GatewayType::APPLE_PAY => ['refund' => false, 'token_billing' => false], GatewayType::SOFORT => ['refund' => true, 'token_billing' => true, 'webhooks' => ['source.chargeable', 'charge.succeeded']], //Stripe - GatewayType::SEPA => ['refund' => true, 'token_billing' => true, 'webhooks' => ['source.chargeable', 'charge.succeeded']]]; + GatewayType::SEPA => ['refund' => true, 'token_billing' => true, 'webhooks' => ['source.chargeable', 'charge.succeeded']], + GatewayType::GIROPAY => ['refund' => true, 'token_billing' => true, 'webhooks' => ['source.chargeable', 'charge.succeeded']]]; case 39: return [GatewayType::CREDIT_CARD => ['refund' => true, 'token_billing' => true]]; //Checkout break; diff --git a/app/Models/GatewayType.php b/app/Models/GatewayType.php index 7a77a56e5142..6397cef7fc6e 100644 --- a/app/Models/GatewayType.php +++ b/app/Models/GatewayType.php @@ -29,7 +29,8 @@ class GatewayType extends StaticModel const BANCONTACT = 12; const IDEAL = 13; const HOSTED_PAGE = 14; // For gateways that contain multiple methods. - + const GIROPAY = 15; + public function gateway() { return $this->belongsTo(Gateway::class); @@ -69,6 +70,8 @@ class GatewayType extends StaticModel return ctrans('texts.ideal'); case self::HOSTED_PAGE: return ctrans('texts.aio_checkout'); + case self::GIROPAY: + return ctrans('texts.giropay'); default: return 'Undefined.'; break; diff --git a/app/PaymentDrivers/Stripe/GIROPAY.php b/app/PaymentDrivers/Stripe/GIROPAY.php new file mode 100644 index 000000000000..ceb2b9f09ca8 --- /dev/null +++ b/app/PaymentDrivers/Stripe/GIROPAY.php @@ -0,0 +1,141 @@ +stripe = $stripe; + } + + public function authorizeView($data) + { + return render('gateways.stripe.giropay.authorize', $data); + } + + public function paymentView(array $data) + { + $data['gateway'] = $this->stripe; + $data['return_url'] = $this->buildReturnUrl(); + $data['stripe_amount'] = $this->stripe->convertToStripeAmount($data['total']['amount_with_fee'], $this->stripe->client->currency()->precision, $this->stripe->client->currency()); + $data['client'] = $this->stripe->client; + $data['customer'] = $this->stripe->findOrCreateCustomer()->id; + $data['country'] = $this->stripe->client->country->iso_3166_2; + + $intent = \Stripe\PaymentIntent::create([ + 'amount' => $data['stripe_amount'], + 'currency' => 'eur', + 'payment_method_types' => ['giropay'], + 'customer' => $this->stripe->findOrCreateCustomer(), + 'description' => $this->stripe->decodeUnicodeString(ctrans('texts.invoices') . ': ' . collect($data['invoices'])->pluck('invoice_number')), + + ]); + + $data['pi_client_secret'] = $intent->client_secret; + + $this->stripe->payment_hash->data = array_merge((array) $this->stripe->payment_hash->data, ['stripe_amount' => $data['stripe_amount']]); + $this->stripe->payment_hash->save(); + + return render('gateways.stripe.giropay.pay', $data); + } + + private function buildReturnUrl(): string + { + return route('client.payments.response', [ + 'company_gateway_id' => $this->stripe->company_gateway->id, + 'payment_hash' => $this->stripe->payment_hash->hash, + 'payment_method_id' => GatewayType::GIROPAY, + ]); + } + + public function paymentResponse($request) + { + $this->stripe->payment_hash->data = array_merge((array) $this->stripe->payment_hash->data, $request->all()); + $this->stripe->payment_hash->save(); + + if ($request->redirect_status == 'succeeded') { + return $this->processSuccessfulPayment($request->payment_intent); + } + + return $this->processUnsuccessfulPayment(); + } + + public function processSuccessfulPayment(string $payment_intent) + { + /* @todo: https://github.com/invoiceninja/invoiceninja/pull/3789/files#r436175798 */ + + $this->stripe->init(); + + $data = [ + 'payment_method' => $payment_intent, + 'payment_type' => PaymentType::GIROPAY, + 'amount' => $this->stripe->convertFromStripeAmount($this->stripe->payment_hash->data->stripe_amount, $this->stripe->client->currency()->precision, $this->stripe->client->currency()), + 'transaction_reference' => $payment_intent, + 'gateway_type_id' => GatewayType::GIROPAY, + ]; + + $this->stripe->createPayment($data, Payment::STATUS_PENDING); + + SystemLogger::dispatch( + ['response' => $this->stripe->payment_hash->data, 'data' => $data], + SystemLog::CATEGORY_GATEWAY_RESPONSE, + SystemLog::EVENT_GATEWAY_SUCCESS, + SystemLog::TYPE_STRIPE, + $this->stripe->client, + $this->stripe->client->company, + ); + + return redirect()->route('client.payments.index'); + } + + public function processUnsuccessfulPayment() + { + $server_response = $this->stripe->payment_hash->data; + + PaymentFailureMailer::dispatch( + $this->stripe->client, + $server_response, + $this->stripe->client->company, + $this->stripe->convertFromStripeAmount($this->stripe->payment_hash->data->stripe_amount, $this->stripe->client->currency()->precision, $this->stripe->client->currency()) + ); + + $message = [ + 'server_response' => $server_response, + 'data' => $this->stripe->payment_hash->data, + ]; + + SystemLogger::dispatch( + $message, + SystemLog::CATEGORY_GATEWAY_RESPONSE, + SystemLog::EVENT_GATEWAY_FAILURE, + SystemLog::TYPE_STRIPE, + $this->stripe->client, + $this->stripe->client->company, + ); + + throw new PaymentFailed('Failed to process the payment.', 500); + } +} diff --git a/app/PaymentDrivers/StripePaymentDriver.php b/app/PaymentDrivers/StripePaymentDriver.php index 604a4a89c5ba..ac71bad6bbab 100644 --- a/app/PaymentDrivers/StripePaymentDriver.php +++ b/app/PaymentDrivers/StripePaymentDriver.php @@ -33,6 +33,7 @@ use App\PaymentDrivers\Stripe\CreditCard; use App\PaymentDrivers\Stripe\ImportCustomers; use App\PaymentDrivers\Stripe\SOFORT; use App\PaymentDrivers\Stripe\SEPA; +use App\PaymentDrivers\Stripe\GIROPAY; use App\PaymentDrivers\Stripe\UpdatePaymentMethods; use App\PaymentDrivers\Stripe\Utilities; use App\Utils\Traits\MakesHash; @@ -77,6 +78,7 @@ class StripePaymentDriver extends BaseDriver GatewayType::SOFORT => SOFORT::class, GatewayType::APPLE_PAY => ApplePay::class, GatewayType::SEPA => SEPA::class, + GatewayType::GIROPAY => GIROPAY::class, ]; const SYSTEM_LOG_TYPE = SystemLog::TYPE_STRIPE; @@ -153,6 +155,11 @@ class StripePaymentDriver extends BaseDriver $types[] = GatewayType::SEPA; } + if ($this -> client + && isset($this->client->country) + && in_array($this->client->country->iso_3166_3, ["DEU"])) + $types[] = GatewayType::GIROPAY; + return $types; } diff --git a/resources/js/clients/payments/stripe-giropay.js b/resources/js/clients/payments/stripe-giropay.js new file mode 100644 index 000000000000..141a83acdebd --- /dev/null +++ b/resources/js/clients/payments/stripe-giropay.js @@ -0,0 +1,57 @@ +/** + * Invoice Ninja (https://invoiceninja.com) + * + * @link https://github.com/invoiceninja/invoiceninja source repository + * + * @copyright Copyright (c) 2021. Invoice Ninja LLC (https://invoiceninja.com) + * + * @license https://opensource.org/licenses/AAL + */ + +class ProcessGiroPay { + constructor(key, stripeConnect) { + this.key = key; + this.errors = document.getElementById('errors'); + this.stripeConnect = stripeConnect; + } + + setupStripe = () => { + this.stripe = Stripe(this.key); + + if(this.stripeConnect) + this.stripe.stripeAccount = stripeConnect; + + return this; + }; + + handle = () => { + document.getElementById('pay-now').addEventListener('click', (e) => { + document.getElementById('pay-now').disabled = true; + document.querySelector('#pay-now > svg').classList.remove('hidden'); + document.querySelector('#pay-now > span').classList.add('hidden'); + + this.stripe.confirmGiropayPayment( + document.querySelector('meta[name=pi-client-secret').content, + { + payment_method: { + billing_details: { + name: "", + }, + }, + return_url: document.querySelector( + 'meta[name="return-url"]' + ).content, + } + ); + }); + }; +} + +const publishableKey = document.querySelector( + 'meta[name="stripe-publishable-key"]' +)?.content ?? ''; + +const stripeConnect = + document.querySelector('meta[name="stripe-account-id"]')?.content ?? ''; + +new ProcessGiroPay(publishableKey, stripeConnect).setupStripe().handle(); From 58dfc17d5679bca66d31c098f2d2cfd0f02245ae Mon Sep 17 00:00:00 2001 From: Lars Kusch Date: Sat, 9 Oct 2021 10:11:08 +0200 Subject: [PATCH 03/26] Added views --- .../stripe/giropay/authorize.blade.php | 7 +++++ .../gateways/stripe/giropay/pay.blade.php | 27 +++++++++++++++++++ 2 files changed, 34 insertions(+) create mode 100644 resources/views/portal/ninja2020/gateways/stripe/giropay/authorize.blade.php create mode 100644 resources/views/portal/ninja2020/gateways/stripe/giropay/pay.blade.php diff --git a/resources/views/portal/ninja2020/gateways/stripe/giropay/authorize.blade.php b/resources/views/portal/ninja2020/gateways/stripe/giropay/authorize.blade.php new file mode 100644 index 000000000000..ceb2d28000d5 --- /dev/null +++ b/resources/views/portal/ninja2020/gateways/stripe/giropay/authorize.blade.php @@ -0,0 +1,7 @@ +@extends('portal.ninja2020.layout.payments', ['gateway_title' => ctrans('texts.bank_account'), 'card_title' => ctrans('texts.bank_account')]) + +@section('gateway_content') + @component('portal.ninja2020.components.general.card-element-single', ['title' => ctrans('texts.bank_account'), 'show_title' => false]) + {{ __('texts.sofort_authorize_label') }} + @endcomponent +@endsection diff --git a/resources/views/portal/ninja2020/gateways/stripe/giropay/pay.blade.php b/resources/views/portal/ninja2020/gateways/stripe/giropay/pay.blade.php new file mode 100644 index 000000000000..230a7bbe0217 --- /dev/null +++ b/resources/views/portal/ninja2020/gateways/stripe/giropay/pay.blade.php @@ -0,0 +1,27 @@ +@extends('portal.ninja2020.layout.payments', ['gateway_title' => 'GiroPay', 'card_title' => 'GiroPay']) + +@section('gateway_head') + + + + + + + +@endsection + +@section('gateway_content') + + + @include('portal.ninja2020.gateways.includes.payment_details') + + @component('portal.ninja2020.components.general.card-element', ['title' => ctrans('texts.payment_type')]) + {{ ctrans('texts.giropay') }} ({{ ctrans('texts.bank_transfer') }}) + @endcomponent + @include('portal.ninja2020.gateways.includes.pay_now') +@endsection + +@push('footer') + + +@endpush From f7a97eb2e78d1d5cca195e05452bee5cf0869a09 Mon Sep 17 00:00:00 2001 From: Lars Kusch Date: Sat, 9 Oct 2021 10:12:23 +0200 Subject: [PATCH 04/26] Added language strings --- resources/lang/en/texts.php | 1 + 1 file changed, 1 insertion(+) diff --git a/resources/lang/en/texts.php b/resources/lang/en/texts.php index f98e37eb0f1a..3c93ae4e1cca 100644 --- a/resources/lang/en/texts.php +++ b/resources/lang/en/texts.php @@ -4320,6 +4320,7 @@ $LANG = array( 'ideal' => 'iDEAL', 'bank_account_holder' => 'Bank Account Holder', 'aio_checkout' => 'All-in-one checkout', + 'giropay' => 'GiroPay', ); return $LANG; From 780b4009471d41956ca7eff2a9467e9699e2f88f Mon Sep 17 00:00:00 2001 From: Lars Kusch Date: Sat, 9 Oct 2021 10:14:01 +0200 Subject: [PATCH 05/26] Added payment type --- app/Models/PaymentType.php | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/app/Models/PaymentType.php b/app/Models/PaymentType.php index faaeb9052f0a..a77b5f81addc 100644 --- a/app/Models/PaymentType.php +++ b/app/Models/PaymentType.php @@ -45,8 +45,9 @@ class PaymentType extends StaticModel const MOLLIE_BANK_TRANSFER = 34; const KBC = 35; const BANCONTACT = 36; - const IDEAL = 37; + const IDEAL = 37; const HOSTED_PAGE = 38; + const GIROPAY = 39; public static function parseCardType($cardName) { From ed393d837f0329b7f41ec4bbea15d140a465be67 Mon Sep 17 00:00:00 2001 From: Lars Kusch Date: Sat, 9 Oct 2021 10:19:12 +0200 Subject: [PATCH 06/26] Adapt views --- resources/js/clients/payments/stripe-giropay.js | 2 +- .../gateways/stripe/giropay/giropay.blade.php | 11 +++++++++++ 2 files changed, 12 insertions(+), 1 deletion(-) create mode 100644 resources/views/portal/ninja2020/gateways/stripe/giropay/giropay.blade.php diff --git a/resources/js/clients/payments/stripe-giropay.js b/resources/js/clients/payments/stripe-giropay.js index 141a83acdebd..fc1c0a26977c 100644 --- a/resources/js/clients/payments/stripe-giropay.js +++ b/resources/js/clients/payments/stripe-giropay.js @@ -35,7 +35,7 @@ class ProcessGiroPay { { payment_method: { billing_details: { - name: "", + name: document.getElementById("giropay-name").value(), }, }, return_url: document.querySelector( diff --git a/resources/views/portal/ninja2020/gateways/stripe/giropay/giropay.blade.php b/resources/views/portal/ninja2020/gateways/stripe/giropay/giropay.blade.php new file mode 100644 index 000000000000..05a4d5c9e8e3 --- /dev/null +++ b/resources/views/portal/ninja2020/gateways/stripe/giropay/giropay.blade.php @@ -0,0 +1,11 @@ +
+ @component('portal.ninja2020.components.general.card-element', ['title' => ctrans('texts.name')]) + +
+ + +
+ @endcomponent +
From 013b47523c5dd55f439ec9e860117b2440876a3b Mon Sep 17 00:00:00 2001 From: Lars Kusch Date: Sat, 9 Oct 2021 10:20:10 +0200 Subject: [PATCH 07/26] Added language string --- resources/lang/en/texts.php | 1 + 1 file changed, 1 insertion(+) diff --git a/resources/lang/en/texts.php b/resources/lang/en/texts.php index 3c93ae4e1cca..cf5fc9e17714 100644 --- a/resources/lang/en/texts.php +++ b/resources/lang/en/texts.php @@ -4321,6 +4321,7 @@ $LANG = array( 'bank_account_holder' => 'Bank Account Holder', 'aio_checkout' => 'All-in-one checkout', 'giropay' => 'GiroPay', + 'giropay_law' => 'By entering your Customer information (such as name, sort code and account number) you (the Customer) agree that this information is given voluntarily.' ); return $LANG; From 72089e717bb801297083c707a0c84282b314dbb1 Mon Sep 17 00:00:00 2001 From: Lars Kusch Date: Sat, 9 Oct 2021 10:25:54 +0200 Subject: [PATCH 08/26] Added js --- public/js/clients/payments/stripe-giropay.js | 2 ++ public/js/clients/payments/stripe-giropay.js.LICENSE.txt | 9 +++++++++ 2 files changed, 11 insertions(+) create mode 100644 public/js/clients/payments/stripe-giropay.js create mode 100644 public/js/clients/payments/stripe-giropay.js.LICENSE.txt diff --git a/public/js/clients/payments/stripe-giropay.js b/public/js/clients/payments/stripe-giropay.js new file mode 100644 index 000000000000..674ef2bde1fe --- /dev/null +++ b/public/js/clients/payments/stripe-giropay.js @@ -0,0 +1,2 @@ +/*! For license information please see stripe-sofort.js.LICENSE.txt */ +!function(e){var t={};function n(r){if(t[r])return t[r].exports;var o=t[r]={i:r,l:!1,exports:{}};return e[r].call(o.exports,o,o.exports,n),o.l=!0,o.exports}n.m=e,n.c=t,n.d=function(e,t,r){n.o(e,t)||Object.defineProperty(e,t,{enumerable:!0,get:r})},n.r=function(e){"undefined"!=typeof Symbol&&Symbol.toStringTag&&Object.defineProperty(e,Symbol.toStringTag,{value:"Module"}),Object.defineProperty(e,"__esModule",{value:!0})},n.t=function(e,t){if(1&t&&(e=n(e)),8&t)return e;if(4&t&&"object"==typeof e&&e&&e.__esModule)return e;var r=Object.create(null);if(n.r(r),Object.defineProperty(r,"default",{enumerable:!0,value:e}),2&t&&"string"!=typeof e)for(var o in e)n.d(r,o,function(t){return e[t]}.bind(null,o));return r},n.n=function(e){var t=e&&e.__esModule?function(){return e.default}:function(){return e};return n.d(t,"a",t),t},n.o=function(e,t){return Object.prototype.hasOwnProperty.call(e,t)},n.p="/",n(n.s=6)}({6:function(e,t,n){e.exports=n("RFiP")},RFiP:function(e,t){var n,r,o,u;function i(e,t,n){return t in e?Object.defineProperty(e,t,{value:n,enumerable:!0,configurable:!0,writable:!0}):e[t]=n,e}var c=null!==(n=null===(r=document.querySelector('meta[name="stripe-publishable-key"]'))||void 0===r?void 0:r.content)&&void 0!==n?n:"",l=null!==(o=null===(u=document.querySelector('meta[name="stripe-account-id"]'))||void 0===u?void 0:u.content)&&void 0!==o?o:"";new function e(t,n){var r=this;!function(e,t){if(!(e instanceof t))throw new TypeError("Cannot call a class as a function")}(this,e),i(this,"setupStripe",(function(){return r.stripe=Stripe(r.key),r.stripeConnect&&(r.stripe.stripeAccount=l),r})),i(this,"handle",(function(){document.getElementById("pay-now").addEventListener("click",(function(e){document.getElementById("pay-now").disabled=!0,document.querySelector("#pay-now > svg").classList.remove("hidden"),document.querySelector("#pay-now > span").classList.add("hidden"),r.stripe.confirmSofortPayment(document.querySelector("meta[name=pi-client-secret").content,{payment_method:{sofort:{country:document.querySelector('meta[name="country"]').content}},return_url:document.querySelector('meta[name="return-url"]').content})}))})),this.key=t,this.errors=document.getElementById("errors"),this.stripeConnect=n}(c,l).setupStripe().handle()}}); \ No newline at end of file diff --git a/public/js/clients/payments/stripe-giropay.js.LICENSE.txt b/public/js/clients/payments/stripe-giropay.js.LICENSE.txt new file mode 100644 index 000000000000..585c6ab0e4fc --- /dev/null +++ b/public/js/clients/payments/stripe-giropay.js.LICENSE.txt @@ -0,0 +1,9 @@ +/** + * Invoice Ninja (https://invoiceninja.com) + * + * @link https://github.com/invoiceninja/invoiceninja source repository + * + * @copyright Copyright (c) 2021. Invoice Ninja LLC (https://invoiceninja.com) + * + * @license https://opensource.org/licenses/AAL + */ From 7b73d48acf13af70decd74be72c461adfcbb67e3 Mon Sep 17 00:00:00 2001 From: Lars Kusch Date: Sat, 9 Oct 2021 10:35:14 +0200 Subject: [PATCH 09/26] Changed js --- public/js/clients/payments/stripe-giropay.js | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/public/js/clients/payments/stripe-giropay.js b/public/js/clients/payments/stripe-giropay.js index 674ef2bde1fe..95804b551f5c 100644 --- a/public/js/clients/payments/stripe-giropay.js +++ b/public/js/clients/payments/stripe-giropay.js @@ -1,2 +1 @@ -/*! For license information please see stripe-sofort.js.LICENSE.txt */ -!function(e){var t={};function n(r){if(t[r])return t[r].exports;var o=t[r]={i:r,l:!1,exports:{}};return e[r].call(o.exports,o,o.exports,n),o.l=!0,o.exports}n.m=e,n.c=t,n.d=function(e,t,r){n.o(e,t)||Object.defineProperty(e,t,{enumerable:!0,get:r})},n.r=function(e){"undefined"!=typeof Symbol&&Symbol.toStringTag&&Object.defineProperty(e,Symbol.toStringTag,{value:"Module"}),Object.defineProperty(e,"__esModule",{value:!0})},n.t=function(e,t){if(1&t&&(e=n(e)),8&t)return e;if(4&t&&"object"==typeof e&&e&&e.__esModule)return e;var r=Object.create(null);if(n.r(r),Object.defineProperty(r,"default",{enumerable:!0,value:e}),2&t&&"string"!=typeof e)for(var o in e)n.d(r,o,function(t){return e[t]}.bind(null,o));return r},n.n=function(e){var t=e&&e.__esModule?function(){return e.default}:function(){return e};return n.d(t,"a",t),t},n.o=function(e,t){return Object.prototype.hasOwnProperty.call(e,t)},n.p="/",n(n.s=6)}({6:function(e,t,n){e.exports=n("RFiP")},RFiP:function(e,t){var n,r,o,u;function i(e,t,n){return t in e?Object.defineProperty(e,t,{value:n,enumerable:!0,configurable:!0,writable:!0}):e[t]=n,e}var c=null!==(n=null===(r=document.querySelector('meta[name="stripe-publishable-key"]'))||void 0===r?void 0:r.content)&&void 0!==n?n:"",l=null!==(o=null===(u=document.querySelector('meta[name="stripe-account-id"]'))||void 0===u?void 0:u.content)&&void 0!==o?o:"";new function e(t,n){var r=this;!function(e,t){if(!(e instanceof t))throw new TypeError("Cannot call a class as a function")}(this,e),i(this,"setupStripe",(function(){return r.stripe=Stripe(r.key),r.stripeConnect&&(r.stripe.stripeAccount=l),r})),i(this,"handle",(function(){document.getElementById("pay-now").addEventListener("click",(function(e){document.getElementById("pay-now").disabled=!0,document.querySelector("#pay-now > svg").classList.remove("hidden"),document.querySelector("#pay-now > span").classList.add("hidden"),r.stripe.confirmSofortPayment(document.querySelector("meta[name=pi-client-secret").content,{payment_method:{sofort:{country:document.querySelector('meta[name="country"]').content}},return_url:document.querySelector('meta[name="return-url"]').content})}))})),this.key=t,this.errors=document.getElementById("errors"),this.stripeConnect=n}(c,l).setupStripe().handle()}}); \ No newline at end of file +!function(e){var t={};function n(r){if(t[r])return t[r].exports;var o=t[r]={i:r,l:!1,exports:{}};return e[r].call(o.exports,o,o.exports,n),o.l=!0,o.exports}n.m=e,n.c=t,n.d=function(e,t,r){n.o(e,t)||Object.defineProperty(e,t,{enumerable:!0,get:r})},n.r=function(e){"undefined"!=typeof Symbol&&Symbol.toStringTag&&Object.defineProperty(e,Symbol.toStringTag,{value:"Module"}),Object.defineProperty(e,"__esModule",{value:!0})},n.t=function(e,t){if(1&t&&(e=n(e)),8&t)return e;if(4&t&&"object"==typeof e&&e&&e.__esModule)return e;var r=Object.create(null);if(n.r(r),Object.defineProperty(r,"default",{enumerable:!0,value:e}),2&t&&"string"!=typeof e)for(var o in e)n.d(r,o,function(t){return e[t]}.bind(null,o));return r},n.n=function(e){var t=e&&e.__esModule?function(){return e.default}:function(){return e};return n.d(t,"a",t),t},n.o=function(e,t){return Object.prototype.hasOwnProperty.call(e,t)},n.p="/",n(n.s=6)}({6:function(e,t,n){e.exports=n("RFiP")},RFiP:function(e,t){var n,r,o,i;function u(e,t,n){return t in e?Object.defineProperty(e,t,{value:n,enumerable:!0,configurable:!0,writable:!0}):e[t]=n,e}var c=null!==(n=null===(r=document.querySelector('meta[name="stripe-publishable-key"]'))||void 0===r?void 0:r.content)&&void 0!==n?n:"",l=null!==(o=null===(i=document.querySelector('meta[name="stripe-account-id"]'))||void 0===i?void 0:i.content)&&void 0!==o?o:"";new function e(t,n){var r=this;!function(e,t){if(!(e instanceof t))throw new TypeError("Cannot call a class as a function")}(this,e),u(this,"setupStripe",function(){return r.stripe=Stripe(r.key),r.stripeConnect&&(r.stripe.stripeAccount=l),r}),u(this,"handle",function(){document.getElementById("pay-now").addEventListener("click",function(e){document.getElementById("pay-now").disabled=!0,document.querySelector("#pay-now > svg").classList.remove("hidden"),document.querySelector("#pay-now > span").classList.add("hidden"),r.stripe.confirmGiropayPayment(document.querySelector("meta[name=pi-client-secret").content,{payment_method:{billing_details:{name:document.getElementById("giropay-name").value()}},return_url:document.querySelector('meta[name="return-url"]').content})})}),this.key=t,this.errors=document.getElementById("errors"),this.stripeConnect=n}(c,l).setupStripe().handle()}}); From ab34e296a662299c55b1cdf05fb8f4c2fa4e33ee Mon Sep 17 00:00:00 2001 From: Lars Kusch Date: Sat, 9 Oct 2021 10:37:32 +0200 Subject: [PATCH 10/26] Updated view --- .../views/portal/ninja2020/gateways/stripe/giropay/pay.blade.php | 1 + 1 file changed, 1 insertion(+) diff --git a/resources/views/portal/ninja2020/gateways/stripe/giropay/pay.blade.php b/resources/views/portal/ninja2020/gateways/stripe/giropay/pay.blade.php index 230a7bbe0217..faa0af1b58b9 100644 --- a/resources/views/portal/ninja2020/gateways/stripe/giropay/pay.blade.php +++ b/resources/views/portal/ninja2020/gateways/stripe/giropay/pay.blade.php @@ -18,6 +18,7 @@ @component('portal.ninja2020.components.general.card-element', ['title' => ctrans('texts.payment_type')]) {{ ctrans('texts.giropay') }} ({{ ctrans('texts.bank_transfer') }}) @endcomponent + @include('portal.ninja2020.gateways.stripe.giropay.giropay') @include('portal.ninja2020.gateways.includes.pay_now') @endsection From 6683affe472026ec7a361a93d96f339db733cdde Mon Sep 17 00:00:00 2001 From: Lars Kusch Date: Sat, 9 Oct 2021 10:40:32 +0200 Subject: [PATCH 11/26] Small fixes --- public/js/clients/payments/stripe-giropay.js | 2 +- resources/js/clients/payments/stripe-giropay.js | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/public/js/clients/payments/stripe-giropay.js b/public/js/clients/payments/stripe-giropay.js index 95804b551f5c..f9cfa7dc83dc 100644 --- a/public/js/clients/payments/stripe-giropay.js +++ b/public/js/clients/payments/stripe-giropay.js @@ -1 +1 @@ -!function(e){var t={};function n(r){if(t[r])return t[r].exports;var o=t[r]={i:r,l:!1,exports:{}};return e[r].call(o.exports,o,o.exports,n),o.l=!0,o.exports}n.m=e,n.c=t,n.d=function(e,t,r){n.o(e,t)||Object.defineProperty(e,t,{enumerable:!0,get:r})},n.r=function(e){"undefined"!=typeof Symbol&&Symbol.toStringTag&&Object.defineProperty(e,Symbol.toStringTag,{value:"Module"}),Object.defineProperty(e,"__esModule",{value:!0})},n.t=function(e,t){if(1&t&&(e=n(e)),8&t)return e;if(4&t&&"object"==typeof e&&e&&e.__esModule)return e;var r=Object.create(null);if(n.r(r),Object.defineProperty(r,"default",{enumerable:!0,value:e}),2&t&&"string"!=typeof e)for(var o in e)n.d(r,o,function(t){return e[t]}.bind(null,o));return r},n.n=function(e){var t=e&&e.__esModule?function(){return e.default}:function(){return e};return n.d(t,"a",t),t},n.o=function(e,t){return Object.prototype.hasOwnProperty.call(e,t)},n.p="/",n(n.s=6)}({6:function(e,t,n){e.exports=n("RFiP")},RFiP:function(e,t){var n,r,o,i;function u(e,t,n){return t in e?Object.defineProperty(e,t,{value:n,enumerable:!0,configurable:!0,writable:!0}):e[t]=n,e}var c=null!==(n=null===(r=document.querySelector('meta[name="stripe-publishable-key"]'))||void 0===r?void 0:r.content)&&void 0!==n?n:"",l=null!==(o=null===(i=document.querySelector('meta[name="stripe-account-id"]'))||void 0===i?void 0:i.content)&&void 0!==o?o:"";new function e(t,n){var r=this;!function(e,t){if(!(e instanceof t))throw new TypeError("Cannot call a class as a function")}(this,e),u(this,"setupStripe",function(){return r.stripe=Stripe(r.key),r.stripeConnect&&(r.stripe.stripeAccount=l),r}),u(this,"handle",function(){document.getElementById("pay-now").addEventListener("click",function(e){document.getElementById("pay-now").disabled=!0,document.querySelector("#pay-now > svg").classList.remove("hidden"),document.querySelector("#pay-now > span").classList.add("hidden"),r.stripe.confirmGiropayPayment(document.querySelector("meta[name=pi-client-secret").content,{payment_method:{billing_details:{name:document.getElementById("giropay-name").value()}},return_url:document.querySelector('meta[name="return-url"]').content})})}),this.key=t,this.errors=document.getElementById("errors"),this.stripeConnect=n}(c,l).setupStripe().handle()}}); +!function(e){var t={};function n(r){if(t[r])return t[r].exports;var o=t[r]={i:r,l:!1,exports:{}};return e[r].call(o.exports,o,o.exports,n),o.l=!0,o.exports}n.m=e,n.c=t,n.d=function(e,t,r){n.o(e,t)||Object.defineProperty(e,t,{enumerable:!0,get:r})},n.r=function(e){"undefined"!=typeof Symbol&&Symbol.toStringTag&&Object.defineProperty(e,Symbol.toStringTag,{value:"Module"}),Object.defineProperty(e,"__esModule",{value:!0})},n.t=function(e,t){if(1&t&&(e=n(e)),8&t)return e;if(4&t&&"object"==typeof e&&e&&e.__esModule)return e;var r=Object.create(null);if(n.r(r),Object.defineProperty(r,"default",{enumerable:!0,value:e}),2&t&&"string"!=typeof e)for(var o in e)n.d(r,o,function(t){return e[t]}.bind(null,o));return r},n.n=function(e){var t=e&&e.__esModule?function(){return e.default}:function(){return e};return n.d(t,"a",t),t},n.o=function(e,t){return Object.prototype.hasOwnProperty.call(e,t)},n.p="/",n(n.s=6)}({6:function(e,t,n){e.exports=n("RFiP")},RFiP:function(e,t){var n,r,o,i;function u(e,t,n){return t in e?Object.defineProperty(e,t,{value:n,enumerable:!0,configurable:!0,writable:!0}):e[t]=n,e}var c=null!==(n=null===(r=document.querySelector('meta[name="stripe-publishable-key"]'))||void 0===r?void 0:r.content)&&void 0!==n?n:"",l=null!==(o=null===(i=document.querySelector('meta[name="stripe-account-id"]'))||void 0===i?void 0:i.content)&&void 0!==o?o:"";new function e(t,n){var r=this;!function(e,t){if(!(e instanceof t))throw new TypeError("Cannot call a class as a function")}(this,e),u(this,"setupStripe",function(){return r.stripe=Stripe(r.key),r.stripeConnect&&(r.stripe.stripeAccount=l),r}),u(this,"handle",function(){document.getElementById("pay-now").addEventListener("click",function(e){document.getElementById("pay-now").disabled=!0,document.querySelector("#pay-now > svg").classList.remove("hidden"),document.querySelector("#pay-now > span").classList.add("hidden"),r.stripe.confirmGiropayPayment(document.querySelector("meta[name=pi-client-secret").content,{payment_method:{billing_details:{name:document.getElementById("giropay-name").value}},return_url:document.querySelector('meta[name="return-url"]').content})})}),this.key=t,this.errors=document.getElementById("errors"),this.stripeConnect=n}(c,l).setupStripe().handle()}}); diff --git a/resources/js/clients/payments/stripe-giropay.js b/resources/js/clients/payments/stripe-giropay.js index fc1c0a26977c..ee7ae928546e 100644 --- a/resources/js/clients/payments/stripe-giropay.js +++ b/resources/js/clients/payments/stripe-giropay.js @@ -35,7 +35,7 @@ class ProcessGiroPay { { payment_method: { billing_details: { - name: document.getElementById("giropay-name").value(), + name: document.getElementById("giropay-name").value, }, }, return_url: document.querySelector( From af87f886975a5a271a3c99aecf85130a84bf3503 Mon Sep 17 00:00:00 2001 From: Lars Kusch Date: Sat, 9 Oct 2021 10:47:19 +0200 Subject: [PATCH 12/26] Added check for checkbox --- public/js/clients/payments/stripe-giropay.js | 2 +- resources/js/clients/payments/stripe-giropay.js | 8 ++++++++ 2 files changed, 9 insertions(+), 1 deletion(-) diff --git a/public/js/clients/payments/stripe-giropay.js b/public/js/clients/payments/stripe-giropay.js index f9cfa7dc83dc..add121c25afe 100644 --- a/public/js/clients/payments/stripe-giropay.js +++ b/public/js/clients/payments/stripe-giropay.js @@ -1 +1 @@ -!function(e){var t={};function n(r){if(t[r])return t[r].exports;var o=t[r]={i:r,l:!1,exports:{}};return e[r].call(o.exports,o,o.exports,n),o.l=!0,o.exports}n.m=e,n.c=t,n.d=function(e,t,r){n.o(e,t)||Object.defineProperty(e,t,{enumerable:!0,get:r})},n.r=function(e){"undefined"!=typeof Symbol&&Symbol.toStringTag&&Object.defineProperty(e,Symbol.toStringTag,{value:"Module"}),Object.defineProperty(e,"__esModule",{value:!0})},n.t=function(e,t){if(1&t&&(e=n(e)),8&t)return e;if(4&t&&"object"==typeof e&&e&&e.__esModule)return e;var r=Object.create(null);if(n.r(r),Object.defineProperty(r,"default",{enumerable:!0,value:e}),2&t&&"string"!=typeof e)for(var o in e)n.d(r,o,function(t){return e[t]}.bind(null,o));return r},n.n=function(e){var t=e&&e.__esModule?function(){return e.default}:function(){return e};return n.d(t,"a",t),t},n.o=function(e,t){return Object.prototype.hasOwnProperty.call(e,t)},n.p="/",n(n.s=6)}({6:function(e,t,n){e.exports=n("RFiP")},RFiP:function(e,t){var n,r,o,i;function u(e,t,n){return t in e?Object.defineProperty(e,t,{value:n,enumerable:!0,configurable:!0,writable:!0}):e[t]=n,e}var c=null!==(n=null===(r=document.querySelector('meta[name="stripe-publishable-key"]'))||void 0===r?void 0:r.content)&&void 0!==n?n:"",l=null!==(o=null===(i=document.querySelector('meta[name="stripe-account-id"]'))||void 0===i?void 0:i.content)&&void 0!==o?o:"";new function e(t,n){var r=this;!function(e,t){if(!(e instanceof t))throw new TypeError("Cannot call a class as a function")}(this,e),u(this,"setupStripe",function(){return r.stripe=Stripe(r.key),r.stripeConnect&&(r.stripe.stripeAccount=l),r}),u(this,"handle",function(){document.getElementById("pay-now").addEventListener("click",function(e){document.getElementById("pay-now").disabled=!0,document.querySelector("#pay-now > svg").classList.remove("hidden"),document.querySelector("#pay-now > span").classList.add("hidden"),r.stripe.confirmGiropayPayment(document.querySelector("meta[name=pi-client-secret").content,{payment_method:{billing_details:{name:document.getElementById("giropay-name").value}},return_url:document.querySelector('meta[name="return-url"]').content})})}),this.key=t,this.errors=document.getElementById("errors"),this.stripeConnect=n}(c,l).setupStripe().handle()}}); +!function(e){var t={};function n(r){if(t[r])return t[r].exports;var o=t[r]={i:r,l:!1,exports:{}};return e[r].call(o.exports,o,o.exports,n),o.l=!0,o.exports}n.m=e,n.c=t,n.d=function(e,t,r){n.o(e,t)||Object.defineProperty(e,t,{enumerable:!0,get:r})},n.r=function(e){"undefined"!=typeof Symbol&&Symbol.toStringTag&&Object.defineProperty(e,Symbol.toStringTag,{value:"Module"}),Object.defineProperty(e,"__esModule",{value:!0})},n.t=function(e,t){if(1&t&&(e=n(e)),8&t)return e;if(4&t&&"object"==typeof e&&e&&e.__esModule)return e;var r=Object.create(null);if(n.r(r),Object.defineProperty(r,"default",{enumerable:!0,value:e}),2&t&&"string"!=typeof e)for(var o in e)n.d(r,o,function(t){return e[t]}.bind(null,o));return r},n.n=function(e){var t=e&&e.__esModule?function(){return e.default}:function(){return e};return n.d(t,"a",t),t},n.o=function(e,t){return Object.prototype.hasOwnProperty.call(e,t)},n.p="/",n(n.s=6)}({6:function(e,t,n){e.exports=n("RFiP")},RFiP:function(e,t){var n,r,o,i;function u(e,t,n){return t in e?Object.defineProperty(e,t,{value:n,enumerable:!0,configurable:!0,writable:!0}):e[t]=n,e}var c=null!==(n=null===(r=document.querySelector('meta[name="stripe-publishable-key"]'))||void 0===r?void 0:r.content)&&void 0!==n?n:"",l=null!==(o=null===(i=document.querySelector('meta[name="stripe-account-id"]'))||void 0===i?void 0:i.content)&&void 0!==o?o:"";new function e(t,n){var r=this;!function(e,t){if(!(e instanceof t))throw new TypeError("Cannot call a class as a function")}(this,e),u(this,"setupStripe",function(){return r.stripe=Stripe(r.key),r.stripeConnect&&(r.stripe.stripeAccount=l),r}),u(this,"handle",function(){document.getElementById("pay-now").addEventListener("click",function(e){let t=document.getElementById("errors");if(!document.getElementById("giropay-mandate-acceptance").checked)return t.textContent="Accept Terms",t.hidden=!1,void console.log("Terms");document.getElementById("pay-now").disabled=!0,document.querySelector("#pay-now > svg").classList.remove("hidden"),document.querySelector("#pay-now > span").classList.add("hidden"),r.stripe.confirmGiropayPayment(document.querySelector("meta[name=pi-client-secret").content,{payment_method:{billing_details:{name:document.getElementById("giropay-name").value}},return_url:document.querySelector('meta[name="return-url"]').content})})}),this.key=t,this.errors=document.getElementById("errors"),this.stripeConnect=n}(c,l).setupStripe().handle()}}); diff --git a/resources/js/clients/payments/stripe-giropay.js b/resources/js/clients/payments/stripe-giropay.js index ee7ae928546e..bf751ef44610 100644 --- a/resources/js/clients/payments/stripe-giropay.js +++ b/resources/js/clients/payments/stripe-giropay.js @@ -26,6 +26,14 @@ class ProcessGiroPay { handle = () => { document.getElementById('pay-now').addEventListener('click', (e) => { + let errors = document.getElementById('errors'); + + if (!document.getElementById('giropay-mandate-acceptance').checked) { + errors.textContent = "Accept Terms"; + errors.hidden = false; + console.log("Terms"); + return ; + } document.getElementById('pay-now').disabled = true; document.querySelector('#pay-now > svg').classList.remove('hidden'); document.querySelector('#pay-now > span').classList.add('hidden'); From 30eddcc485059fc076970d10741737f67449e306 Mon Sep 17 00:00:00 2001 From: Lars Kusch Date: Sat, 9 Oct 2021 11:24:47 +0200 Subject: [PATCH 13/26] small fix --- app/PaymentDrivers/StripePaymentDriver.php | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/app/PaymentDrivers/StripePaymentDriver.php b/app/PaymentDrivers/StripePaymentDriver.php index ac71bad6bbab..61b19b6d72b7 100644 --- a/app/PaymentDrivers/StripePaymentDriver.php +++ b/app/PaymentDrivers/StripePaymentDriver.php @@ -183,7 +183,9 @@ class StripePaymentDriver extends BaseDriver case GatewayType::APPLE_PAY: return 'gateways.stripe.other'; break; - + case GatewayType::GIROPAY: + return 'gateways.stripe.giropay'; + break; default: break; } From e406554535a46e1e4dc3222989360c75c85c0598 Mon Sep 17 00:00:00 2001 From: Lars Kusch Date: Sat, 9 Oct 2021 11:19:48 +0200 Subject: [PATCH 14/26] Added files --- app/PaymentDrivers/Stripe/iDeal.php | 141 ++++++++++++++++++ public/js/clients/payments/stripe-ideal.js | 1 + .../payments/stripe-ideal.js.LICENSE.txt | 9 ++ resources/js/clients/payments/stripe-ideal.js | 65 ++++++++ .../gateways/stripe/ideal/authorize.blade.php | 7 + .../gateways/stripe/ideal/ideal.blade.php | 11 ++ .../gateways/stripe/ideal/pay.blade.php | 28 ++++ 7 files changed, 262 insertions(+) create mode 100644 app/PaymentDrivers/Stripe/iDeal.php create mode 100644 public/js/clients/payments/stripe-ideal.js create mode 100644 public/js/clients/payments/stripe-ideal.js.LICENSE.txt create mode 100644 resources/js/clients/payments/stripe-ideal.js create mode 100644 resources/views/portal/ninja2020/gateways/stripe/ideal/authorize.blade.php create mode 100644 resources/views/portal/ninja2020/gateways/stripe/ideal/ideal.blade.php create mode 100644 resources/views/portal/ninja2020/gateways/stripe/ideal/pay.blade.php diff --git a/app/PaymentDrivers/Stripe/iDeal.php b/app/PaymentDrivers/Stripe/iDeal.php new file mode 100644 index 000000000000..ceb2b9f09ca8 --- /dev/null +++ b/app/PaymentDrivers/Stripe/iDeal.php @@ -0,0 +1,141 @@ +stripe = $stripe; + } + + public function authorizeView($data) + { + return render('gateways.stripe.giropay.authorize', $data); + } + + public function paymentView(array $data) + { + $data['gateway'] = $this->stripe; + $data['return_url'] = $this->buildReturnUrl(); + $data['stripe_amount'] = $this->stripe->convertToStripeAmount($data['total']['amount_with_fee'], $this->stripe->client->currency()->precision, $this->stripe->client->currency()); + $data['client'] = $this->stripe->client; + $data['customer'] = $this->stripe->findOrCreateCustomer()->id; + $data['country'] = $this->stripe->client->country->iso_3166_2; + + $intent = \Stripe\PaymentIntent::create([ + 'amount' => $data['stripe_amount'], + 'currency' => 'eur', + 'payment_method_types' => ['giropay'], + 'customer' => $this->stripe->findOrCreateCustomer(), + 'description' => $this->stripe->decodeUnicodeString(ctrans('texts.invoices') . ': ' . collect($data['invoices'])->pluck('invoice_number')), + + ]); + + $data['pi_client_secret'] = $intent->client_secret; + + $this->stripe->payment_hash->data = array_merge((array) $this->stripe->payment_hash->data, ['stripe_amount' => $data['stripe_amount']]); + $this->stripe->payment_hash->save(); + + return render('gateways.stripe.giropay.pay', $data); + } + + private function buildReturnUrl(): string + { + return route('client.payments.response', [ + 'company_gateway_id' => $this->stripe->company_gateway->id, + 'payment_hash' => $this->stripe->payment_hash->hash, + 'payment_method_id' => GatewayType::GIROPAY, + ]); + } + + public function paymentResponse($request) + { + $this->stripe->payment_hash->data = array_merge((array) $this->stripe->payment_hash->data, $request->all()); + $this->stripe->payment_hash->save(); + + if ($request->redirect_status == 'succeeded') { + return $this->processSuccessfulPayment($request->payment_intent); + } + + return $this->processUnsuccessfulPayment(); + } + + public function processSuccessfulPayment(string $payment_intent) + { + /* @todo: https://github.com/invoiceninja/invoiceninja/pull/3789/files#r436175798 */ + + $this->stripe->init(); + + $data = [ + 'payment_method' => $payment_intent, + 'payment_type' => PaymentType::GIROPAY, + 'amount' => $this->stripe->convertFromStripeAmount($this->stripe->payment_hash->data->stripe_amount, $this->stripe->client->currency()->precision, $this->stripe->client->currency()), + 'transaction_reference' => $payment_intent, + 'gateway_type_id' => GatewayType::GIROPAY, + ]; + + $this->stripe->createPayment($data, Payment::STATUS_PENDING); + + SystemLogger::dispatch( + ['response' => $this->stripe->payment_hash->data, 'data' => $data], + SystemLog::CATEGORY_GATEWAY_RESPONSE, + SystemLog::EVENT_GATEWAY_SUCCESS, + SystemLog::TYPE_STRIPE, + $this->stripe->client, + $this->stripe->client->company, + ); + + return redirect()->route('client.payments.index'); + } + + public function processUnsuccessfulPayment() + { + $server_response = $this->stripe->payment_hash->data; + + PaymentFailureMailer::dispatch( + $this->stripe->client, + $server_response, + $this->stripe->client->company, + $this->stripe->convertFromStripeAmount($this->stripe->payment_hash->data->stripe_amount, $this->stripe->client->currency()->precision, $this->stripe->client->currency()) + ); + + $message = [ + 'server_response' => $server_response, + 'data' => $this->stripe->payment_hash->data, + ]; + + SystemLogger::dispatch( + $message, + SystemLog::CATEGORY_GATEWAY_RESPONSE, + SystemLog::EVENT_GATEWAY_FAILURE, + SystemLog::TYPE_STRIPE, + $this->stripe->client, + $this->stripe->client->company, + ); + + throw new PaymentFailed('Failed to process the payment.', 500); + } +} diff --git a/public/js/clients/payments/stripe-ideal.js b/public/js/clients/payments/stripe-ideal.js new file mode 100644 index 000000000000..add121c25afe --- /dev/null +++ b/public/js/clients/payments/stripe-ideal.js @@ -0,0 +1 @@ +!function(e){var t={};function n(r){if(t[r])return t[r].exports;var o=t[r]={i:r,l:!1,exports:{}};return e[r].call(o.exports,o,o.exports,n),o.l=!0,o.exports}n.m=e,n.c=t,n.d=function(e,t,r){n.o(e,t)||Object.defineProperty(e,t,{enumerable:!0,get:r})},n.r=function(e){"undefined"!=typeof Symbol&&Symbol.toStringTag&&Object.defineProperty(e,Symbol.toStringTag,{value:"Module"}),Object.defineProperty(e,"__esModule",{value:!0})},n.t=function(e,t){if(1&t&&(e=n(e)),8&t)return e;if(4&t&&"object"==typeof e&&e&&e.__esModule)return e;var r=Object.create(null);if(n.r(r),Object.defineProperty(r,"default",{enumerable:!0,value:e}),2&t&&"string"!=typeof e)for(var o in e)n.d(r,o,function(t){return e[t]}.bind(null,o));return r},n.n=function(e){var t=e&&e.__esModule?function(){return e.default}:function(){return e};return n.d(t,"a",t),t},n.o=function(e,t){return Object.prototype.hasOwnProperty.call(e,t)},n.p="/",n(n.s=6)}({6:function(e,t,n){e.exports=n("RFiP")},RFiP:function(e,t){var n,r,o,i;function u(e,t,n){return t in e?Object.defineProperty(e,t,{value:n,enumerable:!0,configurable:!0,writable:!0}):e[t]=n,e}var c=null!==(n=null===(r=document.querySelector('meta[name="stripe-publishable-key"]'))||void 0===r?void 0:r.content)&&void 0!==n?n:"",l=null!==(o=null===(i=document.querySelector('meta[name="stripe-account-id"]'))||void 0===i?void 0:i.content)&&void 0!==o?o:"";new function e(t,n){var r=this;!function(e,t){if(!(e instanceof t))throw new TypeError("Cannot call a class as a function")}(this,e),u(this,"setupStripe",function(){return r.stripe=Stripe(r.key),r.stripeConnect&&(r.stripe.stripeAccount=l),r}),u(this,"handle",function(){document.getElementById("pay-now").addEventListener("click",function(e){let t=document.getElementById("errors");if(!document.getElementById("giropay-mandate-acceptance").checked)return t.textContent="Accept Terms",t.hidden=!1,void console.log("Terms");document.getElementById("pay-now").disabled=!0,document.querySelector("#pay-now > svg").classList.remove("hidden"),document.querySelector("#pay-now > span").classList.add("hidden"),r.stripe.confirmGiropayPayment(document.querySelector("meta[name=pi-client-secret").content,{payment_method:{billing_details:{name:document.getElementById("giropay-name").value}},return_url:document.querySelector('meta[name="return-url"]').content})})}),this.key=t,this.errors=document.getElementById("errors"),this.stripeConnect=n}(c,l).setupStripe().handle()}}); diff --git a/public/js/clients/payments/stripe-ideal.js.LICENSE.txt b/public/js/clients/payments/stripe-ideal.js.LICENSE.txt new file mode 100644 index 000000000000..585c6ab0e4fc --- /dev/null +++ b/public/js/clients/payments/stripe-ideal.js.LICENSE.txt @@ -0,0 +1,9 @@ +/** + * Invoice Ninja (https://invoiceninja.com) + * + * @link https://github.com/invoiceninja/invoiceninja source repository + * + * @copyright Copyright (c) 2021. Invoice Ninja LLC (https://invoiceninja.com) + * + * @license https://opensource.org/licenses/AAL + */ diff --git a/resources/js/clients/payments/stripe-ideal.js b/resources/js/clients/payments/stripe-ideal.js new file mode 100644 index 000000000000..bf751ef44610 --- /dev/null +++ b/resources/js/clients/payments/stripe-ideal.js @@ -0,0 +1,65 @@ +/** + * Invoice Ninja (https://invoiceninja.com) + * + * @link https://github.com/invoiceninja/invoiceninja source repository + * + * @copyright Copyright (c) 2021. Invoice Ninja LLC (https://invoiceninja.com) + * + * @license https://opensource.org/licenses/AAL + */ + +class ProcessGiroPay { + constructor(key, stripeConnect) { + this.key = key; + this.errors = document.getElementById('errors'); + this.stripeConnect = stripeConnect; + } + + setupStripe = () => { + this.stripe = Stripe(this.key); + + if(this.stripeConnect) + this.stripe.stripeAccount = stripeConnect; + + return this; + }; + + handle = () => { + document.getElementById('pay-now').addEventListener('click', (e) => { + let errors = document.getElementById('errors'); + + if (!document.getElementById('giropay-mandate-acceptance').checked) { + errors.textContent = "Accept Terms"; + errors.hidden = false; + console.log("Terms"); + return ; + } + document.getElementById('pay-now').disabled = true; + document.querySelector('#pay-now > svg').classList.remove('hidden'); + document.querySelector('#pay-now > span').classList.add('hidden'); + + this.stripe.confirmGiropayPayment( + document.querySelector('meta[name=pi-client-secret').content, + { + payment_method: { + billing_details: { + name: document.getElementById("giropay-name").value, + }, + }, + return_url: document.querySelector( + 'meta[name="return-url"]' + ).content, + } + ); + }); + }; +} + +const publishableKey = document.querySelector( + 'meta[name="stripe-publishable-key"]' +)?.content ?? ''; + +const stripeConnect = + document.querySelector('meta[name="stripe-account-id"]')?.content ?? ''; + +new ProcessGiroPay(publishableKey, stripeConnect).setupStripe().handle(); diff --git a/resources/views/portal/ninja2020/gateways/stripe/ideal/authorize.blade.php b/resources/views/portal/ninja2020/gateways/stripe/ideal/authorize.blade.php new file mode 100644 index 000000000000..ceb2d28000d5 --- /dev/null +++ b/resources/views/portal/ninja2020/gateways/stripe/ideal/authorize.blade.php @@ -0,0 +1,7 @@ +@extends('portal.ninja2020.layout.payments', ['gateway_title' => ctrans('texts.bank_account'), 'card_title' => ctrans('texts.bank_account')]) + +@section('gateway_content') + @component('portal.ninja2020.components.general.card-element-single', ['title' => ctrans('texts.bank_account'), 'show_title' => false]) + {{ __('texts.sofort_authorize_label') }} + @endcomponent +@endsection diff --git a/resources/views/portal/ninja2020/gateways/stripe/ideal/ideal.blade.php b/resources/views/portal/ninja2020/gateways/stripe/ideal/ideal.blade.php new file mode 100644 index 000000000000..05a4d5c9e8e3 --- /dev/null +++ b/resources/views/portal/ninja2020/gateways/stripe/ideal/ideal.blade.php @@ -0,0 +1,11 @@ +
+ @component('portal.ninja2020.components.general.card-element', ['title' => ctrans('texts.name')]) + +
+ + +
+ @endcomponent +
diff --git a/resources/views/portal/ninja2020/gateways/stripe/ideal/pay.blade.php b/resources/views/portal/ninja2020/gateways/stripe/ideal/pay.blade.php new file mode 100644 index 000000000000..faa0af1b58b9 --- /dev/null +++ b/resources/views/portal/ninja2020/gateways/stripe/ideal/pay.blade.php @@ -0,0 +1,28 @@ +@extends('portal.ninja2020.layout.payments', ['gateway_title' => 'GiroPay', 'card_title' => 'GiroPay']) + +@section('gateway_head') + + + + + + + +@endsection + +@section('gateway_content') + + + @include('portal.ninja2020.gateways.includes.payment_details') + + @component('portal.ninja2020.components.general.card-element', ['title' => ctrans('texts.payment_type')]) + {{ ctrans('texts.giropay') }} ({{ ctrans('texts.bank_transfer') }}) + @endcomponent + @include('portal.ninja2020.gateways.stripe.giropay.giropay') + @include('portal.ninja2020.gateways.includes.pay_now') +@endsection + +@push('footer') + + +@endpush From e85cff61a19cb56c0e1e86a630f63692615082de Mon Sep 17 00:00:00 2001 From: Lars Kusch Date: Sat, 9 Oct 2021 11:23:53 +0200 Subject: [PATCH 15/26] Merge branches --- app/PaymentDrivers/StripePaymentDriver.php | 10 +++++++++- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/app/PaymentDrivers/StripePaymentDriver.php b/app/PaymentDrivers/StripePaymentDriver.php index 604a4a89c5ba..66e9133a9801 100644 --- a/app/PaymentDrivers/StripePaymentDriver.php +++ b/app/PaymentDrivers/StripePaymentDriver.php @@ -33,6 +33,7 @@ use App\PaymentDrivers\Stripe\CreditCard; use App\PaymentDrivers\Stripe\ImportCustomers; use App\PaymentDrivers\Stripe\SOFORT; use App\PaymentDrivers\Stripe\SEPA; +use App\PaymentDrivers\Stripe\IDEAL; use App\PaymentDrivers\Stripe\UpdatePaymentMethods; use App\PaymentDrivers\Stripe\Utilities; use App\Utils\Traits\MakesHash; @@ -77,6 +78,7 @@ class StripePaymentDriver extends BaseDriver GatewayType::SOFORT => SOFORT::class, GatewayType::APPLE_PAY => ApplePay::class, GatewayType::SEPA => SEPA::class, + GatewayType::IDEAL => IDEAL::class, ]; const SYSTEM_LOG_TYPE = SystemLog::TYPE_STRIPE; @@ -153,6 +155,11 @@ class StripePaymentDriver extends BaseDriver $types[] = GatewayType::SEPA; } + if ($this -> client + && isset($this->client->country) + && in_array($this->client->country->iso_3166_3, ["DEU"])) // TODO: change to netherlands + $types[] = GatewayType::IDEAL; + return $types; } @@ -176,7 +183,8 @@ class StripePaymentDriver extends BaseDriver case GatewayType::APPLE_PAY: return 'gateways.stripe.other'; break; - + case GatewayType::IDEAL: + return 'gateways.stripe.ideal'; default: break; } From 92816c17144ea89f6684de5dc939d0d8b79d6b86 Mon Sep 17 00:00:00 2001 From: Lars Kusch Date: Sat, 9 Oct 2021 15:41:16 +0200 Subject: [PATCH 16/26] Changes for ideal --- app/PaymentDrivers/Stripe/iDeal.php | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/app/PaymentDrivers/Stripe/iDeal.php b/app/PaymentDrivers/Stripe/iDeal.php index ceb2b9f09ca8..01387127e34b 100644 --- a/app/PaymentDrivers/Stripe/iDeal.php +++ b/app/PaymentDrivers/Stripe/iDeal.php @@ -21,7 +21,7 @@ use App\Models\PaymentType; use App\Models\SystemLog; use App\PaymentDrivers\StripePaymentDriver; -class GIROPAY +class IDEAL { /** @var StripePaymentDriver */ public StripePaymentDriver $stripe; @@ -33,7 +33,7 @@ class GIROPAY public function authorizeView($data) { - return render('gateways.stripe.giropay.authorize', $data); + return render('gateways.stripe.ideal.authorize', $data); } public function paymentView(array $data) @@ -48,7 +48,7 @@ class GIROPAY $intent = \Stripe\PaymentIntent::create([ 'amount' => $data['stripe_amount'], 'currency' => 'eur', - 'payment_method_types' => ['giropay'], + 'payment_method_types' => ['ideal'], 'customer' => $this->stripe->findOrCreateCustomer(), 'description' => $this->stripe->decodeUnicodeString(ctrans('texts.invoices') . ': ' . collect($data['invoices'])->pluck('invoice_number')), @@ -59,7 +59,7 @@ class GIROPAY $this->stripe->payment_hash->data = array_merge((array) $this->stripe->payment_hash->data, ['stripe_amount' => $data['stripe_amount']]); $this->stripe->payment_hash->save(); - return render('gateways.stripe.giropay.pay', $data); + return render('gateways.stripe.ideal.pay', $data); } private function buildReturnUrl(): string @@ -67,7 +67,7 @@ class GIROPAY return route('client.payments.response', [ 'company_gateway_id' => $this->stripe->company_gateway->id, 'payment_hash' => $this->stripe->payment_hash->hash, - 'payment_method_id' => GatewayType::GIROPAY, + 'payment_method_id' => GatewayType::IDEAL, ]); } @@ -91,10 +91,10 @@ class GIROPAY $data = [ 'payment_method' => $payment_intent, - 'payment_type' => PaymentType::GIROPAY, + 'payment_type' => PaymentType::IDEAL, 'amount' => $this->stripe->convertFromStripeAmount($this->stripe->payment_hash->data->stripe_amount, $this->stripe->client->currency()->precision, $this->stripe->client->currency()), 'transaction_reference' => $payment_intent, - 'gateway_type_id' => GatewayType::GIROPAY, + 'gateway_type_id' => GatewayType::IDEAL, ]; $this->stripe->createPayment($data, Payment::STATUS_PENDING); From 3af5af74efde5558301cfc569cf9e714026e5c84 Mon Sep 17 00:00:00 2001 From: Lars Kusch Date: Sat, 9 Oct 2021 15:25:43 +0200 Subject: [PATCH 17/26] Adapt js files and views --- public/js/clients/payments/stripe-ideal.js | 2 +- resources/js/clients/payments/stripe-ideal.js | 31 ++++++++++++++----- .../gateways/stripe/ideal/ideal.blade.php | 8 ++--- .../gateways/stripe/ideal/pay.blade.php | 6 ++-- 4 files changed, 31 insertions(+), 16 deletions(-) diff --git a/public/js/clients/payments/stripe-ideal.js b/public/js/clients/payments/stripe-ideal.js index add121c25afe..a14fd623f615 100644 --- a/public/js/clients/payments/stripe-ideal.js +++ b/public/js/clients/payments/stripe-ideal.js @@ -1 +1 @@ -!function(e){var t={};function n(r){if(t[r])return t[r].exports;var o=t[r]={i:r,l:!1,exports:{}};return e[r].call(o.exports,o,o.exports,n),o.l=!0,o.exports}n.m=e,n.c=t,n.d=function(e,t,r){n.o(e,t)||Object.defineProperty(e,t,{enumerable:!0,get:r})},n.r=function(e){"undefined"!=typeof Symbol&&Symbol.toStringTag&&Object.defineProperty(e,Symbol.toStringTag,{value:"Module"}),Object.defineProperty(e,"__esModule",{value:!0})},n.t=function(e,t){if(1&t&&(e=n(e)),8&t)return e;if(4&t&&"object"==typeof e&&e&&e.__esModule)return e;var r=Object.create(null);if(n.r(r),Object.defineProperty(r,"default",{enumerable:!0,value:e}),2&t&&"string"!=typeof e)for(var o in e)n.d(r,o,function(t){return e[t]}.bind(null,o));return r},n.n=function(e){var t=e&&e.__esModule?function(){return e.default}:function(){return e};return n.d(t,"a",t),t},n.o=function(e,t){return Object.prototype.hasOwnProperty.call(e,t)},n.p="/",n(n.s=6)}({6:function(e,t,n){e.exports=n("RFiP")},RFiP:function(e,t){var n,r,o,i;function u(e,t,n){return t in e?Object.defineProperty(e,t,{value:n,enumerable:!0,configurable:!0,writable:!0}):e[t]=n,e}var c=null!==(n=null===(r=document.querySelector('meta[name="stripe-publishable-key"]'))||void 0===r?void 0:r.content)&&void 0!==n?n:"",l=null!==(o=null===(i=document.querySelector('meta[name="stripe-account-id"]'))||void 0===i?void 0:i.content)&&void 0!==o?o:"";new function e(t,n){var r=this;!function(e,t){if(!(e instanceof t))throw new TypeError("Cannot call a class as a function")}(this,e),u(this,"setupStripe",function(){return r.stripe=Stripe(r.key),r.stripeConnect&&(r.stripe.stripeAccount=l),r}),u(this,"handle",function(){document.getElementById("pay-now").addEventListener("click",function(e){let t=document.getElementById("errors");if(!document.getElementById("giropay-mandate-acceptance").checked)return t.textContent="Accept Terms",t.hidden=!1,void console.log("Terms");document.getElementById("pay-now").disabled=!0,document.querySelector("#pay-now > svg").classList.remove("hidden"),document.querySelector("#pay-now > span").classList.add("hidden"),r.stripe.confirmGiropayPayment(document.querySelector("meta[name=pi-client-secret").content,{payment_method:{billing_details:{name:document.getElementById("giropay-name").value}},return_url:document.querySelector('meta[name="return-url"]').content})})}),this.key=t,this.errors=document.getElementById("errors"),this.stripeConnect=n}(c,l).setupStripe().handle()}}); +!function(n){var r={};function o(e){if(r[e])return r[e].exports;var t=r[e]={i:e,l:!1,exports:{}};return n[e].call(t.exports,t,t.exports,o),t.l=!0,t.exports}o.m=n,o.c=r,o.d=function(e,t,n){o.o(e,t)||Object.defineProperty(e,t,{enumerable:!0,get:n})},o.r=function(e){"undefined"!=typeof Symbol&&Symbol.toStringTag&&Object.defineProperty(e,Symbol.toStringTag,{value:"Module"}),Object.defineProperty(e,"__esModule",{value:!0})},o.t=function(t,e){if(1&e&&(t=o(t)),8&e)return t;if(4&e&&"object"==typeof t&&t&&t.__esModule)return t;var n=Object.create(null);if(o.r(n),Object.defineProperty(n,"default",{enumerable:!0,value:t}),2&e&&"string"!=typeof t)for(var r in t)o.d(n,r,function(e){return t[e]}.bind(null,r));return n},o.n=function(e){var t=e&&e.__esModule?function(){return e.default}:function(){return e};return o.d(t,"a",t),t},o.o=function(e,t){return Object.prototype.hasOwnProperty.call(e,t)},o.p="/",o(o.s=6)}({6:function(e,t,n){e.exports=n("RFiP")},RFiP:function(e,t){var n;function o(e,t,n){return t in e?Object.defineProperty(e,t,{value:n,enumerable:!0,configurable:!0,writable:!0}):e[t]=n,e}var r=null!==(n=null===(r=document.querySelector('meta[name="stripe-publishable-key"]'))||void 0===r?void 0:r.content)&&void 0!==n?n:"",i=null!==(n=null===(n=document.querySelector('meta[name="stripe-account-id"]'))||void 0===n?void 0:n.content)&&void 0!==n?n:"";new function t(e,n){var r=this;!function(e){if(!(e instanceof t))throw new TypeError("Cannot call a class as a function")}(this),o(this,"setupStripe",function(){return r.stripe=Stripe(r.key),r.stripeConnect&&(r.stripe.stripeAccount=i),r}),o(this,"handle",function(){document.getElementById("pay-now").addEventListener("click",e=>{let t=document.getElementById("errors");if(""!==document.getElementById("ideal-name").value)return t.textContent="Enter name",t.hidden=!1,void console.log("name");document.getElementById("pay-now").disabled=!0,document.querySelector("#pay-now > svg").classList.remove("hidden"),document.querySelector("#pay-now > span").classList.add("hidden"),this.stripe.confirmIdealPayment(document.querySelector("meta[name=pi-client-secret").content,{payment_method:{ideal:this.ideal,billing_details:{name:document.getElementById("ideal-name").value}},return_url:document.querySelector('meta[name="return-url"]').content})})}),this.key=e,this.errors=document.getElementById("errors"),this.stripeConnect=n}(r,i).setupStripe().handle()}}); diff --git a/resources/js/clients/payments/stripe-ideal.js b/resources/js/clients/payments/stripe-ideal.js index bf751ef44610..275589796453 100644 --- a/resources/js/clients/payments/stripe-ideal.js +++ b/resources/js/clients/payments/stripe-ideal.js @@ -8,7 +8,7 @@ * @license https://opensource.org/licenses/AAL */ -class ProcessGiroPay { +class ProcessIDEALPay { constructor(key, stripeConnect) { this.key = key; this.errors = document.getElementById('errors'); @@ -20,7 +20,21 @@ class ProcessGiroPay { if(this.stripeConnect) this.stripe.stripeAccount = stripeConnect; - + let elements = this.stripe.elements(); + var options = { + style: { + base: { + padding: '10px 12px', + color: '#32325d', + fontSize: '16px', + '::placeholder': { + color: '#aab7c4' + }, + }, + }, + }; + this.ideal = elements.create('idealBank', options); + this.ideal.mount("#ideal-bank-element"); return this; }; @@ -28,22 +42,23 @@ class ProcessGiroPay { document.getElementById('pay-now').addEventListener('click', (e) => { let errors = document.getElementById('errors'); - if (!document.getElementById('giropay-mandate-acceptance').checked) { - errors.textContent = "Accept Terms"; + if (document.getElementById('ideal-name').value !== '') { + errors.textContent = "Enter name"; errors.hidden = false; - console.log("Terms"); + console.log("name"); return ; } document.getElementById('pay-now').disabled = true; document.querySelector('#pay-now > svg').classList.remove('hidden'); document.querySelector('#pay-now > span').classList.add('hidden'); - this.stripe.confirmGiropayPayment( + this.stripe.confirmIdealPayment( document.querySelector('meta[name=pi-client-secret').content, { payment_method: { + ideal: this.ideal, billing_details: { - name: document.getElementById("giropay-name").value, + name: document.getElementById("ideal-name").value, }, }, return_url: document.querySelector( @@ -62,4 +77,4 @@ const publishableKey = document.querySelector( const stripeConnect = document.querySelector('meta[name="stripe-account-id"]')?.content ?? ''; -new ProcessGiroPay(publishableKey, stripeConnect).setupStripe().handle(); +new ProcessIDEALPay(publishableKey, stripeConnect).setupStripe().handle(); diff --git a/resources/views/portal/ninja2020/gateways/stripe/ideal/ideal.blade.php b/resources/views/portal/ninja2020/gateways/stripe/ideal/ideal.blade.php index 05a4d5c9e8e3..49478a958326 100644 --- a/resources/views/portal/ninja2020/gateways/stripe/ideal/ideal.blade.php +++ b/resources/views/portal/ninja2020/gateways/stripe/ideal/ideal.blade.php @@ -1,11 +1,11 @@
@component('portal.ninja2020.components.general.card-element', ['title' => ctrans('texts.name')]) -
- - + +
+
@endcomponent
diff --git a/resources/views/portal/ninja2020/gateways/stripe/ideal/pay.blade.php b/resources/views/portal/ninja2020/gateways/stripe/ideal/pay.blade.php index faa0af1b58b9..ffe8c452167c 100644 --- a/resources/views/portal/ninja2020/gateways/stripe/ideal/pay.blade.php +++ b/resources/views/portal/ninja2020/gateways/stripe/ideal/pay.blade.php @@ -1,4 +1,4 @@ -@extends('portal.ninja2020.layout.payments', ['gateway_title' => 'GiroPay', 'card_title' => 'GiroPay']) +@extends('portal.ninja2020.layout.payments', ['gateway_title' => 'iDeal', 'card_title' => 'iDeal']) @section('gateway_head') @@ -18,11 +18,11 @@ @component('portal.ninja2020.components.general.card-element', ['title' => ctrans('texts.payment_type')]) {{ ctrans('texts.giropay') }} ({{ ctrans('texts.bank_transfer') }}) @endcomponent - @include('portal.ninja2020.gateways.stripe.giropay.giropay') + @include('portal.ninja2020.gateways.stripe.ideal.ideal') @include('portal.ninja2020.gateways.includes.pay_now') @endsection @push('footer') - + @endpush From 3d56db8885cba8165e494cfbda0397cae721bdb5 Mon Sep 17 00:00:00 2001 From: Lars Kusch Date: Sat, 9 Oct 2021 15:48:33 +0200 Subject: [PATCH 18/26] Added iDeal to Models --- app/Models/Gateway.php | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/app/Models/Gateway.php b/app/Models/Gateway.php index 8bd0b64eb09f..6918256eb4f1 100644 --- a/app/Models/Gateway.php +++ b/app/Models/Gateway.php @@ -104,7 +104,8 @@ class Gateway extends StaticModel GatewayType::ALIPAY => ['refund' => false, 'token_billing' => false], GatewayType::APPLE_PAY => ['refund' => false, 'token_billing' => false], GatewayType::SOFORT => ['refund' => true, 'token_billing' => true, 'webhooks' => ['source.chargeable', 'charge.succeeded']], //Stripe - GatewayType::SEPA => ['refund' => true, 'token_billing' => true, 'webhooks' => ['source.chargeable', 'charge.succeeded']]]; + GatewayType::SEPA => ['refund' => true, 'token_billing' => true, 'webhooks' => ['source.chargeable', 'charge.succeeded']], + GatewayType::IDEAL => ['refund' => true, 'token_billing' => true, 'webhooks' => ['source.chargeable', 'charge.succeeded']]]; case 39: return [GatewayType::CREDIT_CARD => ['refund' => true, 'token_billing' => true]]; //Checkout break; From 011cef7391da8fe237c91cbd321a22cddcbba561 Mon Sep 17 00:00:00 2001 From: Lars Kusch Date: Sat, 9 Oct 2021 16:11:29 +0200 Subject: [PATCH 19/26] small fixes --- app/PaymentDrivers/StripePaymentDriver.php | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/app/PaymentDrivers/StripePaymentDriver.php b/app/PaymentDrivers/StripePaymentDriver.php index 66e9133a9801..56420575f069 100644 --- a/app/PaymentDrivers/StripePaymentDriver.php +++ b/app/PaymentDrivers/StripePaymentDriver.php @@ -33,7 +33,7 @@ use App\PaymentDrivers\Stripe\CreditCard; use App\PaymentDrivers\Stripe\ImportCustomers; use App\PaymentDrivers\Stripe\SOFORT; use App\PaymentDrivers\Stripe\SEPA; -use App\PaymentDrivers\Stripe\IDEAL; +use App\PaymentDrivers\Stripe\iDEAL; use App\PaymentDrivers\Stripe\UpdatePaymentMethods; use App\PaymentDrivers\Stripe\Utilities; use App\Utils\Traits\MakesHash; @@ -78,7 +78,7 @@ class StripePaymentDriver extends BaseDriver GatewayType::SOFORT => SOFORT::class, GatewayType::APPLE_PAY => ApplePay::class, GatewayType::SEPA => SEPA::class, - GatewayType::IDEAL => IDEAL::class, + GatewayType::IDEAL => iDEAL::class, ]; const SYSTEM_LOG_TYPE = SystemLog::TYPE_STRIPE; From eb106f01fec913602447dfab0d1fe91b609e78eb Mon Sep 17 00:00:00 2001 From: Lars Kusch Date: Sat, 9 Oct 2021 16:13:04 +0200 Subject: [PATCH 20/26] small fixes --- app/PaymentDrivers/Stripe/iDeal.php | 2 +- app/PaymentDrivers/StripePaymentDriver.php | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/app/PaymentDrivers/Stripe/iDeal.php b/app/PaymentDrivers/Stripe/iDeal.php index 01387127e34b..35f10c5f6779 100644 --- a/app/PaymentDrivers/Stripe/iDeal.php +++ b/app/PaymentDrivers/Stripe/iDeal.php @@ -21,7 +21,7 @@ use App\Models\PaymentType; use App\Models\SystemLog; use App\PaymentDrivers\StripePaymentDriver; -class IDEAL +class iDeal { /** @var StripePaymentDriver */ public StripePaymentDriver $stripe; diff --git a/app/PaymentDrivers/StripePaymentDriver.php b/app/PaymentDrivers/StripePaymentDriver.php index 56420575f069..ad5056e03773 100644 --- a/app/PaymentDrivers/StripePaymentDriver.php +++ b/app/PaymentDrivers/StripePaymentDriver.php @@ -33,7 +33,7 @@ use App\PaymentDrivers\Stripe\CreditCard; use App\PaymentDrivers\Stripe\ImportCustomers; use App\PaymentDrivers\Stripe\SOFORT; use App\PaymentDrivers\Stripe\SEPA; -use App\PaymentDrivers\Stripe\iDEAL; +use App\PaymentDrivers\Stripe\iDeal; use App\PaymentDrivers\Stripe\UpdatePaymentMethods; use App\PaymentDrivers\Stripe\Utilities; use App\Utils\Traits\MakesHash; @@ -78,7 +78,7 @@ class StripePaymentDriver extends BaseDriver GatewayType::SOFORT => SOFORT::class, GatewayType::APPLE_PAY => ApplePay::class, GatewayType::SEPA => SEPA::class, - GatewayType::IDEAL => iDEAL::class, + GatewayType::IDEAL => iDeal::class, ]; const SYSTEM_LOG_TYPE = SystemLog::TYPE_STRIPE; From ca8ec101ce0b395d234a6ba4c65f6b27d16fa8ee Mon Sep 17 00:00:00 2001 From: Lars Kusch Date: Sat, 9 Oct 2021 16:29:23 +0200 Subject: [PATCH 21/26] Corrected js --- public/js/clients/payments/stripe-ideal.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/public/js/clients/payments/stripe-ideal.js b/public/js/clients/payments/stripe-ideal.js index a14fd623f615..61e654bbbdac 100644 --- a/public/js/clients/payments/stripe-ideal.js +++ b/public/js/clients/payments/stripe-ideal.js @@ -1 +1 @@ -!function(n){var r={};function o(e){if(r[e])return r[e].exports;var t=r[e]={i:e,l:!1,exports:{}};return n[e].call(t.exports,t,t.exports,o),t.l=!0,t.exports}o.m=n,o.c=r,o.d=function(e,t,n){o.o(e,t)||Object.defineProperty(e,t,{enumerable:!0,get:n})},o.r=function(e){"undefined"!=typeof Symbol&&Symbol.toStringTag&&Object.defineProperty(e,Symbol.toStringTag,{value:"Module"}),Object.defineProperty(e,"__esModule",{value:!0})},o.t=function(t,e){if(1&e&&(t=o(t)),8&e)return t;if(4&e&&"object"==typeof t&&t&&t.__esModule)return t;var n=Object.create(null);if(o.r(n),Object.defineProperty(n,"default",{enumerable:!0,value:t}),2&e&&"string"!=typeof t)for(var r in t)o.d(n,r,function(e){return t[e]}.bind(null,r));return n},o.n=function(e){var t=e&&e.__esModule?function(){return e.default}:function(){return e};return o.d(t,"a",t),t},o.o=function(e,t){return Object.prototype.hasOwnProperty.call(e,t)},o.p="/",o(o.s=6)}({6:function(e,t,n){e.exports=n("RFiP")},RFiP:function(e,t){var n;function o(e,t,n){return t in e?Object.defineProperty(e,t,{value:n,enumerable:!0,configurable:!0,writable:!0}):e[t]=n,e}var r=null!==(n=null===(r=document.querySelector('meta[name="stripe-publishable-key"]'))||void 0===r?void 0:r.content)&&void 0!==n?n:"",i=null!==(n=null===(n=document.querySelector('meta[name="stripe-account-id"]'))||void 0===n?void 0:n.content)&&void 0!==n?n:"";new function t(e,n){var r=this;!function(e){if(!(e instanceof t))throw new TypeError("Cannot call a class as a function")}(this),o(this,"setupStripe",function(){return r.stripe=Stripe(r.key),r.stripeConnect&&(r.stripe.stripeAccount=i),r}),o(this,"handle",function(){document.getElementById("pay-now").addEventListener("click",e=>{let t=document.getElementById("errors");if(""!==document.getElementById("ideal-name").value)return t.textContent="Enter name",t.hidden=!1,void console.log("name");document.getElementById("pay-now").disabled=!0,document.querySelector("#pay-now > svg").classList.remove("hidden"),document.querySelector("#pay-now > span").classList.add("hidden"),this.stripe.confirmIdealPayment(document.querySelector("meta[name=pi-client-secret").content,{payment_method:{ideal:this.ideal,billing_details:{name:document.getElementById("ideal-name").value}},return_url:document.querySelector('meta[name="return-url"]').content})})}),this.key=e,this.errors=document.getElementById("errors"),this.stripeConnect=n}(r,i).setupStripe().handle()}}); +!function(n){var r={};function o(e){if(r[e])return r[e].exports;var t=r[e]={i:e,l:!1,exports:{}};return n[e].call(t.exports,t,t.exports,o),t.l=!0,t.exports}o.m=n,o.c=r,o.d=function(e,t,n){o.o(e,t)||Object.defineProperty(e,t,{enumerable:!0,get:n})},o.r=function(e){"undefined"!=typeof Symbol&&Symbol.toStringTag&&Object.defineProperty(e,Symbol.toStringTag,{value:"Module"}),Object.defineProperty(e,"__esModule",{value:!0})},o.t=function(t,e){if(1&e&&(t=o(t)),8&e)return t;if(4&e&&"object"==typeof t&&t&&t.__esModule)return t;var n=Object.create(null);if(o.r(n),Object.defineProperty(n,"default",{enumerable:!0,value:t}),2&e&&"string"!=typeof t)for(var r in t)o.d(n,r,function(e){return t[e]}.bind(null,r));return n},o.n=function(e){var t=e&&e.__esModule?function(){return e.default}:function(){return e};return o.d(t,"a",t),t},o.o=function(e,t){return Object.prototype.hasOwnProperty.call(e,t)},o.p="/",o(o.s=6)}({6:function(e,t,n){e.exports=n("RFiP")},RFiP:function(e,t){var n;function o(e,t,n){return t in e?Object.defineProperty(e,t,{value:n,enumerable:!0,configurable:!0,writable:!0}):e[t]=n,e}var r=null!==(n=null===(r=document.querySelector('meta[name="stripe-publishable-key"]'))||void 0===r?void 0:r.content)&&void 0!==n?n:"",i=null!==(n=null===(n=document.querySelector('meta[name="stripe-account-id"]'))||void 0===n?void 0:n.content)&&void 0!==n?n:"";new function t(e,n){var r=this;!function(e){if(!(e instanceof t))throw new TypeError("Cannot call a class as a function")}(this),o(this,"setupStripe",function(){r.stripe=Stripe(r.key),r.stripeConnect&&(r.stripe.stripeAccount=i);let e=r.stripe.elements();return this.ideal=e.create("idealBank",{style:{base:{padding:"10px 12px",color:"#32325d",fontSize:"16px","::placeholder":{color:"#aab7c4"}}}}),this.ideal.mount("#ideal-bank-element"),r}),o(this,"handle",function(){document.getElementById("pay-now").addEventListener("click",e=>{let t=document.getElementById("errors");if(""!==document.getElementById("ideal-name").value)return t.textContent="Enter name",t.hidden=!1,void console.log("name");document.getElementById("pay-now").disabled=!0,document.querySelector("#pay-now > svg").classList.remove("hidden"),document.querySelector("#pay-now > span").classList.add("hidden"),this.stripe.confirmIdealPayment(document.querySelector("meta[name=pi-client-secret").content,{payment_method:{ideal:this.ideal,billing_details:{name:document.getElementById("ideal-name").value}},return_url:document.querySelector('meta[name="return-url"]').content})})}),this.key=e,this.errors=document.getElementById("errors"),this.stripeConnect=n}(r,i).setupStripe().handle()}}); From 7899f5c33ad9b0d1fccf14211296b5dfcdfe275a Mon Sep 17 00:00:00 2001 From: Lars Kusch Date: Sat, 9 Oct 2021 16:30:39 +0200 Subject: [PATCH 22/26] Small text fixes --- .../views/portal/ninja2020/gateways/stripe/ideal/pay.blade.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/resources/views/portal/ninja2020/gateways/stripe/ideal/pay.blade.php b/resources/views/portal/ninja2020/gateways/stripe/ideal/pay.blade.php index ffe8c452167c..9456751ed904 100644 --- a/resources/views/portal/ninja2020/gateways/stripe/ideal/pay.blade.php +++ b/resources/views/portal/ninja2020/gateways/stripe/ideal/pay.blade.php @@ -16,7 +16,7 @@ @include('portal.ninja2020.gateways.includes.payment_details') @component('portal.ninja2020.components.general.card-element', ['title' => ctrans('texts.payment_type')]) - {{ ctrans('texts.giropay') }} ({{ ctrans('texts.bank_transfer') }}) + {{ ctrans('texts.ideal') }} ({{ ctrans('texts.bank_transfer') }}) @endcomponent @include('portal.ninja2020.gateways.stripe.ideal.ideal') @include('portal.ninja2020.gateways.includes.pay_now') From e5777c230529390f4c3886d39d0df7100de83f47 Mon Sep 17 00:00:00 2001 From: Lars Kusch Date: Sat, 9 Oct 2021 16:34:48 +0200 Subject: [PATCH 23/26] Small fixes --- public/js/clients/payments/stripe-ideal.js | 2 +- resources/js/clients/payments/stripe-ideal.js | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/public/js/clients/payments/stripe-ideal.js b/public/js/clients/payments/stripe-ideal.js index 61e654bbbdac..5c8ddc3e22d3 100644 --- a/public/js/clients/payments/stripe-ideal.js +++ b/public/js/clients/payments/stripe-ideal.js @@ -1 +1 @@ -!function(n){var r={};function o(e){if(r[e])return r[e].exports;var t=r[e]={i:e,l:!1,exports:{}};return n[e].call(t.exports,t,t.exports,o),t.l=!0,t.exports}o.m=n,o.c=r,o.d=function(e,t,n){o.o(e,t)||Object.defineProperty(e,t,{enumerable:!0,get:n})},o.r=function(e){"undefined"!=typeof Symbol&&Symbol.toStringTag&&Object.defineProperty(e,Symbol.toStringTag,{value:"Module"}),Object.defineProperty(e,"__esModule",{value:!0})},o.t=function(t,e){if(1&e&&(t=o(t)),8&e)return t;if(4&e&&"object"==typeof t&&t&&t.__esModule)return t;var n=Object.create(null);if(o.r(n),Object.defineProperty(n,"default",{enumerable:!0,value:t}),2&e&&"string"!=typeof t)for(var r in t)o.d(n,r,function(e){return t[e]}.bind(null,r));return n},o.n=function(e){var t=e&&e.__esModule?function(){return e.default}:function(){return e};return o.d(t,"a",t),t},o.o=function(e,t){return Object.prototype.hasOwnProperty.call(e,t)},o.p="/",o(o.s=6)}({6:function(e,t,n){e.exports=n("RFiP")},RFiP:function(e,t){var n;function o(e,t,n){return t in e?Object.defineProperty(e,t,{value:n,enumerable:!0,configurable:!0,writable:!0}):e[t]=n,e}var r=null!==(n=null===(r=document.querySelector('meta[name="stripe-publishable-key"]'))||void 0===r?void 0:r.content)&&void 0!==n?n:"",i=null!==(n=null===(n=document.querySelector('meta[name="stripe-account-id"]'))||void 0===n?void 0:n.content)&&void 0!==n?n:"";new function t(e,n){var r=this;!function(e){if(!(e instanceof t))throw new TypeError("Cannot call a class as a function")}(this),o(this,"setupStripe",function(){r.stripe=Stripe(r.key),r.stripeConnect&&(r.stripe.stripeAccount=i);let e=r.stripe.elements();return this.ideal=e.create("idealBank",{style:{base:{padding:"10px 12px",color:"#32325d",fontSize:"16px","::placeholder":{color:"#aab7c4"}}}}),this.ideal.mount("#ideal-bank-element"),r}),o(this,"handle",function(){document.getElementById("pay-now").addEventListener("click",e=>{let t=document.getElementById("errors");if(""!==document.getElementById("ideal-name").value)return t.textContent="Enter name",t.hidden=!1,void console.log("name");document.getElementById("pay-now").disabled=!0,document.querySelector("#pay-now > svg").classList.remove("hidden"),document.querySelector("#pay-now > span").classList.add("hidden"),this.stripe.confirmIdealPayment(document.querySelector("meta[name=pi-client-secret").content,{payment_method:{ideal:this.ideal,billing_details:{name:document.getElementById("ideal-name").value}},return_url:document.querySelector('meta[name="return-url"]').content})})}),this.key=e,this.errors=document.getElementById("errors"),this.stripeConnect=n}(r,i).setupStripe().handle()}}); +!function(n){var r={};function o(e){if(r[e])return r[e].exports;var t=r[e]={i:e,l:!1,exports:{}};return n[e].call(t.exports,t,t.exports,o),t.l=!0,t.exports}o.m=n,o.c=r,o.d=function(e,t,n){o.o(e,t)||Object.defineProperty(e,t,{enumerable:!0,get:n})},o.r=function(e){"undefined"!=typeof Symbol&&Symbol.toStringTag&&Object.defineProperty(e,Symbol.toStringTag,{value:"Module"}),Object.defineProperty(e,"__esModule",{value:!0})},o.t=function(t,e){if(1&e&&(t=o(t)),8&e)return t;if(4&e&&"object"==typeof t&&t&&t.__esModule)return t;var n=Object.create(null);if(o.r(n),Object.defineProperty(n,"default",{enumerable:!0,value:t}),2&e&&"string"!=typeof t)for(var r in t)o.d(n,r,function(e){return t[e]}.bind(null,r));return n},o.n=function(e){var t=e&&e.__esModule?function(){return e.default}:function(){return e};return o.d(t,"a",t),t},o.o=function(e,t){return Object.prototype.hasOwnProperty.call(e,t)},o.p="/",o(o.s=6)}({6:function(e,t,n){e.exports=n("RFiP")},RFiP:function(e,t){var n;function o(e,t,n){return t in e?Object.defineProperty(e,t,{value:n,enumerable:!0,configurable:!0,writable:!0}):e[t]=n,e}var r=null!==(n=null===(r=document.querySelector('meta[name="stripe-publishable-key"]'))||void 0===r?void 0:r.content)&&void 0!==n?n:"",i=null!==(n=null===(n=document.querySelector('meta[name="stripe-account-id"]'))||void 0===n?void 0:n.content)&&void 0!==n?n:"";new function t(e,n){var r=this;!function(e){if(!(e instanceof t))throw new TypeError("Cannot call a class as a function")}(this),o(this,"setupStripe",function(){r.stripe=Stripe(r.key),r.stripeConnect&&(r.stripe.stripeAccount=i);let e=r.stripe.elements();return this.ideal=e.create("idealBank",{style:{base:{padding:"10px 12px",color:"#32325d",fontSize:"16px","::placeholder":{color:"#aab7c4"}}}}),this.ideal.mount("#ideal-bank-element"),r}),o(this,"handle",function(){document.getElementById("pay-now").addEventListener("click",e=>{let t=document.getElementById("errors");if(!document.getElementById("ideal-name").value)return t.textContent="Enter name",t.hidden=!1,void console.log("name");document.getElementById("pay-now").disabled=!0,document.querySelector("#pay-now > svg").classList.remove("hidden"),document.querySelector("#pay-now > span").classList.add("hidden"),this.stripe.confirmIdealPayment(document.querySelector("meta[name=pi-client-secret").content,{payment_method:{ideal:this.ideal,billing_details:{name:document.getElementById("ideal-name").value}},return_url:document.querySelector('meta[name="return-url"]').content})})}),this.key=e,this.errors=document.getElementById("errors"),this.stripeConnect=n}(r,i).setupStripe().handle()}}); diff --git a/resources/js/clients/payments/stripe-ideal.js b/resources/js/clients/payments/stripe-ideal.js index 275589796453..97722d001927 100644 --- a/resources/js/clients/payments/stripe-ideal.js +++ b/resources/js/clients/payments/stripe-ideal.js @@ -42,7 +42,7 @@ class ProcessIDEALPay { document.getElementById('pay-now').addEventListener('click', (e) => { let errors = document.getElementById('errors'); - if (document.getElementById('ideal-name').value !== '') { + if (!document.getElementById('ideal-name').value) { errors.textContent = "Enter name"; errors.hidden = false; console.log("name"); From 45d9127d26d58e93d8c286ac0e21f638c9b85812 Mon Sep 17 00:00:00 2001 From: Lars Kusch Date: Sat, 9 Oct 2021 17:40:14 +0200 Subject: [PATCH 24/26] Changed country code --- app/PaymentDrivers/StripePaymentDriver.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/app/PaymentDrivers/StripePaymentDriver.php b/app/PaymentDrivers/StripePaymentDriver.php index ad5056e03773..8e026d291d57 100644 --- a/app/PaymentDrivers/StripePaymentDriver.php +++ b/app/PaymentDrivers/StripePaymentDriver.php @@ -157,7 +157,7 @@ class StripePaymentDriver extends BaseDriver if ($this -> client && isset($this->client->country) - && in_array($this->client->country->iso_3166_3, ["DEU"])) // TODO: change to netherlands + && in_array($this->client->country->iso_3166_3, ["NLD"])) $types[] = GatewayType::IDEAL; return $types; From beb503758e6d11fe759ca4fe1a0cec1a649120a2 Mon Sep 17 00:00:00 2001 From: David Bomba Date: Sun, 10 Oct 2021 08:39:50 +1100 Subject: [PATCH 25/26] Minor fixes for iDeal payments with Stripe --- app/PaymentDrivers/StripePaymentDriver.php | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/app/PaymentDrivers/StripePaymentDriver.php b/app/PaymentDrivers/StripePaymentDriver.php index d6416d0d6222..0ffcf502d569 100644 --- a/app/PaymentDrivers/StripePaymentDriver.php +++ b/app/PaymentDrivers/StripePaymentDriver.php @@ -150,12 +150,16 @@ class StripePaymentDriver extends BaseDriver } if ($this->client + && $this->client->currency() + && ($this->client->currency()->code == 'EUR') && isset($this->client->country) && in_array($this->client->country->iso_3166_3, ['AUS', 'DNK', 'DEU', 'ITA', 'LUX', 'NOR', 'SVN', 'GBR', 'EST', 'GRC', 'JPN', 'PRT', 'ESP', 'USA', 'BEL', 'FIN'])) { // TODO: More has to be added https://stripe.com/docs/payments/sepa-debit $types[] = GatewayType::SEPA; } - if ($this -> client + if ($this->client + && $this->client->currency() + && ($this->client->currency()->code == 'EUR') && isset($this->client->country) && in_array($this->client->country->iso_3166_3, ["NLD"])) $types[] = GatewayType::IDEAL; From fc8d56ad0edf7971e63186e7dd036c96a307bd71 Mon Sep 17 00:00:00 2001 From: David Bomba Date: Sun, 10 Oct 2021 09:37:42 +1100 Subject: [PATCH 26/26] Minor fixes for GiroPay --- app/Console/Commands/CreateSingleAccount.php | 14 +++++++------- app/Models/Gateway.php | 2 +- app/PaymentDrivers/StripePaymentDriver.php | 2 ++ 3 files changed, 10 insertions(+), 8 deletions(-) diff --git a/app/Console/Commands/CreateSingleAccount.php b/app/Console/Commands/CreateSingleAccount.php index 364209f3432e..92d1bacf3662 100644 --- a/app/Console/Commands/CreateSingleAccount.php +++ b/app/Console/Commands/CreateSingleAccount.php @@ -630,7 +630,7 @@ class CreateSingleAccount extends Command $cg->config = encrypt(config('ninja.testvars.stripe')); $cg->save(); - $gateway_types = $cg->driver(new Client)->gatewayTypes(); + $gateway_types = $cg->driver()->gatewayTypes(); $fees_and_limits = new stdClass; $fees_and_limits->{$gateway_types[0]} = new FeesAndLimits; @@ -653,7 +653,7 @@ class CreateSingleAccount extends Command $cg->config = encrypt(config('ninja.testvars.paypal')); $cg->save(); - $gateway_types = $cg->driver(new Client)->gatewayTypes(); + $gateway_types = $cg->driver()->gatewayTypes(); $fees_and_limits = new stdClass; $fees_and_limits->{$gateway_types[0]} = new FeesAndLimits; @@ -716,7 +716,7 @@ class CreateSingleAccount extends Command $cg->config = encrypt(config('ninja.testvars.wepay')); $cg->save(); - $gateway_types = $cg->driver(new Client)->gatewayTypes(); + $gateway_types = $cg->driver()->gatewayTypes(); $fees_and_limits = new stdClass; $fees_and_limits->{$gateway_types[0]} = new FeesAndLimits; @@ -737,7 +737,7 @@ class CreateSingleAccount extends Command $cg->config = encrypt(config('ninja.testvars.braintree')); $cg->save(); - $gateway_types = $cg->driver(new Client)->gatewayTypes(); + $gateway_types = $cg->driver()->gatewayTypes(); $fees_and_limits = new stdClass; $fees_and_limits->{$gateway_types[0]} = new FeesAndLimits; @@ -761,7 +761,7 @@ class CreateSingleAccount extends Command $cg->save(); - $gateway_types = $cg->driver(new Client)->gatewayTypes(); + $gateway_types = $cg->driver()->gatewayTypes(); $fees_and_limits = new stdClass; $fees_and_limits->{$gateway_types[0]} = new FeesAndLimits; @@ -782,7 +782,7 @@ class CreateSingleAccount extends Command $cg->config = encrypt(config('ninja.testvars.mollie')); $cg->save(); - $gateway_types = $cg->driver(new Client)->gatewayTypes(); + $gateway_types = $cg->driver()->gatewayTypes(); $fees_and_limits = new stdClass; $fees_and_limits->{$gateway_types[0]} = new FeesAndLimits; @@ -803,7 +803,7 @@ class CreateSingleAccount extends Command $cg->config = encrypt(config('ninja.testvars.square')); $cg->save(); - $gateway_types = $cg->driver(new Client)->gatewayTypes(); + $gateway_types = $cg->driver()->gatewayTypes(); $fees_and_limits = new stdClass; $fees_and_limits->{$gateway_types[0]} = new FeesAndLimits; diff --git a/app/Models/Gateway.php b/app/Models/Gateway.php index c4260669a963..abb0d2c50ac0 100644 --- a/app/Models/Gateway.php +++ b/app/Models/Gateway.php @@ -105,7 +105,7 @@ class Gateway extends StaticModel GatewayType::APPLE_PAY => ['refund' => false, 'token_billing' => false], GatewayType::SOFORT => ['refund' => true, 'token_billing' => true, 'webhooks' => ['source.chargeable', 'charge.succeeded']], //Stripe GatewayType::SEPA => ['refund' => true, 'token_billing' => true, 'webhooks' => ['source.chargeable', 'charge.succeeded']], - GatewayType::GIROPAY => ['refund' => true, 'token_billing' => true, 'webhooks' => ['source.chargeable', 'charge.succeeded']]]; + GatewayType::GIROPAY => ['refund' => true, 'token_billing' => true, 'webhooks' => ['source.chargeable', 'charge.succeeded']], GatewayType::IDEAL => ['refund' => true, 'token_billing' => true, 'webhooks' => ['source.chargeable', 'charge.succeeded']]]; case 39: diff --git a/app/PaymentDrivers/StripePaymentDriver.php b/app/PaymentDrivers/StripePaymentDriver.php index 8d7a8a112ea6..cac69474a1ac 100644 --- a/app/PaymentDrivers/StripePaymentDriver.php +++ b/app/PaymentDrivers/StripePaymentDriver.php @@ -161,6 +161,8 @@ class StripePaymentDriver extends BaseDriver } if ($this->client + && $this->client->currency() + && ($this->client->currency()->code == 'EUR') && isset($this->client->country) && in_array($this->client->country->iso_3166_3, ["DEU"])) $types[] = GatewayType::GIROPAY;