From dab7f5afba0a6f241b6f5424aeb44c068345ef0d Mon Sep 17 00:00:00 2001
From: David Bomba <turbo124@gmail.com>
Date: Fri, 30 Apr 2021 14:22:36 +1000
Subject: [PATCH] explicitly define the unwritable file

---
 app/Http/Controllers/SelfUpdateController.php | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/app/Http/Controllers/SelfUpdateController.php b/app/Http/Controllers/SelfUpdateController.php
index 70e3e03698a9..9141327a4530 100644
--- a/app/Http/Controllers/SelfUpdateController.php
+++ b/app/Http/Controllers/SelfUpdateController.php
@@ -62,8 +62,7 @@ class SelfUpdateController extends BaseController
             return response()->json(['message' => ctrans('texts.self_update_not_available')], 403);
         }
 
-        if(!$this->testWritable())
-            throw new FilePermissionsFailure('Cannot update system because files are not writable!');
+        $this->testWritable();
 
         // Check if new version is available
         //if($updater->source()->isNewVersionAvailable()) {
@@ -105,7 +104,8 @@ class SelfUpdateController extends BaseController
             // nlog($file->getPathname());
 
             if ($file->isFile() && ! $file->isWritable()) {
-                throw new FilePermissionsFailure($file);
+                // throw new FilePermissionsFailure($file);
+                throw new FilePermissionsFailure("Cannot update system because {$file->getFileName()} is not writable");
                 return false;
             }
         }