Cutlery/invoiceninja
1
0
Fork 0
mirror of https://github.com/invoiceninja/invoiceninja.git synced 2025-07-08 05:54:29 -04:00
Code Issues Packages Projects Releases Wiki Activity

Improve refunding from subscription upgrades

Browse Source
This commit is contained in:
David Bomba 2022-02-28 14:44:06 +11:00
parent 32596b4287
commit de8ee988b7
1 changed files with 6 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
app/Services/Subscription/SubscriptionService.php
View File

@ -228,10 +228,14 @@ class SubscriptionService
->where('is_deleted', 0) ->where('is_deleted', 0)
->orderBy('id', 'desc') ->orderBy('id', 'desc')
->first(); ->first();
} }
if ($outstanding->count() == 0){ //need to ensure at this point that a refund is appropriate!!
//28-02-2022
if($recurring_invoice->invoices()->count() == 0){
return $target->price;
}
elseif ($outstanding->count() == 0){
//nothing outstanding //nothing outstanding
return $target->price - $this->calculateProRataRefundForSubscription($outstanding_invoice); return $target->price - $this->calculateProRataRefundForSubscription($outstanding_invoice);
} }