Cleanup for emails

app/Http/Controllers/EmailController.php

@@ -128,7 +128,11 @@ class EmailController extends BaseController
                     'body' => $body
                 ];
                 
-                EmailEntity::dispatchNow($invitation, $invitation->company, $template, $data);
+                $entity_obj->service()->markSent()->save();
+
+                //@TODO why is this dispatchNow instead of just dispatch?
+                //update - changing to dispatch and see if something breaks.
+                EmailEntity::dispatch($invitation, $invitation->company, $template, $data);
             }
         });
 

app/Jobs/Entity/CreateEntityPdf.php

@@ -108,7 +108,6 @@ class CreateEntityPdf implements ShouldQueue
             $entity_design_id = 'credit_design_id';
         }
 
-
         $file_path = $path.$this->entity->number.'.pdf';
 
         $entity_design_id = $this->entity->design_id ? $this->entity->design_id : $this->decodePrimaryKey($this->entity->client->getSetting($entity_design_id));
@@ -145,10 +144,6 @@ class CreateEntityPdf implements ShouldQueue
             ->design($template)
             ->build();
 
-        //todo - move this to the client creation stage so we don't keep hitting this unnecessarily
-        //nlog("make dir => {$path}");
-        //Storage::makeDirectory($path, 0775);
-
         $pdf = null;
 
         try {

app/Jobs/Entity/EmailEntity.php

@@ -110,15 +110,11 @@ class EmailEntity extends BaseMailerJob implements ShouldQueue
                     )
                 );
         } catch (\Exception $e) {
-//            $this->failed($e);
+
             $this->entityEmailFailed($e->getMessage());
             $this->logMailError($e->getMessage(), $this->entity->client);
         }
 
-        // if (count(Mail::failures()) == 0) {
-        //     $this->entityEmailSucceeded();
-        // }
-
         /* Mark entity sent */
         $this->entity->service()->markSent()->save();
     }

app/Services/Invoice/GetInvoicePdf.php

@@ -15,6 +15,7 @@ use App\Jobs\Entity\CreateEntityPdf;
 use App\Models\ClientContact;
 use App\Models\Invoice;
 use App\Services\AbstractService;
+use App\Utils\TempFile;
 use Illuminate\Support\Facades\Storage;
 
 class GetInvoicePdf extends AbstractService
@@ -46,6 +47,10 @@ class GetInvoicePdf extends AbstractService
             $file_path = CreateEntityPdf::dispatchNow($invitation);
         }
 
-        return Storage::disk($disk)->path($file_path);
+
+        return TempFile::path(Storage::disk($disk)->url($file_path));
+
+        // return Storage::disk($disk)->url($file_path);
+        // return Storage::disk($disk)->path($file_path);
     }
 }

app/Utils/TempFile.php

@@ -15,7 +15,7 @@ class TempFile
 {
     public static function path($url) :string
     {
-        $temp_path = tempnam(sys_get_temp_dir(), basename($url));
+        $temp_path = @tempnam(sys_get_temp_dir() . '/' . sha1(time()), basename($url));
         copy($url, $temp_path);
 
         return $temp_path;