Cutlery/invoiceninja
1
0
Fork 0
mirror of https://github.com/invoiceninja/invoiceninja.git synced 2025-06-23 20:00:33 -04:00
Code Issues Packages Projects Releases Wiki Activity

Return early from try block

Browse Source
This commit is contained in:
David Bomba 2021-05-10 14:11:26 +10:00
parent a272956df2
commit e63b3cb76a
1 changed files with 13 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

22
app/Http/Controllers/Migration/StepsController.php
View File

@ -176,18 +176,22 @@ class StepsController extends BaseController
); );
} }
$migrationData = $this->generateMigrationData($request->all()); try {
$migrationData = $this->generateMigrationData($request->all());
$completeService = (new CompleteService(session('MIGRATION_ACCOUNT_TOKEN'))) $completeService = (new CompleteService(session('MIGRATION_ACCOUNT_TOKEN')))
->data($migrationData) ->data($migrationData)
->endpoint(session('MIGRATION_ENDPOINT')) ->endpoint(session('MIGRATION_ENDPOINT'))
->start(); ->start();
if ($completeService->isSuccessful()) {
return view('migration.completed');
} }
finally {
if ($completeService->isSuccessful()) {
return view('migration.completed');
}
return view('migration.completed', ['customMessage' => $completeService->getErrors()[0]]); return view('migration.completed', ['customMessage' => $completeService->getErrors()[0]]);
}
} }
public function completed() public function completed()