From 36f5b2e11ec80562b4d8b68637fbfa7901c0fd98 Mon Sep 17 00:00:00 2001 From: David Bomba Date: Sun, 15 Oct 2023 17:21:56 +1100 Subject: [PATCH] Minor fixes for paytrace --- app/Helpers/Bank/Yodlee/Transformer/AccountTransformer.php | 2 +- app/PaymentDrivers/PayTrace/CreditCard.php | 2 +- app/PaymentDrivers/PaytracePaymentDriver.php | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/app/Helpers/Bank/Yodlee/Transformer/AccountTransformer.php b/app/Helpers/Bank/Yodlee/Transformer/AccountTransformer.php index 19ff1974c64d..ceb1417c7530 100644 --- a/app/Helpers/Bank/Yodlee/Transformer/AccountTransformer.php +++ b/app/Helpers/Bank/Yodlee/Transformer/AccountTransformer.php @@ -140,7 +140,7 @@ class AccountTransformer implements AccountTransformerInterface 'id' => $account->id, 'account_type' => $account->CONTAINER, // 'account_name' => $account->accountName, - 'account_name' => property_exists($account, 'accountName') ? $account->accountName : $account->nickname, + 'account_name' => property_exists($account, 'accountName') ? $account->accountName : ($account->nickname ?? 'Unknown Account'), 'account_status' => $account_status, 'account_number' => property_exists($account, 'accountNumber') ? '**** ' . substr($account?->accountNumber, -7) : '', 'provider_account_id' => $account->providerAccountId, diff --git a/app/PaymentDrivers/PayTrace/CreditCard.php b/app/PaymentDrivers/PayTrace/CreditCard.php index 720d5f0b02be..350fc6948b87 100644 --- a/app/PaymentDrivers/PayTrace/CreditCard.php +++ b/app/PaymentDrivers/PayTrace/CreditCard.php @@ -183,7 +183,7 @@ class CreditCard $response = $this->paytrace->gatewayRequest('/v1/transactions/sale/by_customer', $data); - if ($response->success) { + if ($response->success ?? false) { $this->paytrace->logSuccessfulGatewayResponse(['response' => $response, 'data' => $this->paytrace->payment_hash], SystemLog::TYPE_PAYTRACE); return $this->processSuccessfulPayment($response); diff --git a/app/PaymentDrivers/PaytracePaymentDriver.php b/app/PaymentDrivers/PaytracePaymentDriver.php index 5f33ea843e3a..b55e8857c169 100644 --- a/app/PaymentDrivers/PaytracePaymentDriver.php +++ b/app/PaymentDrivers/PaytracePaymentDriver.php @@ -198,7 +198,7 @@ class PaytracePaymentDriver extends BaseDriver $auth_data = json_decode($response); - if (! property_exists($auth_data, 'access_token')) { + if (!isset($auth_data) || ! property_exists($auth_data, 'access_token')) { throw new SystemError('Error authenticating with PayTrace'); }