From f0bf26ad146db29479ea5184e8c35ad953368117 Mon Sep 17 00:00:00 2001 From: David Bomba Date: Tue, 12 Jan 2021 20:35:47 +1100 Subject: [PATCH] Fixes for system logging successful gateway responses" --- app/PaymentDrivers/Authorize/AuthorizeCreditCard.php | 12 ++++++------ app/Services/Invoice/GetInvoicePdf.php | 2 ++ 2 files changed, 8 insertions(+), 6 deletions(-) diff --git a/app/PaymentDrivers/Authorize/AuthorizeCreditCard.php b/app/PaymentDrivers/Authorize/AuthorizeCreditCard.php index 4d431fc3df97..8b3bb046f4dd 100644 --- a/app/PaymentDrivers/Authorize/AuthorizeCreditCard.php +++ b/app/PaymentDrivers/Authorize/AuthorizeCreditCard.php @@ -140,11 +140,6 @@ class AuthorizeCreditCard } - - - - - private function handleResponse($data, $request) { $response = $data['response']; @@ -205,7 +200,12 @@ class AuthorizeCreditCard 'data' => $this->formatGatewayResponse($data, $vars), ]; - SystemLogger::dispatch($logger_message, SystemLog::CATEGORY_GATEWAY_RESPONSE, SystemLog::EVENT_GATEWAY_SUCCESS, SystemLog::TYPE_AUTHORIZE, $this->authorize->client); + SystemLogger::dispatch( + $logger_message, + SystemLog::CATEGORY_GATEWAY_RESPONSE, + SystemLog::EVENT_GATEWAY_SUCCESS, + SystemLog::TYPE_AUTHORIZE, + $this->authorize->client); return redirect()->route('client.payments.show', ['payment' => $this->encodePrimaryKey($payment->id)]); } diff --git a/app/Services/Invoice/GetInvoicePdf.php b/app/Services/Invoice/GetInvoicePdf.php index 0b7abf1cc7e9..4fe48bbaad22 100644 --- a/app/Services/Invoice/GetInvoicePdf.php +++ b/app/Services/Invoice/GetInvoicePdf.php @@ -47,6 +47,8 @@ class GetInvoicePdf extends AbstractService $file_path = CreateEntityPdf::dispatchNow($invitation); } + + /* Copy from remote disk to local when using cloud file storage. */ if(config('filesystems.default') == 's3') return TempFile::path(Storage::disk($disk)->url($file_path));