Cutlery/invoiceninja
1
0
Fork 0
mirror of https://github.com/invoiceninja/invoiceninja.git synced 2025-05-31 13:34:36 -04:00
Code Issues Packages Projects Releases Wiki Activity

Updates for static analysis

Browse Source
This commit is contained in:
David Bomba 2023-08-06 18:18:36 +10:00
parent 81bad287ca
commit f186422741
3 changed files with 3 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
app/Http/ValidationRules/ValidRefundableInvoices.php
View File

@ -72,6 +72,7 @@ class ValidRefundableInvoices implements Rule
foreach ($this->input['invoices'] as $val) { foreach ($this->input['invoices'] as $val) {
if ($val['invoice_id'] == $invoice->id) { if ($val['invoice_id'] == $invoice->id) {
/** @var \App\Models\Paymentable $pivot_record */
$pivot_record = $payment->paymentables->where('paymentable_id', $invoice->id)->first(); $pivot_record = $payment->paymentables->where('paymentable_id', $invoice->id)->first();
if ($val['amount'] > ($pivot_record->amount - $pivot_record->refunded)) { if ($val['amount'] > ($pivot_record->amount - $pivot_record->refunded)) {

4
app/Models/Payment.php
View File

@ -77,7 +77,6 @@ use Illuminate\Database\Eloquent\SoftDeletes;
* @property-read \App\Models\PaymentType|null $type * @property-read \App\Models\PaymentType|null $type
* @property-read \App\Models\User|null $user * @property-read \App\Models\User|null $user
* @property-read \App\Models\Vendor|null $vendor * @property-read \App\Models\Vendor|null $vendor
* @method static \Illuminate\Database\Eloquent\Builder exclude($columns)
* @method static \Database\Factories\PaymentFactory factory($count = null, $state = []) * @method static \Database\Factories\PaymentFactory factory($count = null, $state = [])
* @method static \Illuminate\Database\Eloquent\Builder|Payment filter(\App\Filters\QueryFilters $filters) * @method static \Illuminate\Database\Eloquent\Builder|Payment filter(\App\Filters\QueryFilters $filters)
* @method static \Illuminate\Database\Eloquent\Builder|Payment newModelQuery() * @method static \Illuminate\Database\Eloquent\Builder|Payment newModelQuery()
@ -90,8 +89,7 @@ use Illuminate\Database\Eloquent\SoftDeletes;
* @property-read \Illuminate\Database\Eloquent\Collection<int, \App\Models\Credit> $credits * @property-read \Illuminate\Database\Eloquent\Collection<int, \App\Models\Credit> $credits
* @property-read \Illuminate\Database\Eloquent\Collection<int, \App\Models\Document> $documents * @property-read \Illuminate\Database\Eloquent\Collection<int, \App\Models\Document> $documents
* @property-read \Illuminate\Database\Eloquent\Collection<int, \App\Models\Invoice> $invoices * @property-read \Illuminate\Database\Eloquent\Collection<int, \App\Models\Invoice> $invoices
* @property-read \Illuminate\Database\Eloquent\Collection<int, \App\Models\Paymentable> $paymentables * @property \Illuminate\Database\Eloquent\Collection<int, \App\Models\Payment> $paymentables
* @method static \Illuminate\Database\Eloquent\Builder|\Illuminate\Database\Query\Builder withTrashed(bool $withTrashed = true)
* @mixin \Eloquent * @mixin \Eloquent
*/ */
class Payment extends BaseModel class Payment extends BaseModel

2
app/Utils/Traits/Payment/Refundable.php
View File

@ -191,7 +191,7 @@ trait Refundable
$client_balance_adjustment = $this->adjustInvoices($data); $client_balance_adjustment = $this->adjustInvoices($data);
/** @var \App\Models\Client $this->client */ /** @var \App\Models\Payment $this */
$this->client->paid_to_date -= $data['amount']; $this->client->paid_to_date -= $data['amount'];
$this->client->save(); $this->client->save();