diff --git a/app/Http/Controllers/ClientPortalController.php b/app/Http/Controllers/ClientPortalController.php index a18edc445c1a..a1984d5ff07f 100644 --- a/app/Http/Controllers/ClientPortalController.php +++ b/app/Http/Controllers/ClientPortalController.php @@ -48,6 +48,11 @@ class ClientPortalController extends BaseController public function view($invitationKey) { + if (request()->silent) { + session(['silent' => true]); + return redirect(request()->url()); + } + if (! $invitation = $this->invoiceRepo->findInvoiceByInvitation($invitationKey)) { return $this->returnError(); } @@ -67,7 +72,7 @@ class ClientPortalController extends BaseController $account->loadLocalizationSettings($client); - if (! Input::has('phantomjs') && ! Input::has('silent') && ! Session::has($invitationKey) + if (! Input::has('phantomjs') && ! session('silent') && ! Session::has($invitationKey) && (! Auth::check() || Auth::user()->account_id != $invoice->account_id)) { if ($invoice->isType(INVOICE_TYPE_QUOTE)) { event(new QuoteInvitationWasViewed($invoice, $invitation)); diff --git a/app/Http/Controllers/InvoiceController.php b/app/Http/Controllers/InvoiceController.php index 7c9c64e435da..9f49bc067d2a 100644 --- a/app/Http/Controllers/InvoiceController.php +++ b/app/Http/Controllers/InvoiceController.php @@ -169,11 +169,6 @@ class InvoiceController extends BaseController $contact->invitation_openend = $invitation->opened_date && $invitation->opened_date != '0000-00-00 00:00:00' ? $invitation->opened_date : false; $contact->invitation_status = $contact->email_error ? false : $invitation->getStatus(); $contact->invitation_signature_svg = $invitation->signatureDiv(); - - // when using invoice.services prevent markng as viewed - if (Utils::isNinja() && $account->domain_id != \Domain::INVOICENINJA_COM) { - $contact->invitation_link .= '?silent=true'; - } } } } diff --git a/app/Models/Account.php b/app/Models/Account.php index 62924f917f34..84e11563974a 100644 --- a/app/Models/Account.php +++ b/app/Models/Account.php @@ -729,10 +729,6 @@ class Account extends Eloquent */ public function hasLogo() { - if ($this->logo == '') { - $this->calculateLogoDetails(); - } - return ! empty($this->logo); } diff --git a/resources/views/invoices/knockout.blade.php b/resources/views/invoices/knockout.blade.php index 7ba64167f4cb..740802ec55d9 100644 --- a/resources/views/invoices/knockout.blade.php +++ b/resources/views/invoices/knockout.blade.php @@ -670,7 +670,9 @@ function ContactModel(data) { var str = ''; @if (Utils::isConfirmed()) if (self.invitation_link()) { - str += '{{ trans('texts.view_as_recipient') }}'; + // clicking add 'silent=true' however it's removed when copying the link + str += '{{ trans('texts.view_as_recipient') }}'; } @endif