Reduce nesting in SessionManager.OnPlaybackStopped

This commit is contained in:
Patrick Barron 2023-10-03 10:31:55 -04:00
parent 78e00578c2
commit 12b51cf2ba

View File

@ -951,12 +951,13 @@ namespace Emby.Server.Implementations.Session
private bool OnPlaybackStopped(User user, BaseItem item, long? positionTicks, bool playbackFailed) private bool OnPlaybackStopped(User user, BaseItem item, long? positionTicks, bool playbackFailed)
{ {
bool playedToCompletion = false; if (playbackFailed)
if (!playbackFailed)
{ {
var data = _userDataManager.GetUserData(user, item); return false;
}
var data = _userDataManager.GetUserData(user, item);
bool playedToCompletion;
if (positionTicks.HasValue) if (positionTicks.HasValue)
{ {
playedToCompletion = _userDataManager.UpdatePlayState(item, data, positionTicks.Value); playedToCompletion = _userDataManager.UpdatePlayState(item, data, positionTicks.Value);
@ -971,7 +972,6 @@ namespace Emby.Server.Implementations.Session
} }
_userDataManager.SaveUserData(user, item, data, UserDataSaveReason.PlaybackFinished, CancellationToken.None); _userDataManager.SaveUserData(user, item, data, UserDataSaveReason.PlaybackFinished, CancellationToken.None);
}
return playedToCompletion; return playedToCompletion;
} }