Cutlery/jellyfin
1
0
Fork 0
mirror of https://github.com/jellyfin/jellyfin.git synced 2025-07-09 03:04:24 -04:00
Code Issues Packages Projects Releases Wiki Activity

Make StartDate/EndDate nullable (#13494)

Browse Source 
These dates are used as birthdate and death date for person (ask luke for why) and a non-nullable column would cause the null date become 1901-01-01, making all living people dead.
This commit is contained in:
gnattu 2025-02-05 08:02:07 +08:00 committed by GitHub
parent e7f32fb174
commit 2de04cb07c
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
5 changed files with 1657 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
Jellyfin.Data/Entities/BaseItemEntity.cs
View File

@ -18,9 +18,9 @@ public class BaseItemEntity
public string? Path { get; set; } public string? Path { get; set; }
public DateTime StartDate { get; set; } public DateTime? StartDate { get; set; }
public DateTime EndDate { get; set; } public DateTime? EndDate { get; set; }
public string? ChannelId { get; set; } public string? ChannelId { get; set; }

4
Jellyfin.Server.Implementations/Item/BaseItemRepository.cs
View File

@ -645,7 +645,7 @@ public sealed class BaseItemRepository
// dto.MediaType = Enum.TryParse<MediaType>(entity.MediaType); // dto.MediaType = Enum.TryParse<MediaType>(entity.MediaType);
if (dto is IHasStartDate hasStartDate) if (dto is IHasStartDate hasStartDate)
{ {
hasStartDate.StartDate = entity.StartDate; hasStartDate.StartDate = entity.StartDate.GetValueOrDefault();
} }
// Fields that are present in the DB but are never actually used // Fields that are present in the DB but are never actually used
@ -683,7 +683,7 @@ public sealed class BaseItemRepository
entity.ParentId = !dto.ParentId.IsEmpty() ? dto.ParentId : null; entity.ParentId = !dto.ParentId.IsEmpty() ? dto.ParentId : null;
entity.Path = GetPathToSave(dto.Path); entity.Path = GetPathToSave(dto.Path);
entity.EndDate = dto.EndDate.GetValueOrDefault(); entity.EndDate = dto.EndDate;
entity.CommunityRating = dto.CommunityRating; entity.CommunityRating = dto.CommunityRating;
entity.CustomRating = dto.CustomRating; entity.CustomRating = dto.CustomRating;
entity.IndexNumber = dto.IndexNumber; entity.IndexNumber = dto.IndexNumber;

1595
Jellyfin.Server.Implementations/Migrations/20250204092455_MakeStartEndDateNullable.Designer.cs generated Normal file
View File

File diff suppressed because it is too large Load Diff

55
Jellyfin.Server.Implementations/Migrations/20250204092455_MakeStartEndDateNullable.cs Normal file
View File

@ -0,0 +1,55 @@
using System;
using Microsoft.EntityFrameworkCore.Migrations;
#nullable disable
namespace Jellyfin.Server.Implementations.Migrations
{
/// <inheritdoc />
public partial class MakeStartEndDateNullable : Migration
{
/// <inheritdoc />
protected override void Up(MigrationBuilder migrationBuilder)
{
migrationBuilder.AlterColumn<DateTime>(
name: "StartDate",
table: "BaseItems",
type: "TEXT",
nullable: true,
oldClrType: typeof(DateTime),
oldType: "TEXT");
migrationBuilder.AlterColumn<DateTime>(
name: "EndDate",
table: "BaseItems",
type: "TEXT",
nullable: true,
oldClrType: typeof(DateTime),
oldType: "TEXT");
}
/// <inheritdoc />
protected override void Down(MigrationBuilder migrationBuilder)
{
migrationBuilder.AlterColumn<DateTime>(
name: "StartDate",
table: "BaseItems",
type: "TEXT",
nullable: false,
defaultValue: new DateTime(1, 1, 1, 0, 0, 0, 0, DateTimeKind.Unspecified),
oldClrType: typeof(DateTime),
oldType: "TEXT",
oldNullable: true);
migrationBuilder.AlterColumn<DateTime>(
name: "EndDate",
table: "BaseItems",
type: "TEXT",
nullable: false,
defaultValue: new DateTime(1, 1, 1, 0, 0, 0, 0, DateTimeKind.Unspecified),
oldClrType: typeof(DateTime),
oldType: "TEXT",
oldNullable: true);
}
}
}

6
Jellyfin.Server.Implementations/Migrations/JellyfinDbModelSnapshot.cs
View File

@ -15,7 +15,7 @@ namespace Jellyfin.Server.Implementations.Migrations
protected override void BuildModel(ModelBuilder modelBuilder) protected override void BuildModel(ModelBuilder modelBuilder)
{ {
#pragma warning disable 612, 618 #pragma warning disable 612, 618
modelBuilder.HasAnnotation("ProductVersion", "8.0.10"); modelBuilder.HasAnnotation("ProductVersion", "9.0.1");
modelBuilder.Entity("Jellyfin.Data.Entities.AccessSchedule", b => modelBuilder.Entity("Jellyfin.Data.Entities.AccessSchedule", b =>
{ {
@ -185,7 +185,7 @@ namespace Jellyfin.Server.Implementations.Migrations
b.Property<DateTime?>("DateModified") b.Property<DateTime?>("DateModified")
.HasColumnType("TEXT"); .HasColumnType("TEXT");
b.Property<DateTime>("EndDate") b.Property<DateTime?>("EndDate")
.HasColumnType("TEXT"); .HasColumnType("TEXT");
b.Property<string>("EpisodeTitle") b.Property<string>("EpisodeTitle")
@ -323,7 +323,7 @@ namespace Jellyfin.Server.Implementations.Migrations
b.Property<string>("SortName") b.Property<string>("SortName")
.HasColumnType("TEXT"); .HasColumnType("TEXT");
b.Property<DateTime>("StartDate") b.Property<DateTime?>("StartDate")
.HasColumnType("TEXT"); .HasColumnType("TEXT");
b.Property<string>("Studios") b.Property<string>("Studios")