diff --git a/Jellyfin.Api/BaseJellyfinApiController.cs b/Jellyfin.Api/BaseJellyfinApiController.cs
index f691759866..1f4508e6cb 100644
--- a/Jellyfin.Api/BaseJellyfinApiController.cs
+++ b/Jellyfin.Api/BaseJellyfinApiController.cs
@@ -1,5 +1,3 @@
-using Jellyfin.Api.Models.ExceptionDtos;
-using Microsoft.AspNetCore.Http;
using Microsoft.AspNetCore.Mvc;
namespace Jellyfin.Api
@@ -9,7 +7,6 @@ namespace Jellyfin.Api
///
[ApiController]
[Route("[controller]")]
- [ProducesResponseType(typeof(ExceptionDto), StatusCodes.Status500InternalServerError)]
public class BaseJellyfinApiController : ControllerBase
{
}
diff --git a/Jellyfin.Api/Models/ExceptionDtos/ExceptionDto.cs b/Jellyfin.Api/Models/ExceptionDtos/ExceptionDto.cs
deleted file mode 100644
index d2b48d4ae5..0000000000
--- a/Jellyfin.Api/Models/ExceptionDtos/ExceptionDto.cs
+++ /dev/null
@@ -1,14 +0,0 @@
-namespace Jellyfin.Api.Models.ExceptionDtos
-{
- ///
- /// Exception Dto.
- /// Used for graceful handling of API exceptions.
- ///
- public class ExceptionDto
- {
- ///
- /// Gets or sets exception message.
- ///
- public string Message { get; set; }
- }
-}
diff --git a/Jellyfin.Server/Middleware/ExceptionMiddleware.cs b/Jellyfin.Server/Middleware/ExceptionMiddleware.cs
index 39aace95d2..0d9dac89f0 100644
--- a/Jellyfin.Server/Middleware/ExceptionMiddleware.cs
+++ b/Jellyfin.Server/Middleware/ExceptionMiddleware.cs
@@ -1,7 +1,9 @@
using System;
-using System.Text.Json;
+using System.IO;
using System.Threading.Tasks;
-using Jellyfin.Api.Models.ExceptionDtos;
+using MediaBrowser.Common.Extensions;
+using MediaBrowser.Controller.Configuration;
+using MediaBrowser.Controller.Net;
using Microsoft.AspNetCore.Http;
using Microsoft.Extensions.Logging;
@@ -14,17 +16,22 @@ namespace Jellyfin.Server.Middleware
{
private readonly RequestDelegate _next;
private readonly ILogger _logger;
+ private readonly IServerConfigurationManager _configuration;
///
/// Initializes a new instance of the class.
///
/// Next request delegate.
/// Instance of the interface.
- public ExceptionMiddleware(RequestDelegate next, ILoggerFactory loggerFactory)
+ /// Instance of the interface.
+ public ExceptionMiddleware(
+ RequestDelegate next,
+ ILoggerFactory loggerFactory,
+ IServerConfigurationManager serverConfigurationManager)
{
- _next = next ?? throw new ArgumentNullException(nameof(next));
- _logger = loggerFactory.CreateLogger() ??
- throw new ArgumentNullException(nameof(loggerFactory));
+ _next = next;
+ _logger = loggerFactory.CreateLogger();
+ _configuration = serverConfigurationManager;
}
///
@@ -46,15 +53,68 @@ namespace Jellyfin.Server.Middleware
throw;
}
- var exceptionBody = new ExceptionDto { Message = ex.Message };
- var exceptionJson = JsonSerializer.Serialize(exceptionBody);
+ ex = GetActualException(ex);
+ _logger.LogError(ex, "Error processing request: {0}", ex.Message);
+ context.Response.StatusCode = GetStatusCode(ex);
+ context.Response.ContentType = "text/plain";
- context.Response.Clear();
- context.Response.StatusCode = StatusCodes.Status500InternalServerError;
- // TODO switch between PascalCase and camelCase
- context.Response.ContentType = "application/json";
- await context.Response.WriteAsync(exceptionJson).ConfigureAwait(false);
+ var errorContent = NormalizeExceptionMessage(ex.Message);
+ await context.Response.WriteAsync(errorContent).ConfigureAwait(false);
}
}
+
+ private static Exception GetActualException(Exception ex)
+ {
+ if (ex is AggregateException agg)
+ {
+ var inner = agg.InnerException;
+ if (inner != null)
+ {
+ return GetActualException(inner);
+ }
+
+ var inners = agg.InnerExceptions;
+ if (inners.Count > 0)
+ {
+ return GetActualException(inners[0]);
+ }
+ }
+
+ return ex;
+ }
+
+ private static int GetStatusCode(Exception ex)
+ {
+ switch (ex)
+ {
+ case ArgumentException _: return StatusCodes.Status400BadRequest;
+ case SecurityException _: return StatusCodes.Status401Unauthorized;
+ case DirectoryNotFoundException _:
+ case FileNotFoundException _:
+ case ResourceNotFoundException _: return StatusCodes.Status404NotFound;
+ case MethodNotAllowedException _: return StatusCodes.Status405MethodNotAllowed;
+ default: return StatusCodes.Status500InternalServerError;
+ }
+ }
+
+ private string NormalizeExceptionMessage(string msg)
+ {
+ if (msg == null)
+ {
+ return string.Empty;
+ }
+
+ // Strip any information we don't want to reveal
+ msg = msg.Replace(
+ _configuration.ApplicationPaths.ProgramSystemPath,
+ string.Empty,
+ StringComparison.OrdinalIgnoreCase);
+ msg = msg.Replace(
+ _configuration.ApplicationPaths.ProgramDataPath,
+ string.Empty,
+ StringComparison.OrdinalIgnoreCase);
+
+ return msg;
+ }
}
}