From 5aced0ea0f4bca17aee392698351d54b0ad50e26 Mon Sep 17 00:00:00 2001
From: Bruce Coelho <bruce.coelho93@gmail.com>
Date: Sat, 25 Apr 2020 21:41:56 +0100
Subject: [PATCH] Apply suggestions from code review

Co-Authored-By: Cody Robibero <cody@robibe.ro>
---
 Jellyfin.Api/Controllers/PackageController.cs | 9 +++++----
 1 file changed, 5 insertions(+), 4 deletions(-)

diff --git a/Jellyfin.Api/Controllers/PackageController.cs b/Jellyfin.Api/Controllers/PackageController.cs
index ab4d204583..1da5ac0e97 100644
--- a/Jellyfin.Api/Controllers/PackageController.cs
+++ b/Jellyfin.Api/Controllers/PackageController.cs
@@ -39,11 +39,11 @@ namespace Jellyfin.Api.Controllers
         /// <returns>Package info.</returns>
         [HttpGet("/{Name}")]
         [ProducesResponseType(typeof(PackageInfo), StatusCodes.Status200OK)]
-        public ActionResult<PackageInfo> GetPackageInfo(
+        public async Task<ActionResult<PackageInfo>> GetPackageInfo(
             [FromRoute] [Required] string name,
             [FromQuery] string? assemblyGuid)
         {
-            var packages = _installationManager.GetAvailablePackages().GetAwaiter().GetResult();
+            var packages = await _installationManager.GetAvailablePackages().ConfigureAwait(false);
             var result = _installationManager.FilterPackages(
                 packages,
                 name,
@@ -58,11 +58,11 @@ namespace Jellyfin.Api.Controllers
         /// <returns>Packages information.</returns>
         [HttpGet]
         [ProducesResponseType(typeof(PackageInfo[]), StatusCodes.Status200OK)]
-        public async Task<ActionResult<PackageInfo[]>> GetPackages()
+        public async Task<IEnumerable<PackageInfo>> GetPackages()
         {
             IEnumerable<PackageInfo> packages = await _installationManager.GetAvailablePackages().ConfigureAwait(false);
 
-            return Ok(packages.ToArray());
+            return packages;
         }
 
         /// <summary>
@@ -75,6 +75,7 @@ namespace Jellyfin.Api.Controllers
         [HttpPost("/Installed/{Name}")]
         [ProducesResponseType(StatusCodes.Status200OK)]
         [ProducesResponseType(StatusCodes.Status404NotFound)]
+        [Authorize(Policy = Policies.RequiresElevation)]
         public async Task<ActionResult> InstallPackage(
             [FromRoute] [Required] string name,
             [FromQuery] string assemblyGuid,