From 61d8d40a4a2bcdfd72d810f1c22247dfc53d6d53 Mon Sep 17 00:00:00 2001 From: Matthew Jones Date: Fri, 14 Jan 2022 11:24:25 +0000 Subject: [PATCH] Added type options to disable embedded subs --- MediaBrowser.Model/Configuration/LibraryOptions.cs | 4 +++- MediaBrowser.Providers/MediaInfo/FFProbeVideoInfo.cs | 12 +++++++++--- 2 files changed, 12 insertions(+), 4 deletions(-) diff --git a/MediaBrowser.Model/Configuration/LibraryOptions.cs b/MediaBrowser.Model/Configuration/LibraryOptions.cs index 5b77d22fac..efa63b5e16 100644 --- a/MediaBrowser.Model/Configuration/LibraryOptions.cs +++ b/MediaBrowser.Model/Configuration/LibraryOptions.cs @@ -84,7 +84,9 @@ namespace MediaBrowser.Model.Configuration public bool AutomaticallyAddToCollection { get; set; } - public bool DisableEmbeddedSubtitles { get; set; } + public bool DisableEmbeddedTextSubtitles { get; set; } + + public bool DisableEmbeddedImageSubtitles { get; set; } public TypeOptions[] TypeOptions { get; set; } diff --git a/MediaBrowser.Providers/MediaInfo/FFProbeVideoInfo.cs b/MediaBrowser.Providers/MediaInfo/FFProbeVideoInfo.cs index 747376823d..c1145f8a2a 100644 --- a/MediaBrowser.Providers/MediaInfo/FFProbeVideoInfo.cs +++ b/MediaBrowser.Providers/MediaInfo/FFProbeVideoInfo.cs @@ -229,10 +229,16 @@ namespace MediaBrowser.Providers.MediaInfo video.Video3DFormat ??= mediaInfo.Video3DFormat; } - if (libraryOptions.DisableEmbeddedSubtitles) + if (libraryOptions.DisableEmbeddedImageSubtitles) { - _logger.LogDebug("Disabling embedded subtitles for {Path} due to DisableEmbeddedSubtitles setting", video.Path); - mediaStreams.RemoveAll(i => i.Type == MediaStreamType.Subtitle && !i.IsExternal); + _logger.LogDebug("Disabling embedded image subtitles for {Path} due to DisableEmbeddedImageSubtitles setting", video.Path); + mediaStreams.RemoveAll(i => i.Type == MediaStreamType.Subtitle && !i.IsExternal && !i.IsTextSubtitleStream); + } + + if (libraryOptions.DisableEmbeddedTextSubtitles) + { + _logger.LogDebug("Disabling embedded text subtitles for {Path} due to DisableEmbeddedTextSubtitles setting", video.Path); + mediaStreams.RemoveAll(i => i.Type == MediaStreamType.Subtitle && !i.IsExternal && i.IsTextSubtitleStream); } var videoStream = mediaStreams.FirstOrDefault(i => i.Type == MediaStreamType.Video);