Cutlery/jellyfin
1
0
Fork 0
mirror of https://github.com/jellyfin/jellyfin.git synced 2025-07-31 14:33:54 -04:00
Code Issues Packages Projects Releases Wiki Activity

Fix trickplay extraction ffmpeg error-handling (#14493)

Browse Source
This commit is contained in:
jkhsjdhjs 2025-07-23 01:13:38 +02:00 committed by GitHub
parent dddeea1f7b
commit 663087b155
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 1 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
MediaBrowser.MediaEncoding/Encoder/MediaEncoder.cs
View File

@ -1071,11 +1071,8 @@ namespace MediaBrowser.MediaEncoding.Encoder
} }
} }
var exitCode = ranToCompletion ? processWrapper.ExitCode ?? 0 : -1; if (!ranToCompletion || processWrapper.ExitCode != 0)
if (exitCode == -1)
{ {
_logger.LogError("ffmpeg image extraction failed for {ProcessDescription}", processDescription);
// Cleanup temp folder here, because the targetDirectory is not returned and the cleanup for failed ffmpeg process is not possible for caller. // Cleanup temp folder here, because the targetDirectory is not returned and the cleanup for failed ffmpeg process is not possible for caller.
// Ideally the ffmpeg should not write any files if it fails, but it seems like it is not guaranteed. // Ideally the ffmpeg should not write any files if it fails, but it seems like it is not guaranteed.
try try