Cutlery/jellyfin
1
0
Fork 0
mirror of https://github.com/jellyfin/jellyfin.git synced 2025-05-31 20:24:21 -04:00
Code Issues Packages Projects Releases Wiki Activity

Cleaned up "value assigned is not used in any execution path"

Browse Source
This commit is contained in:
BaronGreenback 2021-04-17 09:27:58 +01:00
parent b63f615fd4
commit 80877aa945
10 changed files with 19 additions and 22 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
Emby.Dlna/Service/BaseControlHandler.cs
View File

@ -47,7 +47,7 @@ namespace Emby.Dlna.Service
private async Task<ControlResponse> ProcessControlRequestInternalAsync(ControlRequest request) private async Task<ControlResponse> ProcessControlRequestInternalAsync(ControlRequest request)
{ {
ControlRequestInfo requestInfo = null; ControlRequestInfo requestInfo;
using (var streamReader = new StreamReader(request.InputXml, Encoding.UTF8)) using (var streamReader = new StreamReader(request.InputXml, Encoding.UTF8))
{ {

4
Emby.Server.Implementations/HttpServer/WebSocketConnection.cs
View File

@ -1,4 +1,4 @@
#nullable enable #nullable enable
using System; using System;
using System.Buffers; using System.Buffers;
@ -182,7 +182,7 @@ namespace Emby.Server.Implementations.HttpServer
} }
WebSocketMessage<object>? stub; WebSocketMessage<object>? stub;
long bytesConsumed = 0; long bytesConsumed;
try try
{ {
stub = DeserializeWebSocketMessage(buffer, out bytesConsumed); stub = DeserializeWebSocketMessage(buffer, out bytesConsumed);

2
Emby.Server.Implementations/LiveTv/TunerHosts/HdHomerun/HdHomerunUdpStream.cs
View File

@ -87,7 +87,7 @@ namespace Emby.Server.Implementations.LiveTv.TunerHosts.HdHomerun
Logger.LogInformation("Opening HDHR UDP Live stream from {host}", uri.Host); Logger.LogInformation("Opening HDHR UDP Live stream from {host}", uri.Host);
var remoteAddress = IPAddress.Parse(uri.Host); var remoteAddress = IPAddress.Parse(uri.Host);
IPAddress localAddress = null; IPAddress localAddress;
using (var tcpClient = new TcpClient()) using (var tcpClient = new TcpClient())
{ {
try try

3
Emby.Server.Implementations/QuickConnect/QuickConnectManager.cs
View File

@ -258,7 +258,6 @@ namespace Emby.Server.Implementations.QuickConnect
} }
// Expire stale connection requests // Expire stale connection requests
var code = string.Empty;
var values = _currentRequests.Values.ToList(); var values = _currentRequests.Values.ToList();
for (int i = 0; i < values.Count; i++) for (int i = 0; i < values.Count; i++)
@ -266,7 +265,7 @@ namespace Emby.Server.Implementations.QuickConnect
var added = values[i].DateAdded ?? DateTime.UnixEpoch; var added = values[i].DateAdded ?? DateTime.UnixEpoch;
if (DateTime.UtcNow > added.AddMinutes(Timeout) || expireAll) if (DateTime.UtcNow > added.AddMinutes(Timeout) || expireAll)
{ {
code = values[i].Code; var code = values[i].Code;
_logger.LogDebug("Removing expired request {code}", code); _logger.LogDebug("Removing expired request {code}", code);
if (!_currentRequests.TryRemove(code, out _)) if (!_currentRequests.TryRemove(code, out _))

2
Jellyfin.Api/Controllers/LibraryController.cs
View File

@ -732,7 +732,7 @@ namespace Jellyfin.Api.Controllers
else else
{ {
// For non series and movie types these columns are typically null // For non series and movie types these columns are typically null
isSeries = null; // isSeries = null;
isMovie = null; isMovie = null;
includeItemTypes.Add(item.GetType().Name); includeItemTypes.Add(item.GetType().Name);
} }

2
Jellyfin.Api/Controllers/VideoHlsController.cs
View File

@ -376,7 +376,7 @@ namespace Jellyfin.Api.Controllers
} }
else if (string.Equals(segmentFormat, "mp4", StringComparison.OrdinalIgnoreCase)) else if (string.Equals(segmentFormat, "mp4", StringComparison.OrdinalIgnoreCase))
{ {
var outputFmp4HeaderArg = string.Empty; string outputFmp4HeaderArg;
var isWindows = RuntimeInformation.IsOSPlatform(OSPlatform.Windows); var isWindows = RuntimeInformation.IsOSPlatform(OSPlatform.Windows);
if (isWindows) if (isWindows)
{ {

4
MediaBrowser.Controller/LiveTv/LiveTvChannel.cs
View File

@ -61,9 +61,7 @@ namespace MediaBrowser.Controller.LiveTv
{ {
if (!string.IsNullOrEmpty(Number)) if (!string.IsNullOrEmpty(Number))
{ {
double number = 0; if (double.TryParse(Number, NumberStyles.Any, CultureInfo.InvariantCulture, out double number))
if (double.TryParse(Number, NumberStyles.Any, CultureInfo.InvariantCulture, out number))
{ {
return string.Format(CultureInfo.InvariantCulture, "{0:00000.0}", number) + "-" + (Name ?? string.Empty); return string.Format(CultureInfo.InvariantCulture, "{0:00000.0}", number) + "-" + (Name ?? string.Empty);
} }

8
MediaBrowser.LocalMetadata/Images/LocalImageProvider.cs
View File

@ -203,7 +203,7 @@ namespace MediaBrowser.LocalMetadata.Images
added = AddImage(files, images, "logo", imagePrefix, isInMixedFolder, ImageType.Logo); added = AddImage(files, images, "logo", imagePrefix, isInMixedFolder, ImageType.Logo);
if (!added) if (!added)
{ {
added = AddImage(files, images, "clearlogo", imagePrefix, isInMixedFolder, ImageType.Logo); AddImage(files, images, "clearlogo", imagePrefix, isInMixedFolder, ImageType.Logo);
} }
} }
@ -220,7 +220,7 @@ namespace MediaBrowser.LocalMetadata.Images
if (!added) if (!added)
{ {
added = AddImage(files, images, "disc", imagePrefix, isInMixedFolder, ImageType.Disc); AddImage(files, images, "disc", imagePrefix, isInMixedFolder, ImageType.Disc);
} }
} }
else if (item is Video || item is BoxSet) else if (item is Video || item is BoxSet)
@ -234,7 +234,7 @@ namespace MediaBrowser.LocalMetadata.Images
if (!added) if (!added)
{ {
added = AddImage(files, images, "discart", imagePrefix, isInMixedFolder, ImageType.Disc); AddImage(files, images, "discart", imagePrefix, isInMixedFolder, ImageType.Disc);
} }
} }
@ -250,7 +250,7 @@ namespace MediaBrowser.LocalMetadata.Images
added = AddImage(files, images, "landscape", imagePrefix, isInMixedFolder, ImageType.Thumb); added = AddImage(files, images, "landscape", imagePrefix, isInMixedFolder, ImageType.Thumb);
if (!added) if (!added)
{ {
added = AddImage(files, images, "thumb", imagePrefix, isInMixedFolder, ImageType.Thumb); AddImage(files, images, "thumb", imagePrefix, isInMixedFolder, ImageType.Thumb);
} }
} }

8
MediaBrowser.Providers/MediaInfo/FFProbeVideoInfo.cs
View File

@ -111,10 +111,10 @@ namespace MediaBrowser.Providers.MediaInfo
} }
} }
if (streamFileNames == null) // if (streamFileNames == null)
{ // {
streamFileNames = Array.Empty<string>(); // streamFileNames = Array.Empty<string>();
} // }
mediaInfoResult = await GetMediaInfo(item, cancellationToken).ConfigureAwait(false); mediaInfoResult = await GetMediaInfo(item, cancellationToken).ConfigureAwait(false);

6
MediaBrowser.Providers/MediaInfo/SubtitleScheduledTask.cs
View File

@ -75,21 +75,21 @@ namespace MediaBrowser.Providers.MediaInfo
string[] subtitleDownloadLanguages; string[] subtitleDownloadLanguages;
bool skipIfEmbeddedSubtitlesPresent; bool skipIfEmbeddedSubtitlesPresent;
bool skipIfAudioTrackMatches; bool skipIfAudioTrackMatches;
bool requirePerfectMatch; // bool requirePerfectMatch;
if (libraryOptions.SubtitleDownloadLanguages == null) if (libraryOptions.SubtitleDownloadLanguages == null)
{ {
subtitleDownloadLanguages = options.DownloadLanguages; subtitleDownloadLanguages = options.DownloadLanguages;
skipIfEmbeddedSubtitlesPresent = options.SkipIfEmbeddedSubtitlesPresent; skipIfEmbeddedSubtitlesPresent = options.SkipIfEmbeddedSubtitlesPresent;
skipIfAudioTrackMatches = options.SkipIfAudioTrackMatches; skipIfAudioTrackMatches = options.SkipIfAudioTrackMatches;
requirePerfectMatch = options.RequirePerfectMatch; // requirePerfectMatch = options.RequirePerfectMatch;
} }
else else
{ {
subtitleDownloadLanguages = libraryOptions.SubtitleDownloadLanguages; subtitleDownloadLanguages = libraryOptions.SubtitleDownloadLanguages;
skipIfEmbeddedSubtitlesPresent = libraryOptions.SkipSubtitlesIfEmbeddedSubtitlesPresent; skipIfEmbeddedSubtitlesPresent = libraryOptions.SkipSubtitlesIfEmbeddedSubtitlesPresent;
skipIfAudioTrackMatches = libraryOptions.SkipSubtitlesIfAudioTrackMatches; skipIfAudioTrackMatches = libraryOptions.SkipSubtitlesIfAudioTrackMatches;
requirePerfectMatch = libraryOptions.RequirePerfectSubtitleMatch; // requirePerfectMatch = libraryOptions.RequirePerfectSubtitleMatch;
} }
foreach (var lang in subtitleDownloadLanguages) foreach (var lang in subtitleDownloadLanguages)