Fully async'd xml parsing process as well as added resolver and provider priorities

This commit is contained in:
LukePulverenti Luke Pulverenti luke pulverenti 2012-08-20 11:55:05 -04:00
parent 19a4dd83c2
commit 8f024e8199
21 changed files with 295 additions and 180 deletions

View File

@ -99,8 +99,13 @@ namespace MediaBrowser.Common.Kernel
IEnumerable<Assembly> pluginAssemblies = Directory.GetFiles(ApplicationPaths.PluginsPath, "*.dll", SearchOption.AllDirectories).Select(f => Assembly.Load(File.ReadAllBytes((f)))); IEnumerable<Assembly> pluginAssemblies = Directory.GetFiles(ApplicationPaths.PluginsPath, "*.dll", SearchOption.AllDirectories).Select(f => Assembly.Load(File.ReadAllBytes((f))));
var catalog = new AggregateCatalog(pluginAssemblies.Select(a => new AssemblyCatalog(a))); var catalog = new AggregateCatalog(pluginAssemblies.Select(a => new AssemblyCatalog(a)));
// Include composable parts in the Common assembly
// Uncomment this if it's ever needed
//catalog.Catalogs.Add(new AssemblyCatalog(Assembly.GetExecutingAssembly())); //catalog.Catalogs.Add(new AssemblyCatalog(Assembly.GetExecutingAssembly()));
//catalog.Catalogs.Add(new AssemblyCatalog(GetType().Assembly));
// Include composable parts in the subclass assembly
catalog.Catalogs.Add(new AssemblyCatalog(GetType().Assembly));
var container = new CompositionContainer(catalog); var container = new CompositionContainer(catalog);

View File

@ -86,42 +86,10 @@ namespace MediaBrowser.Controller
protected override void OnComposablePartsLoaded() protected override void OnComposablePartsLoaded()
{ {
AddCoreResolvers();
AddCoreProviders();
// The base class will start up all the plugins // The base class will start up all the plugins
base.OnComposablePartsLoaded(); base.OnComposablePartsLoaded();
}
private void AddCoreResolvers()
{
List<IBaseItemResolver> list = EntityResolvers.ToList();
// Add the core resolvers
list.AddRange(new IBaseItemResolver[]{
new AudioResolver(),
new VideoResolver(),
new VirtualFolderResolver(),
new FolderResolver()
});
EntityResolvers = list;
}
private void AddCoreProviders()
{
List<BaseMetadataProvider> list = MetadataProviders.ToList();
// Add the core resolvers
list.InsertRange(0, new BaseMetadataProvider[]{
new ImageFromMediaLocationProvider(),
new LocalTrailerProvider(),
new AudioInfoProvider(),
new FolderProviderFromXml()
});
MetadataProviders = list;
// Initialize the metadata providers
Parallel.ForEach(MetadataProviders, provider => Parallel.ForEach(MetadataProviders, provider =>
{ {
provider.Init(); provider.Init();
@ -264,19 +232,43 @@ namespace MediaBrowser.Controller
// Get all supported providers // Get all supported providers
var supportedProviders = Kernel.Instance.MetadataProviders.Where(i => i.Supports(item)); var supportedProviders = Kernel.Instance.MetadataProviders.Where(i => i.Supports(item));
// Start with non-internet providers. Run them sequentially // First priority providers
foreach (BaseMetadataProvider provider in supportedProviders.Where(i => !i.RequiresInternet)) var providers = supportedProviders.Where(i => !i.RequiresInternet && i.Priority == MetadataProviderPriority.First);
if (providers.Any())
{ {
await provider.Fetch(item, args); await Task.WhenAll(
providers.Select(i => i.Fetch(item, args))
);
} }
var internetProviders = supportedProviders.Where(i => i.RequiresInternet); // Second priority providers
providers = supportedProviders.Where(i => !i.RequiresInternet && i.Priority == MetadataProviderPriority.Second);
if (internetProviders.Any()) if (providers.Any())
{ {
// Now execute internet providers in parallel
await Task.WhenAll( await Task.WhenAll(
internetProviders.Select(i => i.Fetch(item, args)) providers.Select(i => i.Fetch(item, args))
);
}
// Lowest priority providers
providers = supportedProviders.Where(i => !i.RequiresInternet && i.Priority == MetadataProviderPriority.Last);
if (providers.Any())
{
await Task.WhenAll(
providers.Select(i => i.Fetch(item, args))
);
}
// Execute internet providers
providers = supportedProviders.Where(i => i.RequiresInternet);
if (providers.Any())
{
await Task.WhenAll(
providers.Select(i => i.Fetch(item, args))
); );
} }
} }

View File

@ -59,8 +59,41 @@ namespace MediaBrowser.Controller.Library
private async Task<BaseItem> ResolveItem(ItemResolveEventArgs args) private async Task<BaseItem> ResolveItem(ItemResolveEventArgs args)
{ {
// If that didn't pan out, try the slow ones // Try first priority resolvers
foreach (IBaseItemResolver resolver in Kernel.Instance.EntityResolvers) foreach (IBaseItemResolver resolver in Kernel.Instance.EntityResolvers.Where(p => p.Priority == ResolverPriority.First))
{
var item = await resolver.ResolvePath(args);
if (item != null)
{
return item;
}
}
// Try second priority resolvers
foreach (IBaseItemResolver resolver in Kernel.Instance.EntityResolvers.Where(p => p.Priority == ResolverPriority.Second))
{
var item = await resolver.ResolvePath(args);
if (item != null)
{
return item;
}
}
// Try third priority resolvers
foreach (IBaseItemResolver resolver in Kernel.Instance.EntityResolvers.Where(p => p.Priority == ResolverPriority.Third))
{
var item = await resolver.ResolvePath(args);
if (item != null)
{
return item;
}
}
// Try last priority resolvers
foreach (IBaseItemResolver resolver in Kernel.Instance.EntityResolvers.Where(p => p.Priority == ResolverPriority.Last))
{ {
var item = await resolver.ResolvePath(args); var item = await resolver.ResolvePath(args);

View File

@ -18,6 +18,11 @@ namespace MediaBrowser.Controller.Providers
return item is Audio; return item is Audio;
} }
public override MetadataProviderPriority Priority
{
get { return MetadataProviderPriority.First; }
}
public async override Task Fetch(BaseEntity item, ItemResolveEventArgs args) public async override Task Fetch(BaseEntity item, ItemResolveEventArgs args)
{ {
Audio audio = item as Audio; Audio audio = item as Audio;

View File

@ -32,5 +32,22 @@ namespace MediaBrowser.Controller.Providers
} }
public abstract Task Fetch(BaseEntity item, ItemResolveEventArgs args); public abstract Task Fetch(BaseEntity item, ItemResolveEventArgs args);
public abstract MetadataProviderPriority Priority { get; }
}
/// <summary>
/// Determines when a provider should execute, relative to others
/// </summary>
public enum MetadataProviderPriority
{
// Run this provider at the beginning
First,
// Run this provider after all first priority providers
Second,
// Run this provider last
Last
} }
} }

View File

@ -14,6 +14,11 @@ namespace MediaBrowser.Controller.Providers
return item is Folder; return item is Folder;
} }
public override MetadataProviderPriority Priority
{
get { return MetadataProviderPriority.First; }
}
public async override Task Fetch(BaseEntity item, ItemResolveEventArgs args) public async override Task Fetch(BaseEntity item, ItemResolveEventArgs args)
{ {
var metadataFile = args.GetFileByName("folder.xml"); var metadataFile = args.GetFileByName("folder.xml");

View File

@ -17,6 +17,11 @@ namespace MediaBrowser.Controller.Providers
return true; return true;
} }
public override MetadataProviderPriority Priority
{
get { return MetadataProviderPriority.First; }
}
public override Task Fetch(BaseEntity item, ItemResolveEventArgs args) public override Task Fetch(BaseEntity item, ItemResolveEventArgs args)
{ {
return Task.Run(() => return Task.Run(() =>

View File

@ -15,6 +15,11 @@ namespace MediaBrowser.Controller.Providers
return item is BaseItem; return item is BaseItem;
} }
public override MetadataProviderPriority Priority
{
get { return MetadataProviderPriority.First; }
}
public async override Task Fetch(BaseEntity item, ItemResolveEventArgs args) public async override Task Fetch(BaseEntity item, ItemResolveEventArgs args)
{ {
BaseItem baseItem = item as BaseItem; BaseItem baseItem = item as BaseItem;

View File

@ -8,6 +8,11 @@ namespace MediaBrowser.Controller.Resolvers
[Export(typeof(IBaseItemResolver))] [Export(typeof(IBaseItemResolver))]
public class AudioResolver : BaseItemResolver<Audio> public class AudioResolver : BaseItemResolver<Audio>
{ {
public override ResolverPriority Priority
{
get { return ResolverPriority.Last; }
}
protected override Audio Resolve(ItemResolveEventArgs args) protected override Audio Resolve(ItemResolveEventArgs args)
{ {
// Return audio if the path is a file and has a matching extension // Return audio if the path is a file and has a matching extension

View File

@ -14,6 +14,14 @@ namespace MediaBrowser.Controller.Resolvers
return null; return null;
} }
public virtual ResolverPriority Priority
{
get
{
return ResolverPriority.First;
}
}
/// <summary> /// <summary>
/// Sets initial values on the newly resolved item /// Sets initial values on the newly resolved item
/// </summary> /// </summary>
@ -89,5 +97,14 @@ namespace MediaBrowser.Controller.Resolvers
public interface IBaseItemResolver public interface IBaseItemResolver
{ {
Task<BaseItem> ResolvePath(ItemResolveEventArgs args); Task<BaseItem> ResolvePath(ItemResolveEventArgs args);
ResolverPriority Priority { get; }
}
public enum ResolverPriority
{
First,
Second,
Third,
Last
} }
} }

View File

@ -7,6 +7,11 @@ namespace MediaBrowser.Controller.Resolvers
[Export(typeof(IBaseItemResolver))] [Export(typeof(IBaseItemResolver))]
public class FolderResolver : BaseFolderResolver<Folder> public class FolderResolver : BaseFolderResolver<Folder>
{ {
public override ResolverPriority Priority
{
get { return ResolverPriority.Last; }
}
protected override Folder Resolve(ItemResolveEventArgs args) protected override Folder Resolve(ItemResolveEventArgs args)
{ {
if (args.IsFolder) if (args.IsFolder)

View File

@ -12,6 +12,10 @@ namespace MediaBrowser.Controller.Resolvers
[Export(typeof(IBaseItemResolver))] [Export(typeof(IBaseItemResolver))]
public class VideoResolver : BaseVideoResolver<Video> public class VideoResolver : BaseVideoResolver<Video>
{ {
public override ResolverPriority Priority
{
get { return ResolverPriority.Last; }
}
} }
/// <summary> /// <summary>

View File

@ -8,6 +8,11 @@ namespace MediaBrowser.Controller.Resolvers
[Export(typeof(IBaseItemResolver))] [Export(typeof(IBaseItemResolver))]
public class VirtualFolderResolver : BaseFolderResolver<VirtualFolder> public class VirtualFolderResolver : BaseFolderResolver<VirtualFolder>
{ {
public override ResolverPriority Priority
{
get { return ResolverPriority.Third; }
}
protected override VirtualFolder Resolve(ItemResolveEventArgs args) protected override VirtualFolder Resolve(ItemResolveEventArgs args)
{ {
if (args.IsFolder && args.Parent != null && args.Parent.IsRoot) if (args.IsFolder && args.Parent != null && args.Parent.IsRoot)

View File

@ -29,7 +29,7 @@ namespace MediaBrowser.Controller.Xml
{ {
if (reader.NodeType == XmlNodeType.Element) if (reader.NodeType == XmlNodeType.Element)
{ {
FetchDataFromXmlNode(reader, item); await FetchDataFromXmlNode(reader, item);
} }
} }
} }
@ -49,14 +49,14 @@ namespace MediaBrowser.Controller.Xml
/// <summary> /// <summary>
/// Fetches metadata from one Xml Element /// Fetches metadata from one Xml Element
/// </summary> /// </summary>
protected virtual void FetchDataFromXmlNode(XmlReader reader, T item) protected async virtual Task FetchDataFromXmlNode(XmlReader reader, T item)
{ {
switch (reader.Name) switch (reader.Name)
{ {
// DateCreated // DateCreated
case "Added": case "Added":
DateTime added; DateTime added;
if (DateTime.TryParse(reader.ReadString() ?? string.Empty, out added)) if (DateTime.TryParse(await reader.ReadElementContentAsStringAsync() ?? string.Empty, out added))
{ {
item.DateCreated = added; item.DateCreated = added;
} }
@ -65,7 +65,7 @@ namespace MediaBrowser.Controller.Xml
// DisplayMediaType // DisplayMediaType
case "Type": case "Type":
{ {
item.DisplayMediaType = reader.ReadString(); item.DisplayMediaType = await reader.ReadElementContentAsStringAsync();
switch (item.DisplayMediaType.ToLower()) switch (item.DisplayMediaType.ToLower())
{ {
@ -85,26 +85,26 @@ namespace MediaBrowser.Controller.Xml
// TODO: Do we still need this? // TODO: Do we still need this?
case "banner": case "banner":
item.BannerImagePath = reader.ReadString(); item.BannerImagePath = await reader.ReadElementContentAsStringAsync();
break; break;
case "LocalTitle": case "LocalTitle":
item.Name = reader.ReadString(); item.Name = await reader.ReadElementContentAsStringAsync();
break; break;
case "SortTitle": case "SortTitle":
item.SortName = reader.ReadString(); item.SortName = await reader.ReadElementContentAsStringAsync();
break; break;
case "Overview": case "Overview":
case "Description": case "Description":
item.Overview = reader.ReadString(); item.Overview = await reader.ReadElementContentAsStringAsync();
break; break;
case "TagLine": case "TagLine":
{ {
var list = (item.Taglines ?? new string[] { }).ToList(); var list = (item.Taglines ?? new string[] { }).ToList();
var tagline = reader.ReadString(); var tagline = await reader.ReadElementContentAsStringAsync();
if (!list.Contains(tagline)) if (!list.Contains(tagline))
{ {
@ -117,23 +117,23 @@ namespace MediaBrowser.Controller.Xml
case "TagLines": case "TagLines":
{ {
FetchFromTaglinesNode(reader.ReadSubtree(), item); await FetchFromTaglinesNode(reader.ReadSubtree(), item);
break; break;
} }
case "ContentRating": case "ContentRating":
case "MPAARating": case "MPAARating":
item.OfficialRating = reader.ReadString(); item.OfficialRating = await reader.ReadElementContentAsStringAsync();
break; break;
case "CustomRating": case "CustomRating":
item.CustomRating = reader.ReadString(); item.CustomRating = await reader.ReadElementContentAsStringAsync();
break; break;
case "Runtime": case "Runtime":
case "RunningTime": case "RunningTime":
{ {
string text = reader.ReadString(); string text = await reader.ReadElementContentAsStringAsync();
if (!string.IsNullOrWhiteSpace(text)) if (!string.IsNullOrWhiteSpace(text))
{ {
@ -149,20 +149,20 @@ namespace MediaBrowser.Controller.Xml
case "Genre": case "Genre":
{ {
var genres = (item.Genres ?? new string[] { }).ToList(); var genres = (item.Genres ?? new string[] { }).ToList();
genres.AddRange(GetSplitValues(reader.ReadString(), '|')); genres.AddRange(GetSplitValues(await reader.ReadElementContentAsStringAsync(), '|'));
item.Genres = genres; item.Genres = genres;
break; break;
} }
case "AspectRatio": case "AspectRatio":
item.AspectRatio = reader.ReadString(); item.AspectRatio = await reader.ReadElementContentAsStringAsync();
break; break;
case "Network": case "Network":
{ {
var studios = (item.Studios ?? new string[] { }).ToList(); var studios = (item.Studios ?? new string[] { }).ToList();
studios.AddRange(GetSplitValues(reader.ReadString(), '|')); studios.AddRange(GetSplitValues(await reader.ReadElementContentAsStringAsync(), '|'));
item.Studios = studios; item.Studios = studios;
break; break;
@ -171,7 +171,7 @@ namespace MediaBrowser.Controller.Xml
case "Director": case "Director":
{ {
var list = (item.People ?? new PersonInfo[] { }).ToList(); var list = (item.People ?? new PersonInfo[] { }).ToList();
list.AddRange(GetSplitValues(reader.ReadString(), '|').Select(v => new PersonInfo() { Name = v, Type = "Director" })); list.AddRange(GetSplitValues(await reader.ReadElementContentAsStringAsync(), '|').Select(v => new PersonInfo() { Name = v, Type = "Director" }));
item.People = list; item.People = list;
break; break;
@ -179,7 +179,7 @@ namespace MediaBrowser.Controller.Xml
case "Writer": case "Writer":
{ {
var list = (item.People ?? new PersonInfo[] { }).ToList(); var list = (item.People ?? new PersonInfo[] { }).ToList();
list.AddRange(GetSplitValues(reader.ReadString(), '|').Select(v => new PersonInfo() { Name = v, Type = "Writer" })); list.AddRange(GetSplitValues(await reader.ReadElementContentAsStringAsync(), '|').Select(v => new PersonInfo() { Name = v, Type = "Writer" }));
item.People = list; item.People = list;
break; break;
@ -189,19 +189,19 @@ namespace MediaBrowser.Controller.Xml
case "GuestStars": case "GuestStars":
{ {
var list = (item.People ?? new PersonInfo[] { }).ToList(); var list = (item.People ?? new PersonInfo[] { }).ToList();
list.AddRange(GetSplitValues(reader.ReadString(), '|').Select(v => new PersonInfo() { Name = v, Type = "Actor" })); list.AddRange(GetSplitValues(await reader.ReadElementContentAsStringAsync(), '|').Select(v => new PersonInfo() { Name = v, Type = "Actor" }));
item.People = list; item.People = list;
break; break;
} }
case "Trailer": case "Trailer":
item.TrailerUrl = reader.ReadString(); item.TrailerUrl = await reader.ReadElementContentAsStringAsync();
break; break;
case "ProductionYear": case "ProductionYear":
{ {
string val = reader.ReadString(); string val = await reader.ReadElementContentAsStringAsync();
if (!string.IsNullOrWhiteSpace(val)) if (!string.IsNullOrWhiteSpace(val))
{ {
@ -218,7 +218,7 @@ namespace MediaBrowser.Controller.Xml
case "Rating": case "Rating":
case "IMDBrating": case "IMDBrating":
string rating = reader.ReadString(); string rating = await reader.ReadElementContentAsStringAsync();
if (!string.IsNullOrWhiteSpace(rating)) if (!string.IsNullOrWhiteSpace(rating))
{ {
@ -233,7 +233,7 @@ namespace MediaBrowser.Controller.Xml
case "FirstAired": case "FirstAired":
{ {
string firstAired = reader.ReadString(); string firstAired = await reader.ReadElementContentAsStringAsync();
if (!string.IsNullOrWhiteSpace(firstAired)) if (!string.IsNullOrWhiteSpace(firstAired))
{ {
@ -250,7 +250,7 @@ namespace MediaBrowser.Controller.Xml
} }
case "TMDbId": case "TMDbId":
string tmdb = reader.ReadString(); string tmdb = await reader.ReadElementContentAsStringAsync();
if (!string.IsNullOrWhiteSpace(tmdb)) if (!string.IsNullOrWhiteSpace(tmdb))
{ {
item.SetProviderId(MetadataProviders.Tmdb, tmdb); item.SetProviderId(MetadataProviders.Tmdb, tmdb);
@ -258,7 +258,7 @@ namespace MediaBrowser.Controller.Xml
break; break;
case "TVcomId": case "TVcomId":
string TVcomId = reader.ReadString(); string TVcomId = await reader.ReadElementContentAsStringAsync();
if (!string.IsNullOrWhiteSpace(TVcomId)) if (!string.IsNullOrWhiteSpace(TVcomId))
{ {
item.SetProviderId(MetadataProviders.Tvcom, TVcomId); item.SetProviderId(MetadataProviders.Tvcom, TVcomId);
@ -268,7 +268,7 @@ namespace MediaBrowser.Controller.Xml
case "IMDB_ID": case "IMDB_ID":
case "IMDB": case "IMDB":
case "IMDbId": case "IMDbId":
string IMDbId = reader.ReadString(); string IMDbId = await reader.ReadElementContentAsStringAsync();
if (!string.IsNullOrWhiteSpace(IMDbId)) if (!string.IsNullOrWhiteSpace(IMDbId))
{ {
item.SetProviderId(MetadataProviders.Imdb, IMDbId); item.SetProviderId(MetadataProviders.Imdb, IMDbId);
@ -276,46 +276,43 @@ namespace MediaBrowser.Controller.Xml
break; break;
case "Genres": case "Genres":
FetchFromGenresNode(reader.ReadSubtree(), item); await FetchFromGenresNode(reader.ReadSubtree(), item);
break; break;
case "Persons": case "Persons":
FetchDataFromPersonsNode(reader.ReadSubtree(), item); await FetchDataFromPersonsNode(reader.ReadSubtree(), item);
break; break;
case "ParentalRating": case "ParentalRating":
FetchFromParentalRatingNode(reader.ReadSubtree(), item); await FetchFromParentalRatingNode(reader.ReadSubtree(), item);
break; break;
case "Studios": case "Studios":
FetchFromStudiosNode(reader.ReadSubtree(), item); await FetchFromStudiosNode(reader.ReadSubtree(), item);
break; break;
case "MediaInfo": case "MediaInfo":
FetchMediaInfo(reader.ReadSubtree(), item); {
break; var video = item as Video;
if (video != null)
{
await FetchMediaInfo(reader.ReadSubtree(), video);
}
break;
}
default: default:
reader.Skip(); await reader.SkipAsync();
break; break;
} }
} }
private void FetchMediaInfo(XmlReader reader, T item) private async Task FetchMediaInfo(XmlReader reader, Video item)
{ {
var video = item as Video; await reader.MoveToContentAsync();
if (video != null) while (await reader.ReadAsync())
{
FetchMediaInfo(reader, video);
}
}
private void FetchMediaInfo(XmlReader reader, Video item)
{
reader.MoveToContent();
while (reader.Read())
{ {
if (reader.NodeType == XmlNodeType.Element) if (reader.NodeType == XmlNodeType.Element)
{ {
@ -323,7 +320,7 @@ namespace MediaBrowser.Controller.Xml
{ {
case "Audio": case "Audio":
{ {
AudioStream stream = FetchMediaInfoAudio(reader.ReadSubtree()); AudioStream stream = await FetchMediaInfoAudio(reader.ReadSubtree());
List<AudioStream> streams = (item.AudioStreams ?? new AudioStream[] { }).ToList(); List<AudioStream> streams = (item.AudioStreams ?? new AudioStream[] { }).ToList();
streams.Add(stream); streams.Add(stream);
@ -333,56 +330,56 @@ namespace MediaBrowser.Controller.Xml
} }
case "Video": case "Video":
FetchMediaInfoVideo(reader.ReadSubtree(), item); await FetchMediaInfoVideo(reader.ReadSubtree(), item);
break; break;
case "Subtitle": case "Subtitle":
FetchMediaInfoSubtitles(reader.ReadSubtree(), item); await FetchMediaInfoSubtitles(reader.ReadSubtree(), item);
break; break;
default: default:
reader.Skip(); await reader.SkipAsync();
break; break;
} }
} }
} }
} }
private AudioStream FetchMediaInfoAudio(XmlReader reader) private async Task<AudioStream> FetchMediaInfoAudio(XmlReader reader)
{ {
AudioStream stream = new AudioStream(); AudioStream stream = new AudioStream();
reader.MoveToContent(); await reader.MoveToContentAsync();
while (reader.Read()) while (await reader.ReadAsync())
{ {
if (reader.NodeType == XmlNodeType.Element) if (reader.NodeType == XmlNodeType.Element)
{ {
switch (reader.Name) switch (reader.Name)
{ {
case "Default": case "Default":
stream.IsDefault = reader.ReadString() == "True"; stream.IsDefault = await reader.ReadElementContentAsStringAsync() == "True";
break; break;
case "Forced": case "Forced":
stream.IsForced = reader.ReadString() == "True"; stream.IsForced = await reader.ReadElementContentAsStringAsync() == "True";
break; break;
case "BitRate": case "BitRate":
stream.BitRate = reader.ReadIntSafe(); stream.BitRate = await reader.ReadIntSafe();
break; break;
case "Channels": case "Channels":
stream.Channels = reader.ReadIntSafe(); stream.Channels = await reader.ReadIntSafe();
break; break;
case "Language": case "Language":
stream.Language = reader.ReadString(); stream.Language = await reader.ReadElementContentAsStringAsync();
break; break;
case "Codec": case "Codec":
{ {
string codec = reader.ReadString(); string codec = await reader.ReadElementContentAsStringAsync();
switch (codec.ToLower()) switch (codec.ToLower())
{ {
@ -430,7 +427,7 @@ namespace MediaBrowser.Controller.Xml
} }
default: default:
reader.Skip(); await reader.SkipAsync();
break; break;
} }
} }
@ -439,42 +436,42 @@ namespace MediaBrowser.Controller.Xml
return stream; return stream;
} }
private void FetchMediaInfoVideo(XmlReader reader, Video item) private async Task FetchMediaInfoVideo(XmlReader reader, Video item)
{ {
reader.MoveToContent(); await reader.MoveToContentAsync();
while (reader.Read()) while (await reader.ReadAsync())
{ {
if (reader.NodeType == XmlNodeType.Element) if (reader.NodeType == XmlNodeType.Element)
{ {
switch (reader.Name) switch (reader.Name)
{ {
case "Width": case "Width":
item.Width = reader.ReadIntSafe(); item.Width = await reader.ReadIntSafe();
break; break;
case "Height": case "Height":
item.Height = reader.ReadIntSafe(); item.Height = await reader.ReadIntSafe();
break; break;
case "BitRate": case "BitRate":
item.BitRate = reader.ReadIntSafe(); item.BitRate = await reader.ReadIntSafe();
break; break;
case "FrameRate": case "FrameRate":
item.FrameRate = reader.ReadString(); item.FrameRate = await reader.ReadElementContentAsStringAsync();
break; break;
case "ScanType": case "ScanType":
item.ScanType = reader.ReadString(); item.ScanType = await reader.ReadElementContentAsStringAsync();
break; break;
case "Duration": case "Duration":
item.RunTimeTicks = TimeSpan.FromMinutes(reader.ReadIntSafe()).Ticks; item.RunTimeTicks = TimeSpan.FromMinutes(await reader.ReadIntSafe()).Ticks;
break; break;
case "DurationSeconds": case "DurationSeconds":
int seconds = reader.ReadIntSafe(); int seconds = await reader.ReadIntSafe();
if (seconds > 0) if (seconds > 0)
{ {
item.RunTimeTicks = TimeSpan.FromSeconds(seconds).Ticks; item.RunTimeTicks = TimeSpan.FromSeconds(seconds).Ticks;
@ -483,7 +480,7 @@ namespace MediaBrowser.Controller.Xml
case "Codec": case "Codec":
{ {
string videoCodec = reader.ReadString(); string videoCodec = await reader.ReadElementContentAsStringAsync();
switch (videoCodec.ToLower()) switch (videoCodec.ToLower())
{ {
@ -505,20 +502,20 @@ namespace MediaBrowser.Controller.Xml
} }
default: default:
reader.Skip(); await reader.SkipAsync();
break; break;
} }
} }
} }
} }
private void FetchMediaInfoSubtitles(XmlReader reader, Video item) private async Task FetchMediaInfoSubtitles(XmlReader reader, Video item)
{ {
List<string> list = (item.Subtitles ?? new string[] { }).ToList(); List<string> list = (item.Subtitles ?? new string[] { }).ToList();
reader.MoveToContent(); await reader.MoveToContentAsync();
while (reader.Read()) while (await reader.ReadAsync())
{ {
if (reader.NodeType == XmlNodeType.Element) if (reader.NodeType == XmlNodeType.Element)
{ {
@ -526,7 +523,7 @@ namespace MediaBrowser.Controller.Xml
{ {
case "Language": case "Language":
{ {
string genre = reader.ReadString(); string genre = await reader.ReadElementContentAsStringAsync();
if (!string.IsNullOrWhiteSpace(genre)) if (!string.IsNullOrWhiteSpace(genre))
{ {
@ -536,7 +533,7 @@ namespace MediaBrowser.Controller.Xml
} }
default: default:
reader.Skip(); await reader.SkipAsync();
break; break;
} }
} }
@ -545,13 +542,13 @@ namespace MediaBrowser.Controller.Xml
item.Subtitles = list; item.Subtitles = list;
} }
private void FetchFromTaglinesNode(XmlReader reader, T item) private async Task FetchFromTaglinesNode(XmlReader reader, T item)
{ {
List<string> list = (item.Taglines ?? new string[] { }).ToList(); List<string> list = (item.Taglines ?? new string[] { }).ToList();
reader.MoveToContent(); await reader.MoveToContentAsync();
while (reader.Read()) while (await reader.ReadAsync())
{ {
if (reader.NodeType == XmlNodeType.Element) if (reader.NodeType == XmlNodeType.Element)
{ {
@ -559,7 +556,7 @@ namespace MediaBrowser.Controller.Xml
{ {
case "Tagline": case "Tagline":
{ {
string val = reader.ReadString(); string val = await reader.ReadElementContentAsStringAsync();
if (!string.IsNullOrWhiteSpace(val)) if (!string.IsNullOrWhiteSpace(val))
{ {
@ -569,7 +566,7 @@ namespace MediaBrowser.Controller.Xml
} }
default: default:
reader.Skip(); await reader.SkipAsync();
break; break;
} }
} }
@ -578,13 +575,13 @@ namespace MediaBrowser.Controller.Xml
item.Taglines = list; item.Taglines = list;
} }
private void FetchFromGenresNode(XmlReader reader, T item) private async Task FetchFromGenresNode(XmlReader reader, T item)
{ {
List<string> list = (item.Genres ?? new string[] { }).ToList(); List<string> list = (item.Genres ?? new string[] { }).ToList();
reader.MoveToContent(); await reader.MoveToContentAsync();
while (reader.Read()) while (await reader.ReadAsync())
{ {
if (reader.NodeType == XmlNodeType.Element) if (reader.NodeType == XmlNodeType.Element)
{ {
@ -592,7 +589,7 @@ namespace MediaBrowser.Controller.Xml
{ {
case "Genre": case "Genre":
{ {
string genre = reader.ReadString(); string genre = await reader.ReadElementContentAsStringAsync();
if (!string.IsNullOrWhiteSpace(genre)) if (!string.IsNullOrWhiteSpace(genre))
{ {
@ -602,7 +599,7 @@ namespace MediaBrowser.Controller.Xml
} }
default: default:
reader.Skip(); await reader.SkipAsync();
break; break;
} }
} }
@ -611,13 +608,13 @@ namespace MediaBrowser.Controller.Xml
item.Genres = list; item.Genres = list;
} }
private void FetchDataFromPersonsNode(XmlReader reader, T item) private async Task FetchDataFromPersonsNode(XmlReader reader, T item)
{ {
List<PersonInfo> list = (item.People ?? new PersonInfo[] { }).ToList(); List<PersonInfo> list = (item.People ?? new PersonInfo[] { }).ToList();
reader.MoveToContent(); await reader.MoveToContentAsync();
while (reader.Read()) while (await reader.ReadAsync())
{ {
if (reader.NodeType == XmlNodeType.Element) if (reader.NodeType == XmlNodeType.Element)
{ {
@ -625,12 +622,12 @@ namespace MediaBrowser.Controller.Xml
{ {
case "Person": case "Person":
{ {
list.Add(GetPersonFromXmlNode(reader.ReadSubtree())); list.Add(await GetPersonFromXmlNode(reader.ReadSubtree()));
break; break;
} }
default: default:
reader.Skip(); await reader.SkipAsync();
break; break;
} }
} }
@ -639,13 +636,13 @@ namespace MediaBrowser.Controller.Xml
item.People = list; item.People = list;
} }
private void FetchFromStudiosNode(XmlReader reader, T item) private async Task FetchFromStudiosNode(XmlReader reader, T item)
{ {
List<string> list = (item.Studios ?? new string[] { }).ToList(); List<string> list = (item.Studios ?? new string[] { }).ToList();
reader.MoveToContent(); await reader.MoveToContentAsync();
while (reader.Read()) while (await reader.ReadAsync())
{ {
if (reader.NodeType == XmlNodeType.Element) if (reader.NodeType == XmlNodeType.Element)
{ {
@ -653,7 +650,7 @@ namespace MediaBrowser.Controller.Xml
{ {
case "Studio": case "Studio":
{ {
string studio = reader.ReadString(); string studio = await reader.ReadElementContentAsStringAsync();
if (!string.IsNullOrWhiteSpace(studio)) if (!string.IsNullOrWhiteSpace(studio))
{ {
@ -663,7 +660,7 @@ namespace MediaBrowser.Controller.Xml
} }
default: default:
reader.Skip(); await reader.SkipAsync();
break; break;
} }
} }
@ -672,11 +669,11 @@ namespace MediaBrowser.Controller.Xml
item.Studios = list; item.Studios = list;
} }
private void FetchFromParentalRatingNode(XmlReader reader, T item) private async Task FetchFromParentalRatingNode(XmlReader reader, T item)
{ {
reader.MoveToContent(); await reader.MoveToContentAsync();
while (reader.Read()) while (await reader.ReadAsync())
{ {
if (reader.NodeType == XmlNodeType.Element) if (reader.NodeType == XmlNodeType.Element)
{ {
@ -684,7 +681,7 @@ namespace MediaBrowser.Controller.Xml
{ {
case "Value": case "Value":
{ {
string ratingString = reader.ReadString(); string ratingString = await reader.ReadElementContentAsStringAsync();
int rating = 7; int rating = 7;
@ -723,39 +720,39 @@ namespace MediaBrowser.Controller.Xml
} }
default: default:
reader.Skip(); await reader.SkipAsync();
break; break;
} }
} }
} }
} }
private PersonInfo GetPersonFromXmlNode(XmlReader reader) private async Task<PersonInfo> GetPersonFromXmlNode(XmlReader reader)
{ {
PersonInfo person = new PersonInfo(); PersonInfo person = new PersonInfo();
reader.MoveToContent(); await reader.MoveToContentAsync();
while (reader.Read()) while (await reader.ReadAsync())
{ {
if (reader.NodeType == XmlNodeType.Element) if (reader.NodeType == XmlNodeType.Element)
{ {
switch (reader.Name) switch (reader.Name)
{ {
case "Name": case "Name":
person.Name = reader.ReadString(); person.Name = await reader.ReadElementContentAsStringAsync();
break; break;
case "Type": case "Type":
person.Type = reader.ReadString(); person.Type = await reader.ReadElementContentAsStringAsync();
break; break;
case "Role": case "Role":
person.Overview = reader.ReadString(); person.Overview = await reader.ReadElementContentAsStringAsync();
break; break;
default: default:
reader.Skip(); await reader.SkipAsync();
break; break;
} }
} }

View File

@ -1,4 +1,5 @@
using System.Globalization; using System.Globalization;
using System.Threading.Tasks;
using System.Xml; using System.Xml;
namespace MediaBrowser.Controller.Xml namespace MediaBrowser.Controller.Xml
@ -10,9 +11,9 @@ namespace MediaBrowser.Controller.Xml
/// <summary> /// <summary>
/// Reads a float from the current element of an XmlReader /// Reads a float from the current element of an XmlReader
/// </summary> /// </summary>
public static float ReadFloatSafe(this XmlReader reader) public static async Task<float> ReadFloatSafe(this XmlReader reader)
{ {
string valueString = reader.ReadElementContentAsString(); string valueString = await reader.ReadElementContentAsStringAsync();
float value = 0; float value = 0;
@ -28,9 +29,9 @@ namespace MediaBrowser.Controller.Xml
/// <summary> /// <summary>
/// Reads an int from the current element of an XmlReader /// Reads an int from the current element of an XmlReader
/// </summary> /// </summary>
public static int ReadIntSafe(this XmlReader reader) public static async Task<int> ReadIntSafe(this XmlReader reader)
{ {
string valueString = reader.ReadElementContentAsString(); string valueString = await reader.ReadElementContentAsStringAsync();
int value = 0; int value = 0;
@ -42,13 +43,5 @@ namespace MediaBrowser.Controller.Xml
return value; return value;
} }
/// <summary>
/// Reads an int from the current element of an XmlReader
/// </summary>
public static string ReadString(this XmlReader reader)
{
return reader.ReadElementContentAsString();
}
} }
} }

View File

@ -16,6 +16,11 @@ namespace MediaBrowser.Movies.Providers
return item is Movie; return item is Movie;
} }
public override MetadataProviderPriority Priority
{
get { return MetadataProviderPriority.First; }
}
public async override Task Fetch(BaseEntity item, ItemResolveEventArgs args) public async override Task Fetch(BaseEntity item, ItemResolveEventArgs args)
{ {
var metadataFile = args.GetFileByName("movie.xml"); var metadataFile = args.GetFileByName("movie.xml");

View File

@ -1,4 +1,5 @@
using System.IO; using System.IO;
using System.Threading.Tasks;
using System.Xml; using System.Xml;
using MediaBrowser.Controller.Xml; using MediaBrowser.Controller.Xml;
using MediaBrowser.TV.Entities; using MediaBrowser.TV.Entities;
@ -7,13 +8,13 @@ namespace MediaBrowser.TV.Metadata
{ {
public class EpisodeXmlParser : BaseItemXmlParser<Episode> public class EpisodeXmlParser : BaseItemXmlParser<Episode>
{ {
protected override void FetchDataFromXmlNode(XmlReader reader, Episode item) protected override async Task FetchDataFromXmlNode(XmlReader reader, Episode item)
{ {
switch (reader.Name) switch (reader.Name)
{ {
case "filename": case "filename":
{ {
string filename = reader.ReadString(); string filename = await reader.ReadElementContentAsStringAsync();
if (!string.IsNullOrWhiteSpace(filename)) if (!string.IsNullOrWhiteSpace(filename))
{ {
@ -24,7 +25,7 @@ namespace MediaBrowser.TV.Metadata
} }
case "SeasonNumber": case "SeasonNumber":
{ {
string number = reader.ReadString(); string number = await reader.ReadElementContentAsStringAsync();
if (!string.IsNullOrWhiteSpace(number)) if (!string.IsNullOrWhiteSpace(number))
{ {
@ -35,7 +36,7 @@ namespace MediaBrowser.TV.Metadata
case "EpisodeNumber": case "EpisodeNumber":
{ {
string number = reader.ReadString(); string number = await reader.ReadElementContentAsStringAsync();
if (!string.IsNullOrWhiteSpace(number)) if (!string.IsNullOrWhiteSpace(number))
{ {
@ -45,11 +46,11 @@ namespace MediaBrowser.TV.Metadata
} }
case "EpisodeName": case "EpisodeName":
item.Name = reader.ReadString(); item.Name = await reader.ReadElementContentAsStringAsync();
break; break;
default: default:
base.FetchDataFromXmlNode(reader, item); await base.FetchDataFromXmlNode(reader, item);
break; break;
} }
} }

View File

@ -1,4 +1,5 @@
using System; using System;
using System.Threading.Tasks;
using System.Xml; using System.Xml;
using MediaBrowser.Controller.Xml; using MediaBrowser.Controller.Xml;
using MediaBrowser.Model.Entities; using MediaBrowser.Model.Entities;
@ -8,12 +9,12 @@ namespace MediaBrowser.TV.Metadata
{ {
public class SeriesXmlParser : BaseItemXmlParser<Series> public class SeriesXmlParser : BaseItemXmlParser<Series>
{ {
protected override void FetchDataFromXmlNode(XmlReader reader, Series item) protected async override Task FetchDataFromXmlNode(XmlReader reader, Series item)
{ {
switch (reader.Name) switch (reader.Name)
{ {
case "id": case "id":
string id = reader.ReadString(); string id = await reader.ReadElementContentAsStringAsync();
if (!string.IsNullOrWhiteSpace(id)) if (!string.IsNullOrWhiteSpace(id))
{ {
item.SetProviderId(MetadataProviders.Tvdb, id); item.SetProviderId(MetadataProviders.Tvdb, id);
@ -22,7 +23,7 @@ namespace MediaBrowser.TV.Metadata
case "Airs_DayOfWeek": case "Airs_DayOfWeek":
{ {
string day = reader.ReadString(); string day = await reader.ReadElementContentAsStringAsync();
if (!string.IsNullOrWhiteSpace(day)) if (!string.IsNullOrWhiteSpace(day))
{ {
@ -50,19 +51,19 @@ namespace MediaBrowser.TV.Metadata
} }
case "Airs_Time": case "Airs_Time":
item.AirTime = reader.ReadString(); item.AirTime = await reader.ReadElementContentAsStringAsync();
break; break;
case "SeriesName": case "SeriesName":
item.Name = reader.ReadString(); item.Name = await reader.ReadElementContentAsStringAsync();
break; break;
case "Status": case "Status":
item.Status = reader.ReadString(); item.Status = await reader.ReadElementContentAsStringAsync();
break; break;
default: default:
base.FetchDataFromXmlNode(reader, item); await base.FetchDataFromXmlNode(reader, item);
break; break;
} }
} }

View File

@ -18,6 +18,11 @@ namespace MediaBrowser.TV.Providers
return item is Episode; return item is Episode;
} }
public override MetadataProviderPriority Priority
{
get { return MetadataProviderPriority.First; }
}
public override Task Fetch(BaseEntity item, ItemResolveEventArgs args) public override Task Fetch(BaseEntity item, ItemResolveEventArgs args)
{ {
return Task.Run(() => return Task.Run(() =>

View File

@ -19,6 +19,11 @@ namespace MediaBrowser.TV.Providers
return item is Episode; return item is Episode;
} }
public override MetadataProviderPriority Priority
{
get { return MetadataProviderPriority.First; }
}
public async override Task Fetch(BaseEntity item, ItemResolveEventArgs args) public async override Task Fetch(BaseEntity item, ItemResolveEventArgs args)
{ {
string metadataFolder = Path.Combine(args.Parent.Path, "metadata"); string metadataFolder = Path.Combine(args.Parent.Path, "metadata");

View File

@ -16,6 +16,11 @@ namespace MediaBrowser.TV.Providers
return item is Series; return item is Series;
} }
public override MetadataProviderPriority Priority
{
get { return MetadataProviderPriority.First; }
}
public async override Task Fetch(BaseEntity item, ItemResolveEventArgs args) public async override Task Fetch(BaseEntity item, ItemResolveEventArgs args)
{ {
var metadataFile = args.GetFileByName("series.xml"); var metadataFile = args.GetFileByName("series.xml");