Cutlery/jellyfin
1
0
Fork 0
mirror of https://github.com/jellyfin/jellyfin.git synced 2025-07-09 03:04:24 -04:00
Code Issues Packages Projects Releases Wiki Activity

Implement discovery respecting bind addresses

Browse Source
This commit is contained in:
Shadowghost 2022-07-21 09:42:45 +02:00
parent f6e41269d9
commit b01d169d28
2 changed files with 20 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

20
Emby.Server.Implementations/EntryPoints/UdpServerEntryPoint.cs
View File

@ -5,6 +5,7 @@ using System.Threading.Tasks;
using Emby.Server.Implementations.Udp; using Emby.Server.Implementations.Udp;
using Jellyfin.Networking.Configuration; using Jellyfin.Networking.Configuration;
using MediaBrowser.Common.Configuration; using MediaBrowser.Common.Configuration;
using MediaBrowser.Common.Net;
using MediaBrowser.Controller; using MediaBrowser.Controller;
using MediaBrowser.Controller.Plugins; using MediaBrowser.Controller.Plugins;
using Microsoft.Extensions.Configuration; using Microsoft.Extensions.Configuration;
@ -29,6 +30,7 @@ namespace Emby.Server.Implementations.EntryPoints
private readonly IServerApplicationHost _appHost; private readonly IServerApplicationHost _appHost;
private readonly IConfiguration _config; private readonly IConfiguration _config;
private readonly IConfigurationManager _configurationManager; private readonly IConfigurationManager _configurationManager;
private readonly INetworkManager _networkManager;
/// <summary> /// <summary>
/// The UDP server. /// The UDP server.
@ -44,16 +46,19 @@ namespace Emby.Server.Implementations.EntryPoints
/// <param name="appHost">Instance of the <see cref="IServerApplicationHost"/> interface.</param> /// <param name="appHost">Instance of the <see cref="IServerApplicationHost"/> interface.</param>
/// <param name="configuration">Instance of the <see cref="IConfiguration"/> interface.</param> /// <param name="configuration">Instance of the <see cref="IConfiguration"/> interface.</param>
/// <param name="configurationManager">Instance of the <see cref="IConfigurationManager"/> interface.</param> /// <param name="configurationManager">Instance of the <see cref="IConfigurationManager"/> interface.</param>
/// <param name="networkManager">Instance of the <see cref="INetworkManager"/> interface.</param>
public UdpServerEntryPoint( public UdpServerEntryPoint(
ILogger<UdpServerEntryPoint> logger, ILogger<UdpServerEntryPoint> logger,
IServerApplicationHost appHost, IServerApplicationHost appHost,
IConfiguration configuration, IConfiguration configuration,
IConfigurationManager configurationManager) IConfigurationManager configurationManager,
INetworkManager networkManager)
{ {
_logger = logger; _logger = logger;
_appHost = appHost; _appHost = appHost;
_config = configuration; _config = configuration;
_configurationManager = configurationManager; _configurationManager = configurationManager;
_networkManager = networkManager;
} }
/// <inheritdoc /> /// <inheritdoc />
@ -68,8 +73,17 @@ namespace Emby.Server.Implementations.EntryPoints
try try
{ {
_udpServer = new UdpServer(_logger, _appHost, _config, PortNumber); foreach (var bindAddress in _networkManager.GetInternalBindAddresses())
_udpServer.Start(_cancellationTokenSource.Token); {
if (bindAddress.AddressFamily == AddressFamily.InterNetworkV6)
{
// Not supporting IPv6 right now
continue;
}
_udpServer = new UdpServer(_logger, _appHost, _config, bindAddress.Address, PortNumber);
_udpServer.Start(_cancellationTokenSource.Token);
}
} }
catch (SocketException ex) catch (SocketException ex)
{ {

4
Emby.Server.Implementations/Udp/UdpServer.cs
View File

@ -37,18 +37,20 @@ namespace Emby.Server.Implementations.Udp
/// <param name="logger">The logger.</param> /// <param name="logger">The logger.</param>
/// <param name="appHost">The application host.</param> /// <param name="appHost">The application host.</param>
/// <param name="configuration">The configuration manager.</param> /// <param name="configuration">The configuration manager.</param>
/// <param name="bindAddress"> The bind address.</param>
/// <param name="port">The port.</param> /// <param name="port">The port.</param>
public UdpServer( public UdpServer(
ILogger logger, ILogger logger,
IServerApplicationHost appHost, IServerApplicationHost appHost,
IConfiguration configuration, IConfiguration configuration,
IPAddress bindAddress,
int port) int port)
{ {
_logger = logger; _logger = logger;
_appHost = appHost; _appHost = appHost;
_config = configuration; _config = configuration;
_endpoint = new IPEndPoint(IPAddress.Any, port); _endpoint = new IPEndPoint(bindAddress, port);
_udpSocket = new Socket(AddressFamily.InterNetwork, SocketType.Dgram, ProtocolType.Udp); _udpSocket = new Socket(AddressFamily.InterNetwork, SocketType.Dgram, ProtocolType.Udp);
_udpSocket.SetSocketOption(SocketOptionLevel.Socket, SocketOptionName.ReuseAddress, true); _udpSocket.SetSocketOption(SocketOptionLevel.Socket, SocketOptionName.ReuseAddress, true);