Cutlery/jellyfin
1
0
Fork 0
mirror of https://github.com/jellyfin/jellyfin.git synced 2025-07-09 03:04:24 -04:00
Code Issues Packages Projects Releases Wiki Activity

Gracefully handle exceptions in IEventConsumers

Browse Source
This commit is contained in:
Patrick Barron 2020-08-15 18:36:37 -04:00
parent dc88e93504
commit b2f734efd1
1 changed files with 13 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
Jellyfin.Server.Implementations/Events/EventManager.cs
View File

@ -3,6 +3,7 @@ using System.Threading.Tasks;
using MediaBrowser.Controller; using MediaBrowser.Controller;
using MediaBrowser.Controller.Events; using MediaBrowser.Controller.Events;
using Microsoft.Extensions.DependencyInjection; using Microsoft.Extensions.DependencyInjection;
using Microsoft.Extensions.Logging;
namespace Jellyfin.Server.Implementations.Events namespace Jellyfin.Server.Implementations.Events
{ {
@ -11,14 +12,17 @@ namespace Jellyfin.Server.Implementations.Events
/// </summary> /// </summary>
public class EventManager : IEventManager public class EventManager : IEventManager
{ {
private readonly ILogger<EventManager> _logger;
private readonly IServerApplicationHost _appHost; private readonly IServerApplicationHost _appHost;
/// <summary> /// <summary>
/// Initializes a new instance of the <see cref="EventManager"/> class. /// Initializes a new instance of the <see cref="EventManager"/> class.
/// </summary> /// </summary>
/// <param name="logger">The logger.</param>
/// <param name="appHost">The application host.</param> /// <param name="appHost">The application host.</param>
public EventManager(IServerApplicationHost appHost) public EventManager(ILogger<EventManager> logger, IServerApplicationHost appHost)
{ {
_logger = logger;
_appHost = appHost; _appHost = appHost;
} }
@ -42,7 +46,14 @@ namespace Jellyfin.Server.Implementations.Events
using var scope = _appHost.ServiceProvider.CreateScope(); using var scope = _appHost.ServiceProvider.CreateScope();
foreach (var service in scope.ServiceProvider.GetServices<IEventConsumer<T>>()) foreach (var service in scope.ServiceProvider.GetServices<IEventConsumer<T>>())
{ {
await service.OnEvent(eventArgs).ConfigureAwait(false); try
{
await service.OnEvent(eventArgs).ConfigureAwait(false);
}
catch (Exception e)
{
_logger.LogError(e, "Uncaught exception in EventConsumer {type}: ", service.GetType());
}
} }
} }
} }