clean up authorization handlers

This commit is contained in:
crobibero 2020-10-14 17:58:46 -06:00
parent 39924f9992
commit c037d3536d
3 changed files with 13 additions and 9 deletions

View File

@ -29,13 +29,15 @@ namespace Jellyfin.Api.Auth.DefaultAuthorizationPolicy
protected override Task HandleRequirementAsync(AuthorizationHandlerContext context, DefaultAuthorizationRequirement requirement) protected override Task HandleRequirementAsync(AuthorizationHandlerContext context, DefaultAuthorizationRequirement requirement)
{ {
var validated = ValidateClaims(context.User); var validated = ValidateClaims(context.User);
if (!validated) if (validated)
{
context.Succeed(requirement);
}
else
{ {
context.Fail(); context.Fail();
return Task.CompletedTask;
} }
context.Succeed(requirement);
return Task.CompletedTask; return Task.CompletedTask;
} }
} }

View File

@ -29,13 +29,15 @@ namespace Jellyfin.Api.Auth.IgnoreParentalControlPolicy
protected override Task HandleRequirementAsync(AuthorizationHandlerContext context, IgnoreParentalControlRequirement requirement) protected override Task HandleRequirementAsync(AuthorizationHandlerContext context, IgnoreParentalControlRequirement requirement)
{ {
var validated = ValidateClaims(context.User, ignoreSchedule: true); var validated = ValidateClaims(context.User, ignoreSchedule: true);
if (!validated) if (validated)
{
context.Succeed(requirement);
}
else
{ {
context.Fail(); context.Fail();
return Task.CompletedTask;
} }
context.Succeed(requirement);
return Task.CompletedTask; return Task.CompletedTask;
} }
} }

View File

@ -29,13 +29,13 @@ namespace Jellyfin.Api.Auth.LocalAccessPolicy
protected override Task HandleRequirementAsync(AuthorizationHandlerContext context, LocalAccessRequirement requirement) protected override Task HandleRequirementAsync(AuthorizationHandlerContext context, LocalAccessRequirement requirement)
{ {
var validated = ValidateClaims(context.User, localAccessOnly: true); var validated = ValidateClaims(context.User, localAccessOnly: true);
if (!validated) if (validated)
{ {
context.Fail(); context.Succeed(requirement);
} }
else else
{ {
context.Succeed(requirement); context.Fail();
} }
return Task.CompletedTask; return Task.CompletedTask;