diff --git a/Emby.Server.Implementations/Library/PathExtensions.cs b/Emby.Server.Implementations/Library/PathExtensions.cs
index b74cad067b..06ff3e611b 100644
--- a/Emby.Server.Implementations/Library/PathExtensions.cs
+++ b/Emby.Server.Implementations/Library/PathExtensions.cs
@@ -16,7 +16,7 @@ namespace Emby.Server.Implementations.Library
/// The STR.
/// The attrib.
/// System.String.
- /// str or attribute is empty.
+ /// or is empty.
public static string? GetAttributeValue(this string str, string attribute)
{
if (str.Length == 0)
diff --git a/MediaBrowser.Common/Extensions/StringExtensions.cs b/MediaBrowser.Common/Extensions/StringExtensions.cs
index 2ac29f8e52..7643017412 100644
--- a/MediaBrowser.Common/Extensions/StringExtensions.cs
+++ b/MediaBrowser.Common/Extensions/StringExtensions.cs
@@ -10,28 +10,28 @@ namespace MediaBrowser.Common.Extensions
public static class StringExtensions
{
///
- /// Returns the part left of the needle.
+ /// Returns the part on the left of the needle.
///
- /// The string to seek.
+ /// The string to seek.
/// The needle to find.
- /// The part left of the needle.
- public static ReadOnlySpan LeftPart(this ReadOnlySpan str, char needle)
+ /// The part left of the .
+ public static ReadOnlySpan LeftPart(this ReadOnlySpan haystack, char needle)
{
- var pos = str.IndexOf(needle);
- return pos == -1 ? str : str[..pos];
+ var pos = haystack.IndexOf(needle);
+ return pos == -1 ? haystack : haystack[..pos];
}
///
- /// Returns the part left of the needle.
+ /// Returns the part on the left of the needle.
///
- /// The string to seek.
+ /// The string to seek.
/// The needle to find.
/// One of the enumeration values that specifies the rules for the search.
/// The part left of the needle.
- public static ReadOnlySpan LeftPart(this ReadOnlySpan str, ReadOnlySpan needle, StringComparison stringComparison = default)
+ public static ReadOnlySpan LeftPart(this ReadOnlySpan haystack, ReadOnlySpan needle, StringComparison stringComparison = default)
{
- var pos = str.IndexOf(needle, stringComparison);
- return pos == -1 ? str : str[..pos];
+ var pos = haystack.IndexOf(needle, stringComparison);
+ return pos == -1 ? haystack : haystack[..pos];
}
}
}
diff --git a/tests/Jellyfin.Common.Tests/Extensions/StringExtensionsTests.cs b/tests/Jellyfin.Common.Tests/Extensions/StringExtensionsTests.cs
index 0ed7673fdb..8bf613f05f 100644
--- a/tests/Jellyfin.Common.Tests/Extensions/StringExtensionsTests.cs
+++ b/tests/Jellyfin.Common.Tests/Extensions/StringExtensionsTests.cs
@@ -7,29 +7,37 @@ namespace Jellyfin.Common.Tests.Extensions
public class StringExtensionsTests
{
[Theory]
+ [InlineData("", 'q', "")]
[InlineData("Banana split", ' ', "Banana")]
[InlineData("Banana split", 'q', "Banana split")]
- public void LeftPart_ValidArgsCharNeedle_Correct(string str, char needle, string result)
+ public void LeftPart_ValidArgsCharNeedle_Correct(string str, char needle, string expectedResult)
{
- Assert.Equal(result, str.AsSpan().LeftPart(needle).ToString());
+ var result = str.AsSpan().LeftPart(needle).ToString();
+ Assert.Equal(expectedResult, result);
}
[Theory]
+ [InlineData("", "", "")]
+ [InlineData("", "q", "")]
+ [InlineData("Banana split", "", "")]
[InlineData("Banana split", " ", "Banana")]
[InlineData("Banana split test", " split", "Banana")]
- public void LeftPart_ValidArgsWithoutStringComparison_Correct(string str, string needle, string result)
+ public void LeftPart_ValidArgsWithoutStringComparison_Correct(string str, string needle, string expectedResult)
{
- Assert.Equal(result, str.AsSpan().LeftPart(needle).ToString());
+ var result = str.AsSpan().LeftPart(needle).ToString();
+ Assert.Equal(expectedResult, result);
}
[Theory]
+ [InlineData("", "", StringComparison.Ordinal, "")]
[InlineData("Banana split", " ", StringComparison.Ordinal, "Banana")]
[InlineData("Banana split test", " split", StringComparison.Ordinal, "Banana")]
[InlineData("Banana split test", " Split", StringComparison.Ordinal, "Banana split test")]
[InlineData("Banana split test", " Splït", StringComparison.InvariantCultureIgnoreCase, "Banana split test")]
- public void LeftPart_ValidArgs_Correct(string str, string needle, StringComparison stringComparison, string result)
+ public void LeftPart_ValidArgs_Correct(string str, string needle, StringComparison stringComparison, string expectedResult)
{
- Assert.Equal(result, str.AsSpan().LeftPart(needle, stringComparison).ToString());
+ var result = str.AsSpan().LeftPart(needle, stringComparison).ToString();
+ Assert.Equal(expectedResult, result);
}
}
}
diff --git a/tests/Jellyfin.Server.Implementations.Tests/Library/PathExtensionsTests.cs b/tests/Jellyfin.Server.Implementations.Tests/Library/PathExtensionsTests.cs
index d2ed0d9257..c771f5f4ae 100644
--- a/tests/Jellyfin.Server.Implementations.Tests/Library/PathExtensionsTests.cs
+++ b/tests/Jellyfin.Server.Implementations.Tests/Library/PathExtensionsTests.cs
@@ -10,9 +10,9 @@ namespace Jellyfin.Server.Implementations.Tests.Library
[InlineData("Superman: Red Son [imdbid=tt10985510]", "imdbid", "tt10985510")]
[InlineData("Superman: Red Son - tt10985510", "imdbid", "tt10985510")]
[InlineData("Superman: Red Son", "imdbid", null)]
- public void GetAttributeValue_ValidArgs_Correct(string input, string attribute, string? result)
+ public void GetAttributeValue_ValidArgs_Correct(string input, string attribute, string? expectedResult)
{
- Assert.Equal(result, PathExtensions.GetAttributeValue(input, attribute));
+ Assert.Equal(expectedResult, PathExtensions.GetAttributeValue(input, attribute));
}
[Theory]