Cutlery/jellyfin
1
0
Fork 0
mirror of https://github.com/jellyfin/jellyfin.git synced 2025-07-09 03:04:24 -04:00
Code Issues Packages Projects Releases Wiki Activity

fix openapi auth

Browse Source
This commit is contained in:
cvium 2023-02-09 14:56:53 +01:00
parent b5d5667965
commit cba9657aec
1 changed files with 44 additions and 31 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

25
Jellyfin.Server/Filters/SecurityRequirementsOperationFilter.cs
View File

@ -18,11 +18,17 @@ namespace Jellyfin.Server.Filters
{ {
var requiredScopes = new List<string>(); var requiredScopes = new List<string>();
var requiresAuth = false;
// Add all method scopes. // Add all method scopes.
foreach (var attribute in context.MethodInfo.GetCustomAttributes(true)) foreach (var attribute in context.MethodInfo.GetCustomAttributes(true))
{ {
if (attribute is AuthorizeAttribute authorizeAttribute if (attribute is not AuthorizeAttribute authorizeAttribute)
&& authorizeAttribute.Policy is not null {
continue;
}
requiresAuth = true;
if (authorizeAttribute.Policy is not null
&& !requiredScopes.Contains(authorizeAttribute.Policy, StringComparer.Ordinal)) && !requiredScopes.Contains(authorizeAttribute.Policy, StringComparer.Ordinal))
{ {
requiredScopes.Add(authorizeAttribute.Policy); requiredScopes.Add(authorizeAttribute.Policy);
@ -35,8 +41,13 @@ namespace Jellyfin.Server.Filters
{ {
foreach (var attribute in controllerAttributes) foreach (var attribute in controllerAttributes)
{ {
if (attribute is AuthorizeAttribute authorizeAttribute if (attribute is not AuthorizeAttribute authorizeAttribute)
&& authorizeAttribute.Policy is not null {
continue;
}
requiresAuth = true;
if (authorizeAttribute.Policy is not null
&& !requiredScopes.Contains(authorizeAttribute.Policy, StringComparer.Ordinal)) && !requiredScopes.Contains(authorizeAttribute.Policy, StringComparer.Ordinal))
{ {
requiredScopes.Add(authorizeAttribute.Policy); requiredScopes.Add(authorizeAttribute.Policy);
@ -44,8 +55,11 @@ namespace Jellyfin.Server.Filters
} }
} }
if (requiredScopes.Count != 0) if (!requiresAuth)
{ {
return;
}
if (!operation.Responses.ContainsKey("401")) if (!operation.Responses.ContainsKey("401"))
{ {
operation.Responses.Add("401", new OpenApiResponse { Description = "Unauthorized" }); operation.Responses.Add("401", new OpenApiResponse { Description = "Unauthorized" });
@ -74,5 +88,4 @@ namespace Jellyfin.Server.Filters
}; };
} }
} }
}
} }