Cutlery/jellyfin
1
0
Fork 0
mirror of https://github.com/jellyfin/jellyfin.git synced 2025-07-09 03:04:24 -04:00
Code Issues Packages Projects Releases Wiki Activity

Fix ffprobe -user_agent parameter

Browse Source 
The PR #10448 was doing it wrong and actually did not work. Even its unit testing was testing for a wrong output.

Signed-off-by: gnattu <gnattuoc@me.com>
This commit is contained in:
gnattu 2024-05-28 03:18:46 +08:00
parent 730b01fb14
commit d07ec4ad0f
2 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
MediaBrowser.MediaEncoding/Encoder/MediaEncoder.cs
View File

@ -456,9 +456,9 @@ namespace MediaBrowser.MediaEncoding.Encoder
extraArgs += " -probesize " + ffmpegProbeSize; extraArgs += " -probesize " + ffmpegProbeSize;
} }
if (request.MediaSource.RequiredHttpHeaders.TryGetValue("user_agent", out var userAgent)) if (request.MediaSource.RequiredHttpHeaders.TryGetValue("User-Agent", out var userAgent))
{ {
extraArgs += " -user_agent " + userAgent; extraArgs += $" -user_agent \"{userAgent}\"";
} }
if (request.MediaSource.Protocol == MediaProtocol.Rtsp) if (request.MediaSource.Protocol == MediaProtocol.Rtsp)

4
tests/Jellyfin.MediaEncoding.Tests/Probing/ProbeExternalSourcesTests.cs
View File

@ -35,7 +35,7 @@ namespace Jellyfin.MediaEncoding.Tests.Probing
Protocol = MediaProtocol.Http, Protocol = MediaProtocol.Http,
RequiredHttpHeaders = new Dictionary<string, string>() RequiredHttpHeaders = new Dictionary<string, string>()
{ {
{ "user_agent", userAgent }, { "User-Agent", userAgent },
} }
}, },
ExtractChapters = false, ExtractChapters = false,
@ -44,7 +44,7 @@ namespace Jellyfin.MediaEncoding.Tests.Probing
var extraArg = encoder.GetExtraArguments(req); var extraArg = encoder.GetExtraArguments(req);
Assert.Contains(userAgent, extraArg, StringComparison.InvariantCulture); Assert.Contains($"-user_agent \"{userAgent}\"", extraArg, StringComparison.InvariantCulture);
} }
} }
} }