Cutlery/jellyfin
1
0
Fork 0
mirror of https://github.com/jellyfin/jellyfin.git synced 2025-05-31 04:05:50 -04:00
Code Issues Packages Projects Releases Wiki Activity

Applied review comments

Browse Source
This commit is contained in:
JPVenson 2025-01-11 18:13:16 +00:00
parent dcfbf55794
commit d716a53ec2
2 changed files with 4 additions and 16 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
Jellyfin.Server.Implementations/Item/BaseItemRepository.cs
View File

@ -41,8 +41,8 @@ using BaseItemEntity = Jellyfin.Data.Entities.BaseItemEntity;
namespace Jellyfin.Server.Implementations.Item; namespace Jellyfin.Server.Implementations.Item;
/* /*
All queries in this class and all other nullable enabled EFCore repository classes will make libraral use of the null-forgiving operator "!". All queries in this class and all other nullable enabled EFCore repository classes will make liberal use of the null-forgiving operator "!".
This is done as the code isn't actually executed client side, but only the expressions are interpretet and the compiler cannot know that. This is done as the code isn't actually executed client side, but only the expressions are interpret and the compiler cannot know that.
This is your only warning/message regarding this topic. This is your only warning/message regarding this topic.
*/ */
@ -50,7 +50,7 @@ namespace Jellyfin.Server.Implementations.Item;
/// Handles all storage logic for BaseItems. /// Handles all storage logic for BaseItems.
/// </summary> /// </summary>
public sealed class BaseItemRepository public sealed class BaseItemRepository
: IItemRepository, IDisposable : IItemRepository
{ {
/// <summary> /// <summary>
/// This holds all the types in the running assemblies /// This holds all the types in the running assemblies
@ -62,7 +62,6 @@ public sealed class BaseItemRepository
private readonly IItemTypeLookup _itemTypeLookup; private readonly IItemTypeLookup _itemTypeLookup;
private readonly IServerConfigurationManager _serverConfigurationManager; private readonly IServerConfigurationManager _serverConfigurationManager;
private readonly ILogger<BaseItemRepository> _logger; private readonly ILogger<BaseItemRepository> _logger;
private bool _disposed;
private static readonly IReadOnlyList<ItemValueType> _getAllArtistsValueTypes = [ItemValueType.Artist, ItemValueType.AlbumArtist]; private static readonly IReadOnlyList<ItemValueType> _getAllArtistsValueTypes = [ItemValueType.Artist, ItemValueType.AlbumArtist];
private static readonly IReadOnlyList<ItemValueType> _getArtistValueTypes = [ItemValueType.Artist]; private static readonly IReadOnlyList<ItemValueType> _getArtistValueTypes = [ItemValueType.Artist];
@ -92,17 +91,6 @@ public sealed class BaseItemRepository
_logger = logger; _logger = logger;
} }
/// <inheritdoc/>
public void Dispose()
{
if (_disposed)
{
return;
}
_disposed = true;
}
/// <inheritdoc /> /// <inheritdoc />
public void DeleteItem(Guid id) public void DeleteItem(Guid id)
{ {

2
MediaBrowser.Controller/Persistence/IItemRepository.cs
View File

@ -14,7 +14,7 @@ namespace MediaBrowser.Controller.Persistence;
/// <summary> /// <summary>
/// Provides an interface to implement an Item repository. /// Provides an interface to implement an Item repository.
/// </summary> /// </summary>
public interface IItemRepository : IDisposable public interface IItemRepository
{ {
/// <summary> /// <summary>
/// Deletes the item. /// Deletes the item.