Address comments

This commit is contained in:
Bond_009 2020-01-10 21:25:45 +01:00
parent 5751d86536
commit d9ec502ff9

View File

@ -111,19 +111,18 @@ namespace MediaBrowser.Api.Playback
if (size <= 0) if (size <= 0)
{ {
throw new ArgumentException($"The requested size can't be equal or smaller than 0.", nameof(request)); throw new ArgumentException($"The requested size ({size}) is equal to or smaller than 0.", nameof(request));
} }
if (size > MaxSize) if (size > MaxSize)
{ {
throw new ArgumentException($"The requested size can't be larger than the max allowed value ({MaxSize}).", nameof(request)); throw new ArgumentException($"The requested size ({size}) is larger than the max allowed value ({MaxSize}).", nameof(request));
} }
byte[] buffer = ArrayPool<byte>.Shared.Rent(size); byte[] buffer = ArrayPool<byte>.Shared.Rent(size);
try try
{ {
// ArrayPool<byte>.Shared.Rent doesn't guarantee that the returned buffer is zeroed new Random().NextBytes(buffer);
Array.Fill<byte>(buffer, 0);
return ResultFactory.GetResult(null, buffer, "application/octet-stream"); return ResultFactory.GetResult(null, buffer, "application/octet-stream");
} }
finally finally