From 810b63bfa88b7022aadb580d7a3d67d0211fb35c Mon Sep 17 00:00:00 2001 From: Luke Pulverenti Date: Fri, 5 Apr 2013 00:48:40 -0400 Subject: [PATCH 1/4] fixes #111 - FFprobe change breaks dvd transcode & subs --- MediaBrowser.Api/Playback/BaseStreamingService.cs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/MediaBrowser.Api/Playback/BaseStreamingService.cs b/MediaBrowser.Api/Playback/BaseStreamingService.cs index 9a264a7ba5..6c12452fc7 100644 --- a/MediaBrowser.Api/Playback/BaseStreamingService.cs +++ b/MediaBrowser.Api/Playback/BaseStreamingService.cs @@ -362,7 +362,7 @@ namespace MediaBrowser.Api.Playback outputSizeParam = "," + outputSizeParam.Substring(outputSizeParam.IndexOf("scale", StringComparison.OrdinalIgnoreCase)); } - return string.Format(" -filter_complex \"[0:{0}]format=yuva444p,lut=u=128:v=128:y=gammaval(.3)[sub] ; [0:0] [sub] overlay{1}\"", state.SubtitleStream.Index, outputSizeParam); + return string.Format(" -filter_complex \"[0:{0}]format=yuva444p,lut=u=128:v=128:y=gammaval(.3)[sub] ; [0:{1}] [sub] overlay{2}\"", state.SubtitleStream.Index, state.VideoStream.Index, outputSizeParam); } /// From 2a90cf6971027c521a2eb212e914a23579e237dc Mon Sep 17 00:00:00 2001 From: Luke Pulverenti Date: Fri, 5 Apr 2013 00:48:49 -0400 Subject: [PATCH 2/4] comments --- MediaBrowser.Api/UserLibrary/BaseItemsRequest.cs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/MediaBrowser.Api/UserLibrary/BaseItemsRequest.cs b/MediaBrowser.Api/UserLibrary/BaseItemsRequest.cs index c348bf5f51..a15da715f4 100644 --- a/MediaBrowser.Api/UserLibrary/BaseItemsRequest.cs +++ b/MediaBrowser.Api/UserLibrary/BaseItemsRequest.cs @@ -52,7 +52,7 @@ namespace MediaBrowser.Api.UserLibrary /// Fields to return within the items, in addition to basic information /// /// The fields. - [ApiMember(Name = "Fields", Description = "Optional. Specify additional fields of information to return in the output. This allows multiple, comma delimeted. Options: AudioInfo, Chapters, DateCreated, DisplayMediaType, DisplayPreferences, Genres, ItemCounts, IndexOptions, MediaStreams, Overview, OverviewHtml, ParentId, Path, People, ProviderIds, PrimaryImageAspectRatio, SeriesInfo, SortName, Studios, Taglines, TrailerUrls, UserData", IsRequired = false, DataType = "string", ParameterType = "query", Verb = "GET", AllowMultiple = true)] + [ApiMember(Name = "Fields", Description = "Optional. Specify additional fields of information to return in the output. This allows multiple, comma delimeted. Options: AudioInfo, Chapters, DateCreated, DisplayMediaType, DisplayPreferences, Genres, ItemCounts, IndexOptions, MediaStreams, Overview, OverviewHtml, ParentId, Path, People, ProviderIds, PrimaryImageAspectRatio, Publishers, SeriesInfo, SortName, Studios, Taglines, TrailerUrls, UserData", IsRequired = false, DataType = "string", ParameterType = "query", Verb = "GET", AllowMultiple = true)] public string Fields { get; set; } } } From 60e0f4d955b7707cb8845c324912c695a8693b16 Mon Sep 17 00:00:00 2001 From: Luke Pulverenti Date: Fri, 5 Apr 2013 01:03:50 -0400 Subject: [PATCH 3/4] fixes #111 --- .../Providers/MediaInfo/BaseFFProbeProvider.cs | 4 ++++ MediaBrowser.Model/Entities/MediaStream.cs | 6 +++++- 2 files changed, 9 insertions(+), 1 deletion(-) diff --git a/MediaBrowser.Controller/Providers/MediaInfo/BaseFFProbeProvider.cs b/MediaBrowser.Controller/Providers/MediaInfo/BaseFFProbeProvider.cs index 06af1c8cc2..bc8052f0eb 100644 --- a/MediaBrowser.Controller/Providers/MediaInfo/BaseFFProbeProvider.cs +++ b/MediaBrowser.Controller/Providers/MediaInfo/BaseFFProbeProvider.cs @@ -214,6 +214,10 @@ namespace MediaBrowser.Controller.Providers.MediaInfo { stream.Type = MediaStreamType.Subtitle; } + else if (streamInfo.codec_type.Equals("data", StringComparison.OrdinalIgnoreCase)) + { + stream.Type = MediaStreamType.Data; + } else { stream.Type = MediaStreamType.Video; diff --git a/MediaBrowser.Model/Entities/MediaStream.cs b/MediaBrowser.Model/Entities/MediaStream.cs index 23744d644b..84ae723934 100644 --- a/MediaBrowser.Model/Entities/MediaStream.cs +++ b/MediaBrowser.Model/Entities/MediaStream.cs @@ -158,6 +158,10 @@ namespace MediaBrowser.Model.Entities /// /// The subtitle /// - Subtitle + Subtitle, + /// + /// The data + /// + Data } } From 2d7c0ab29c76392d5d8f6b72d27194ee38218643 Mon Sep 17 00:00:00 2001 From: Luke Pulverenti Date: Fri, 5 Apr 2013 01:07:12 -0400 Subject: [PATCH 4/4] updated ffmpeg --- MediaBrowser.Controller/MediaBrowser.Controller.csproj | 2 +- .../MediaInfo/ffmpeg20130327.zip.REMOVED.git-id | 1 - .../MediaInfo/ffmpeg20130405.zip.REMOVED.git-id | 1 + 3 files changed, 2 insertions(+), 2 deletions(-) delete mode 100644 MediaBrowser.Controller/MediaInfo/ffmpeg20130327.zip.REMOVED.git-id create mode 100644 MediaBrowser.Controller/MediaInfo/ffmpeg20130405.zip.REMOVED.git-id diff --git a/MediaBrowser.Controller/MediaBrowser.Controller.csproj b/MediaBrowser.Controller/MediaBrowser.Controller.csproj index 8c2895701e..2e7a8a994f 100644 --- a/MediaBrowser.Controller/MediaBrowser.Controller.csproj +++ b/MediaBrowser.Controller/MediaBrowser.Controller.csproj @@ -200,9 +200,9 @@ - + diff --git a/MediaBrowser.Controller/MediaInfo/ffmpeg20130327.zip.REMOVED.git-id b/MediaBrowser.Controller/MediaInfo/ffmpeg20130327.zip.REMOVED.git-id deleted file mode 100644 index 7eeaacc0a3..0000000000 --- a/MediaBrowser.Controller/MediaInfo/ffmpeg20130327.zip.REMOVED.git-id +++ /dev/null @@ -1 +0,0 @@ -5e4750e9819a6763ee6a30a36b675ffa846a710b \ No newline at end of file diff --git a/MediaBrowser.Controller/MediaInfo/ffmpeg20130405.zip.REMOVED.git-id b/MediaBrowser.Controller/MediaInfo/ffmpeg20130405.zip.REMOVED.git-id new file mode 100644 index 0000000000..363d8552f8 --- /dev/null +++ b/MediaBrowser.Controller/MediaInfo/ffmpeg20130405.zip.REMOVED.git-id @@ -0,0 +1 @@ +33054d71c54e6c262d24d16153c05d45718aeb26 \ No newline at end of file