diff --git a/MediaBrowser.Api/ApiService.cs b/MediaBrowser.Api/ApiService.cs index 104ae7660a..0fef1cb574 100644 --- a/MediaBrowser.Api/ApiService.cs +++ b/MediaBrowser.Api/ApiService.cs @@ -170,7 +170,7 @@ namespace MediaBrowser.Api dto.TrailerUrl = item.TrailerUrl; dto.Type = item.GetType().Name; - dto.UserRating = item.UserRating; + dto.CommunityRating = item.CommunityRating; dto.UserData = GetDtoUserItemData(item.GetUserData(user, false)); diff --git a/MediaBrowser.Api/HttpHandlers/BaseMediaHandler.cs b/MediaBrowser.Api/HttpHandlers/BaseMediaHandler.cs index 7ad0ed8aa3..96ef606813 100644 --- a/MediaBrowser.Api/HttpHandlers/BaseMediaHandler.cs +++ b/MediaBrowser.Api/HttpHandlers/BaseMediaHandler.cs @@ -90,14 +90,15 @@ namespace MediaBrowser.Api.HttpHandlers } } - public override Task GetContentType() + protected override Task GetResponseInfo() { - return Task.FromResult(MimeTypes.GetMimeType("." + GetConversionOutputFormat())); - } + ResponseInfo info = new ResponseInfo + { + ContentType = MimeTypes.GetMimeType("." + GetConversionOutputFormat()), + CompressResponse = false + }; - public override bool ShouldCompressResponse(string contentType) - { - return false; + return Task.FromResult(info); } public override Task ProcessRequest(HttpListenerContext ctx) diff --git a/MediaBrowser.Api/HttpHandlers/ImageHandler.cs b/MediaBrowser.Api/HttpHandlers/ImageHandler.cs index f73f783afb..4aa367fb7e 100644 --- a/MediaBrowser.Api/HttpHandlers/ImageHandler.cs +++ b/MediaBrowser.Api/HttpHandlers/ImageHandler.cs @@ -1,13 +1,12 @@ -using MediaBrowser.Common.Logging; -using MediaBrowser.Common.Net; +using MediaBrowser.Common.Net; using MediaBrowser.Common.Net.Handlers; using MediaBrowser.Controller; +using MediaBrowser.Controller.Drawing; using MediaBrowser.Controller.Entities; using MediaBrowser.Model.Entities; using System; using System.ComponentModel.Composition; using System.IO; -using System.Linq; using System.Net; using System.Threading.Tasks; @@ -20,8 +19,9 @@ namespace MediaBrowser.Api.HttpHandlers { return ApiService.IsApiUrlMatch("image", request); } - + private string _imagePath; + private async Task GetImagePath() { _imagePath = _imagePath ?? await DiscoverImagePath(); @@ -29,121 +29,101 @@ namespace MediaBrowser.Api.HttpHandlers return _imagePath; } + private BaseEntity _sourceEntity; + + private async Task GetSourceEntity() + { + if (_sourceEntity == null) + { + if (!string.IsNullOrEmpty(QueryString["personname"])) + { + _sourceEntity = + await Kernel.Instance.ItemController.GetPerson(QueryString["personname"]).ConfigureAwait(false); + } + + else if (!string.IsNullOrEmpty(QueryString["genre"])) + { + _sourceEntity = + await Kernel.Instance.ItemController.GetGenre(QueryString["genre"]).ConfigureAwait(false); + } + + else if (!string.IsNullOrEmpty(QueryString["year"])) + { + _sourceEntity = + await + Kernel.Instance.ItemController.GetYear(int.Parse(QueryString["year"])).ConfigureAwait(false); + } + + else if (!string.IsNullOrEmpty(QueryString["studio"])) + { + _sourceEntity = + await Kernel.Instance.ItemController.GetStudio(QueryString["studio"]).ConfigureAwait(false); + } + + else if (!string.IsNullOrEmpty(QueryString["userid"])) + { + _sourceEntity = ApiService.GetUserById(QueryString["userid"], false); + } + + else + { + _sourceEntity = ApiService.GetItemById(QueryString["id"]); + } + } + + return _sourceEntity; + } + private async Task DiscoverImagePath() { - string personName = QueryString["personname"]; + var entity = await GetSourceEntity().ConfigureAwait(false); - if (!string.IsNullOrEmpty(personName)) - { - return (await Kernel.Instance.ItemController.GetPerson(personName).ConfigureAwait(false)).PrimaryImagePath; - } - - string genreName = QueryString["genre"]; - - if (!string.IsNullOrEmpty(genreName)) - { - return (await Kernel.Instance.ItemController.GetGenre(genreName).ConfigureAwait(false)).PrimaryImagePath; - } - - string year = QueryString["year"]; - - if (!string.IsNullOrEmpty(year)) - { - return (await Kernel.Instance.ItemController.GetYear(int.Parse(year)).ConfigureAwait(false)).PrimaryImagePath; - } - - string studio = QueryString["studio"]; - - if (!string.IsNullOrEmpty(studio)) - { - return (await Kernel.Instance.ItemController.GetStudio(studio).ConfigureAwait(false)).PrimaryImagePath; - } - - string userId = QueryString["userid"]; - - if (!string.IsNullOrEmpty(userId)) - { - return ApiService.GetUserById(userId, false).PrimaryImagePath; - } - - BaseItem item = ApiService.GetItemById(QueryString["id"]); - - string imageIndex = QueryString["index"]; - int index = string.IsNullOrEmpty(imageIndex) ? 0 : int.Parse(imageIndex); - - return GetImagePathFromTypes(item, ImageType, index); + return ImageProcessor.GetImagePath(entity, ImageType, ImageIndex); } - private Stream _sourceStream; - private async Task GetSourceStream() + protected async override Task GetResponseInfo() { - await EnsureSourceStream().ConfigureAwait(false); - return _sourceStream; - } + string path = await GetImagePath().ConfigureAwait(false); - private bool _sourceStreamEnsured; - private async Task EnsureSourceStream() - { - if (!_sourceStreamEnsured) + ResponseInfo info = new ResponseInfo { - try + CacheDuration = TimeSpan.FromDays(365), + ContentType = MimeTypes.GetMimeType(path) + }; + + DateTime? date = File.GetLastWriteTimeUtc(path); + + // If the file does not exist it will return jan 1, 1601 + // http://msdn.microsoft.com/en-us/library/system.io.file.getlastwritetimeutc.aspx + if (date.Value.Year == 1601) + { + if (!File.Exists(path)) { - _sourceStream = File.OpenRead(await GetImagePath().ConfigureAwait(false)); - } - catch (FileNotFoundException ex) - { - StatusCode = 404; - Logger.LogException(ex); - } - catch (DirectoryNotFoundException ex) - { - StatusCode = 404; - Logger.LogException(ex); - } - catch (UnauthorizedAccessException ex) - { - StatusCode = 403; - Logger.LogException(ex); - } - finally - { - _sourceStreamEnsured = true; + info.StatusCode = 404; + date = null; } } + + info.DateLastModified = date; + + return info; } - public async override Task GetContentType() - { - await EnsureSourceStream().ConfigureAwait(false); - - if (await GetSourceStream().ConfigureAwait(false) == null) - { - return null; - } - - return MimeTypes.GetMimeType(await GetImagePath().ConfigureAwait(false)); - } - - public override TimeSpan CacheDuration + private int ImageIndex { get { - return TimeSpan.FromDays(365); + string val = QueryString["index"]; + + if (string.IsNullOrEmpty(val)) + { + return 0; + } + + return int.Parse(val); } } - protected async override Task GetLastDateModified() - { - await EnsureSourceStream().ConfigureAwait(false); - - if (await GetSourceStream().ConfigureAwait(false) == null) - { - return null; - } - - return File.GetLastWriteTimeUtc(await GetImagePath().ConfigureAwait(false)); - } - private int? Height { get @@ -236,33 +216,9 @@ namespace MediaBrowser.Api.HttpHandlers protected override async Task WriteResponseToOutputStream(Stream stream) { - ImageProcessor.ProcessImage(await GetSourceStream().ConfigureAwait(false), stream, Width, Height, MaxWidth, MaxHeight, Quality); - } + var entity = await GetSourceEntity().ConfigureAwait(false); - private string GetImagePathFromTypes(BaseItem item, ImageType imageType, int imageIndex) - { - if (imageType == ImageType.Logo) - { - return item.LogoImagePath; - } - if (imageType == ImageType.Backdrop) - { - return item.BackdropImagePaths.ElementAt(imageIndex); - } - if (imageType == ImageType.Banner) - { - return item.BannerImagePath; - } - if (imageType == ImageType.Art) - { - return item.ArtImagePath; - } - if (imageType == ImageType.Thumbnail) - { - return item.ThumbnailImagePath; - } - - return item.PrimaryImagePath; + ImageProcessor.ProcessImage(entity, ImageType, ImageIndex, stream, Width, Height, MaxWidth, MaxHeight, Quality); } } } diff --git a/MediaBrowser.Api/HttpHandlers/PluginAssemblyHandler.cs b/MediaBrowser.Api/HttpHandlers/PluginAssemblyHandler.cs index 88161c1140..47f08c8c32 100644 --- a/MediaBrowser.Api/HttpHandlers/PluginAssemblyHandler.cs +++ b/MediaBrowser.Api/HttpHandlers/PluginAssemblyHandler.cs @@ -15,8 +15,8 @@ namespace MediaBrowser.Api.HttpHandlers { return ApiService.IsApiUrlMatch("pluginassembly", request); } - - public override Task GetContentType() + + protected override Task GetResponseInfo() { throw new NotImplementedException(); } diff --git a/MediaBrowser.Api/HttpHandlers/PluginConfigurationHandler.cs b/MediaBrowser.Api/HttpHandlers/PluginConfigurationHandler.cs index 95af9a3442..dc363956fd 100644 --- a/MediaBrowser.Api/HttpHandlers/PluginConfigurationHandler.cs +++ b/MediaBrowser.Api/HttpHandlers/PluginConfigurationHandler.cs @@ -17,7 +17,7 @@ namespace MediaBrowser.Api.HttpHandlers { return ApiService.IsApiUrlMatch("pluginconfiguration", request); } - + private BasePlugin _plugin; private BasePlugin Plugin { @@ -39,18 +39,15 @@ namespace MediaBrowser.Api.HttpHandlers return Task.FromResult(Plugin.Configuration); } - public override TimeSpan CacheDuration + protected override async Task GetResponseInfo() { - get - { - return TimeSpan.FromDays(7); - } - } + var info = await base.GetResponseInfo().ConfigureAwait(false); - protected override Task GetLastDateModified() - { - return Task.FromResult(Plugin.ConfigurationDateLastModified); - } + info.DateLastModified = Plugin.ConfigurationDateLastModified; + info.CacheDuration = TimeSpan.FromDays(7); + + return info; + } } } diff --git a/MediaBrowser.Api/HttpHandlers/ServerConfigurationHandler.cs b/MediaBrowser.Api/HttpHandlers/ServerConfigurationHandler.cs index 64ba44ec2f..48c6761b16 100644 --- a/MediaBrowser.Api/HttpHandlers/ServerConfigurationHandler.cs +++ b/MediaBrowser.Api/HttpHandlers/ServerConfigurationHandler.cs @@ -16,23 +16,22 @@ namespace MediaBrowser.Api.HttpHandlers { return ApiService.IsApiUrlMatch("serverconfiguration", request); } - + protected override Task GetObjectToSerialize() { return Task.FromResult(Kernel.Instance.Configuration); } - public override TimeSpan CacheDuration + protected override async Task GetResponseInfo() { - get - { - return TimeSpan.FromDays(7); - } - } + var info = await base.GetResponseInfo().ConfigureAwait(false); - protected override Task GetLastDateModified() - { - return Task.FromResult(File.GetLastWriteTimeUtc(Kernel.Instance.ApplicationPaths.SystemConfigurationFilePath)); + info.DateLastModified = + File.GetLastWriteTimeUtc(Kernel.Instance.ApplicationPaths.SystemConfigurationFilePath); + + info.CacheDuration = TimeSpan.FromDays(7); + + return info; } } } diff --git a/MediaBrowser.Api/HttpHandlers/VideoHandler.cs b/MediaBrowser.Api/HttpHandlers/VideoHandler.cs index 9d52136f0a..e34a1b41f7 100644 --- a/MediaBrowser.Api/HttpHandlers/VideoHandler.cs +++ b/MediaBrowser.Api/HttpHandlers/VideoHandler.cs @@ -1,5 +1,5 @@ -using MediaBrowser.Common.Drawing; -using MediaBrowser.Common.Net.Handlers; +using MediaBrowser.Common.Net.Handlers; +using MediaBrowser.Controller.Drawing; using MediaBrowser.Controller.Entities; using MediaBrowser.Model.DTO; using MediaBrowser.Model.Entities; @@ -7,7 +7,6 @@ using System; using System.Collections.Generic; using System.ComponentModel.Composition; using System.Drawing; -using System.IO; using System.Linq; using System.Net; diff --git a/MediaBrowser.Api/HttpHandlers/WeatherHandler.cs b/MediaBrowser.Api/HttpHandlers/WeatherHandler.cs index 93d4c8877e..378e89067d 100644 --- a/MediaBrowser.Api/HttpHandlers/WeatherHandler.cs +++ b/MediaBrowser.Api/HttpHandlers/WeatherHandler.cs @@ -3,6 +3,7 @@ using MediaBrowser.Controller; using MediaBrowser.Model.Weather; using System; using System.ComponentModel.Composition; +using System.Linq; using System.Net; using System.Threading.Tasks; @@ -15,7 +16,7 @@ namespace MediaBrowser.Api.HttpHandlers { return ApiService.IsApiUrlMatch("weather", request); } - + protected override Task GetObjectToSerialize() { // If a specific zip code was requested on the query string, use that. Otherwise use the value from configuration @@ -27,18 +28,16 @@ namespace MediaBrowser.Api.HttpHandlers zipCode = Kernel.Instance.Configuration.WeatherZipCode; } - return Kernel.Instance.WeatherClient.GetWeatherInfoAsync(zipCode); + return Kernel.Instance.WeatherProviders.First().GetWeatherInfoAsync(zipCode); } - /// - /// Tell the client to cache the weather info for 15 minutes - /// - public override TimeSpan CacheDuration + protected override async Task GetResponseInfo() { - get - { - return TimeSpan.FromMinutes(15); - } + var info = await base.GetResponseInfo().ConfigureAwait(false); + + info.CacheDuration = TimeSpan.FromMinutes(15); + + return info; } } } diff --git a/MediaBrowser.Api/MediaBrowser.Api.csproj b/MediaBrowser.Api/MediaBrowser.Api.csproj index 858717e6ed..44b58852b8 100644 --- a/MediaBrowser.Api/MediaBrowser.Api.csproj +++ b/MediaBrowser.Api/MediaBrowser.Api.csproj @@ -83,7 +83,6 @@ - diff --git a/MediaBrowser.Api/Plugin.cs b/MediaBrowser.Api/Plugin.cs index b2bcefd1f7..8def96da8d 100644 --- a/MediaBrowser.Api/Plugin.cs +++ b/MediaBrowser.Api/Plugin.cs @@ -1,5 +1,4 @@ using MediaBrowser.Common.Plugins; -using MediaBrowser.Model.Plugins; using System.ComponentModel.Composition; namespace MediaBrowser.Api diff --git a/MediaBrowser.Common/Events/GenericEventArgs.cs b/MediaBrowser.Common/Events/GenericEventArgs.cs new file mode 100644 index 0000000000..98e072816f --- /dev/null +++ b/MediaBrowser.Common/Events/GenericEventArgs.cs @@ -0,0 +1,12 @@ +using System; + +namespace MediaBrowser.Common.Events +{ + /// + /// Provides a generic EventArgs subclass that can hold any kind of object + /// + public class GenericEventArgs : EventArgs + { + public T Argument { get; set; } + } +} diff --git a/MediaBrowser.Common/Kernel/BaseKernel.cs b/MediaBrowser.Common/Kernel/BaseKernel.cs index 1fdc597ea7..5a0e1c5e5d 100644 --- a/MediaBrowser.Common/Kernel/BaseKernel.cs +++ b/MediaBrowser.Common/Kernel/BaseKernel.cs @@ -1,4 +1,5 @@ -using MediaBrowser.Common.Logging; +using MediaBrowser.Common.Events; +using MediaBrowser.Common.Logging; using MediaBrowser.Common.Net; using MediaBrowser.Common.Net.Handlers; using MediaBrowser.Common.Plugins; @@ -9,7 +10,6 @@ using System; using System.Collections.Generic; using System.ComponentModel.Composition; using System.ComponentModel.Composition.Hosting; -using System.Diagnostics; using System.IO; using System.Linq; using System.Reflection; @@ -24,6 +24,34 @@ namespace MediaBrowser.Common.Kernel where TConfigurationType : BaseApplicationConfiguration, new() where TApplicationPathsType : BaseApplicationPaths, new() { + #region ReloadBeginning Event + /// + /// Fires whenever the kernel begins reloading + /// + public event EventHandler>> ReloadBeginning; + private void OnReloadBeginning(IProgress progress) + { + if (ReloadBeginning != null) + { + ReloadBeginning(this, new GenericEventArgs> { Argument = progress }); + } + } + #endregion + + #region ReloadCompleted Event + /// + /// Fires whenever the kernel completes reloading + /// + public event EventHandler>> ReloadCompleted; + private void OnReloadCompleted(IProgress progress) + { + if (ReloadCompleted != null) + { + ReloadCompleted(this, new GenericEventArgs> { Argument = progress }); + } + } + #endregion + /// /// Gets the current configuration /// @@ -43,6 +71,12 @@ namespace MediaBrowser.Common.Kernel [ImportMany(typeof(BaseHandler))] private IEnumerable HttpHandlers { get; set; } + /// + /// Gets the list of currently registered Loggers + /// + [ImportMany(typeof(BaseLogger))] + public IEnumerable Loggers { get; set; } + /// /// Both the Ui and server will have a built-in HttpServer. /// People will inevitably want remote control apps so it's needed in the Ui too. @@ -54,6 +88,8 @@ namespace MediaBrowser.Common.Kernel /// private IDisposable HttpListener { get; set; } + private CompositionContainer CompositionContainer { get; set; } + protected virtual string HttpServerUrlPrefix { get @@ -72,13 +108,13 @@ namespace MediaBrowser.Common.Kernel /// public async Task Init(IProgress progress) { + Logger.Kernel = this; + // Performs initializations that only occur once InitializeInternal(progress); // Performs initializations that can be reloaded at anytime await Reload(progress).ConfigureAwait(false); - - progress.Report(new TaskProgress { Description = "Loading Complete" }); } /// @@ -87,45 +123,40 @@ namespace MediaBrowser.Common.Kernel protected virtual void InitializeInternal(IProgress progress) { ApplicationPaths = new TApplicationPathsType(); - - ReloadLogger(); - progress.Report(new TaskProgress { Description = "Loading configuration" }); + ReportProgress(progress, "Loading Configuration"); ReloadConfiguration(); - progress.Report(new TaskProgress { Description = "Starting Http server" }); + ReportProgress(progress, "Loading Http Server"); ReloadHttpServer(); } /// /// Performs initializations that can be reloaded at anytime /// - public virtual async Task Reload(IProgress progress) + public async Task Reload(IProgress progress) + { + OnReloadBeginning(progress); + + await ReloadInternal(progress).ConfigureAwait(false); + + OnReloadCompleted(progress); + + ReportProgress(progress, "Kernel.Reload Complete"); + } + + /// + /// Performs initializations that can be reloaded at anytime + /// + protected virtual async Task ReloadInternal(IProgress progress) { await Task.Run(() => { - progress.Report(new TaskProgress { Description = "Loading Plugins" }); + ReportProgress(progress, "Loading Plugins"); ReloadComposableParts(); }).ConfigureAwait(false); } - - /// - /// Disposes the current logger and creates a new one - /// - private void ReloadLogger() - { - DisposeLogger(); - - DateTime now = DateTime.Now; - - string logFilePath = Path.Combine(ApplicationPaths.LogDirectoryPath, "log-" + now.ToString("dMyyyy") + "-" + now.Ticks + ".log"); - - Trace.Listeners.Add(new TextWriterTraceListener(logFilePath)); - Trace.AutoFlush = true; - - Logger.LoggerInstance = new TraceLogger(); - } /// /// Uses MEF to locate plugins @@ -135,14 +166,13 @@ namespace MediaBrowser.Common.Kernel { DisposeComposableParts(); - var container = GetCompositionContainer(includeCurrentAssembly: true); + CompositionContainer = GetCompositionContainer(includeCurrentAssembly: true); - container.ComposeParts(this); + CompositionContainer.ComposeParts(this); OnComposablePartsLoaded(); - container.Catalog.Dispose(); - container.Dispose(); + CompositionContainer.Catalog.Dispose(); } /// @@ -157,8 +187,7 @@ namespace MediaBrowser.Common.Kernel var catalog = new AggregateCatalog(pluginAssemblies.Select(a => new AssemblyCatalog(a))); // Include composable parts in the Common assembly - // Uncomment this if it's ever needed - //catalog.Catalogs.Add(new AssemblyCatalog(Assembly.GetExecutingAssembly())); + catalog.Catalogs.Add(new AssemblyCatalog(Assembly.GetExecutingAssembly())); if (includeCurrentAssembly) { @@ -174,8 +203,13 @@ namespace MediaBrowser.Common.Kernel /// protected virtual void OnComposablePartsLoaded() { + foreach (var logger in Loggers) + { + logger.Initialize(this); + } + // Start-up each plugin - foreach (BasePlugin plugin in Plugins) + foreach (var plugin in Plugins) { plugin.Initialize(this); } @@ -189,17 +223,16 @@ namespace MediaBrowser.Common.Kernel //Configuration information for anything other than server-specific configuration will have to come via the API... -ebr // Deserialize config - if (!File.Exists(ApplicationPaths.SystemConfigurationFilePath)) + // Use try/catch to avoid the extra file system lookup using File.Exists + try + { + Configuration = XmlSerializer.DeserializeFromFile(ApplicationPaths.SystemConfigurationFilePath); + } + catch (FileNotFoundException) { Configuration = new TConfigurationType(); XmlSerializer.SerializeToFile(Configuration, ApplicationPaths.SystemConfigurationFilePath); } - else - { - Configuration = XmlSerializer.DeserializeFromFile(ApplicationPaths.SystemConfigurationFilePath); - } - - Logger.LoggerInstance.LogSeverity = Configuration.EnableDebugLevelLogging ? LogSeverity.Debug : LogSeverity.Info; } /// @@ -233,12 +266,10 @@ namespace MediaBrowser.Common.Kernel public virtual void Dispose() { Logger.LogInfo("Beginning Kernel.Dispose"); - - DisposeComposableParts(); DisposeHttpServer(); - DisposeLogger(); + DisposeComposableParts(); } /// @@ -246,22 +277,9 @@ namespace MediaBrowser.Common.Kernel /// protected virtual void DisposeComposableParts() { - DisposePlugins(); - } - - /// - /// Disposes all plugins - /// - private void DisposePlugins() - { - if (Plugins != null) + if (CompositionContainer != null) { - Logger.LogInfo("Disposing Plugins"); - - foreach (BasePlugin plugin in Plugins) - { - plugin.Dispose(); - } + CompositionContainer.Dispose(); } } @@ -273,7 +291,7 @@ namespace MediaBrowser.Common.Kernel if (HttpServer != null) { Logger.LogInfo("Disposing Http Server"); - + HttpServer.Dispose(); } @@ -283,21 +301,6 @@ namespace MediaBrowser.Common.Kernel } } - /// - /// Disposes the current Logger instance - /// - private void DisposeLogger() - { - Trace.Listeners.Clear(); - - if (Logger.LoggerInstance != null) - { - Logger.LogInfo("Disposing Logger"); - - Logger.LoggerInstance.Dispose(); - } - } - /// /// Gets the current application version /// @@ -309,6 +312,13 @@ namespace MediaBrowser.Common.Kernel } } + protected void ReportProgress(IProgress progress, string message) + { + progress.Report(new TaskProgress { Description = message }); + + Logger.LogInfo(message); + } + BaseApplicationPaths IKernel.ApplicationPaths { get { return ApplicationPaths; } @@ -322,6 +332,7 @@ namespace MediaBrowser.Common.Kernel Task Init(IProgress progress); Task Reload(IProgress progress); + IEnumerable Loggers { get; } void Dispose(); } } diff --git a/MediaBrowser.Common/Logging/BaseLogger.cs b/MediaBrowser.Common/Logging/BaseLogger.cs index 572ce36b2d..a97bc201f2 100644 --- a/MediaBrowser.Common/Logging/BaseLogger.cs +++ b/MediaBrowser.Common/Logging/BaseLogger.cs @@ -1,92 +1,16 @@ -using System; -using System.Text; -using System.Threading; +using MediaBrowser.Common.Kernel; +using System; namespace MediaBrowser.Common.Logging { public abstract class BaseLogger : IDisposable { - public LogSeverity LogSeverity { get; set; } - - public void LogInfo(string message, params object[] paramList) - { - LogEntry(message, LogSeverity.Info, paramList); - } - - public void LogDebugInfo(string message, params object[] paramList) - { - LogEntry(message, LogSeverity.Debug, paramList); - } - - public void LogError(string message, params object[] paramList) - { - LogEntry(message, LogSeverity.Error, paramList); - } - - public void LogException(string message, Exception exception, params object[] paramList) - { - var builder = new StringBuilder(); - - if (exception != null) - { - builder.AppendFormat("Exception. Type={0} Msg={1} StackTrace={3}{2}", - exception.GetType().FullName, - exception.Message, - exception.StackTrace, - Environment.NewLine); - } - - message = FormatMessage(message, paramList); - - LogError(string.Format("{0} ( {1} )", message, builder)); - } - - public void LogWarning(string message, params object[] paramList) - { - LogEntry(message, LogSeverity.Warning, paramList); - } - - private string FormatMessage(string message, params object[] paramList) - { - if (paramList != null) - { - for (int i = 0; i < paramList.Length; i++) - { - message = message.Replace("{" + i + "}", paramList[i].ToString()); - } - } - - return message; - } - - private void LogEntry(string message, LogSeverity severity, params object[] paramList) - { - if (severity < LogSeverity) return; - - message = FormatMessage(message, paramList); - - Thread currentThread = Thread.CurrentThread; - - var row = new LogRow - { - Severity = severity, - Message = message, - ThreadId = currentThread.ManagedThreadId, - ThreadName = currentThread.Name, - Time = DateTime.Now - }; - - LogEntry(row); - } - - protected virtual void Flush() - { - } + public abstract void Initialize(IKernel kernel); + public abstract void LogEntry(LogRow row); public virtual void Dispose() { + Logger.LogInfo("Disposing " + GetType().Name); } - - protected abstract void LogEntry(LogRow row); } } diff --git a/MediaBrowser.Common/Logging/LogSeverity.cs b/MediaBrowser.Common/Logging/LogSeverity.cs index 2abab1a448..97abfe7b58 100644 --- a/MediaBrowser.Common/Logging/LogSeverity.cs +++ b/MediaBrowser.Common/Logging/LogSeverity.cs @@ -1,4 +1,4 @@ -using System; +using System; namespace MediaBrowser.Common.Logging { @@ -11,4 +11,4 @@ namespace MediaBrowser.Common.Logging Warning = 4, Error = 8 } -} +} \ No newline at end of file diff --git a/MediaBrowser.Common/Logging/Logger.cs b/MediaBrowser.Common/Logging/Logger.cs index e66c1d8444..9ac02fe3ea 100644 --- a/MediaBrowser.Common/Logging/Logger.cs +++ b/MediaBrowser.Common/Logging/Logger.cs @@ -1,24 +1,28 @@ using System; +using System.Diagnostics; +using System.Text; +using System.Threading; +using MediaBrowser.Common.Kernel; namespace MediaBrowser.Common.Logging { public static class Logger { - public static BaseLogger LoggerInstance { get; set; } + internal static IKernel Kernel { get; set; } public static void LogInfo(string message, params object[] paramList) { - LoggerInstance.LogInfo(message, paramList); + LogEntry(message, LogSeverity.Info, paramList); } public static void LogDebugInfo(string message, params object[] paramList) { - LoggerInstance.LogDebugInfo(message, paramList); + LogEntry(message, LogSeverity.Debug, paramList); } public static void LogError(string message, params object[] paramList) { - LoggerInstance.LogError(message, paramList); + LogEntry(message, LogSeverity.Error, paramList); } public static void LogException(Exception ex, params object[] paramList) @@ -28,12 +32,62 @@ namespace MediaBrowser.Common.Logging public static void LogException(string message, Exception ex, params object[] paramList) { - LoggerInstance.LogException(message, ex, paramList); + var builder = new StringBuilder(); + + if (ex != null) + { + builder.AppendFormat("Exception. Type={0} Msg={1} StackTrace={3}{2}", + ex.GetType().FullName, + ex.Message, + ex.StackTrace, + Environment.NewLine); + } + + message = FormatMessage(message, paramList); + + LogError(string.Format("{0} ( {1} )", message, builder)); } public static void LogWarning(string message, params object[] paramList) { - LoggerInstance.LogWarning(message, paramList); + LogEntry(message, LogSeverity.Warning, paramList); + } + + private static void LogEntry(string message, LogSeverity severity, params object[] paramList) + { + message = FormatMessage(message, paramList); + + Thread currentThread = Thread.CurrentThread; + + var row = new LogRow + { + Severity = severity, + Message = message, + ThreadId = currentThread.ManagedThreadId, + ThreadName = currentThread.Name, + Time = DateTime.Now + }; + + if (Kernel.Loggers != null) + { + foreach (var logger in Kernel.Loggers) + { + logger.LogEntry(row); + } + } + } + + private static string FormatMessage(string message, params object[] paramList) + { + if (paramList != null) + { + for (int i = 0; i < paramList.Length; i++) + { + message = message.Replace("{" + i + "}", paramList[i].ToString()); + } + } + + return message; } } } diff --git a/MediaBrowser.Common/Logging/StreamLogger.cs b/MediaBrowser.Common/Logging/StreamLogger.cs deleted file mode 100644 index 03b9bd6d26..0000000000 --- a/MediaBrowser.Common/Logging/StreamLogger.cs +++ /dev/null @@ -1,37 +0,0 @@ -using System; -using System.IO; -using System.Text; - -namespace MediaBrowser.Common.Logging -{ - /// - /// Provides a Logger that can write to any Stream - /// - public class StreamLogger : BaseLogger - { - private Stream Stream { get; set; } - - public StreamLogger(Stream stream) - : base() - { - Stream = stream; - } - - protected override void LogEntry(LogRow row) - { - byte[] bytes = new UTF8Encoding().GetBytes(row.ToString() + Environment.NewLine); - - lock (Stream) - { - Stream.Write(bytes, 0, bytes.Length); - Stream.Flush(); - } - } - - public override void Dispose() - { - base.Dispose(); - Stream.Dispose(); - } - } -} diff --git a/MediaBrowser.Common/Logging/TraceFileLogger.cs b/MediaBrowser.Common/Logging/TraceFileLogger.cs new file mode 100644 index 0000000000..7ab67a137e --- /dev/null +++ b/MediaBrowser.Common/Logging/TraceFileLogger.cs @@ -0,0 +1,38 @@ +using MediaBrowser.Common.Kernel; +using System; +using System.ComponentModel.Composition; +using System.Diagnostics; +using System.IO; + +namespace MediaBrowser.Common.Logging +{ + [Export(typeof(BaseLogger))] + public class TraceFileLogger : BaseLogger + { + private TraceListener Listener { get; set; } + + public override void Initialize(IKernel kernel) + { + DateTime now = DateTime.Now; + + string logFilePath = Path.Combine(kernel.ApplicationPaths.LogDirectoryPath, "log-" + now.ToString("dMyyyy") + "-" + now.Ticks + ".log"); + + Listener = new TextWriterTraceListener(logFilePath); + Trace.Listeners.Add(Listener); + Trace.AutoFlush = true; + } + + public override void Dispose() + { + base.Dispose(); + + Trace.Listeners.Remove(Listener); + Listener.Dispose(); + } + + public override void LogEntry(LogRow row) + { + Trace.WriteLine(row.ToString()); + } + } +} diff --git a/MediaBrowser.Common/Logging/TraceLogger.cs b/MediaBrowser.Common/Logging/TraceLogger.cs deleted file mode 100644 index d152f97806..0000000000 --- a/MediaBrowser.Common/Logging/TraceLogger.cs +++ /dev/null @@ -1,12 +0,0 @@ -using System.Diagnostics; - -namespace MediaBrowser.Common.Logging -{ - public class TraceLogger : BaseLogger - { - protected override void LogEntry(LogRow row) - { - Trace.WriteLine(row.ToString()); - } - } -} diff --git a/MediaBrowser.Common/MediaBrowser.Common.csproj b/MediaBrowser.Common/MediaBrowser.Common.csproj index 198d78b09f..baa846e484 100644 --- a/MediaBrowser.Common/MediaBrowser.Common.csproj +++ b/MediaBrowser.Common/MediaBrowser.Common.csproj @@ -82,9 +82,11 @@ + - - + + + @@ -96,11 +98,8 @@ - - - @@ -152,6 +151,7 @@ +