Cutlery/jellyfin
1
0
Fork 0
mirror of https://github.com/jellyfin/jellyfin.git synced 2025-07-09 03:04:24 -04:00
Code Issues Packages Projects Releases Wiki Activity

Remove temp file even when saving failed

Browse Source
This commit is contained in:
gnattu 2024-11-03 04:11:41 +08:00
parent 3aefbf8cf6
commit e9ee0ef1f5
1 changed files with 27 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

32
MediaBrowser.Providers/Manager/ProviderManager.cs
View File

@ -258,15 +258,37 @@ namespace MediaBrowser.Providers.Manager
throw new ArgumentNullException(nameof(source)); throw new ArgumentNullException(nameof(source));
} }
var fileStream = AsyncFile.OpenRead(source); Exception? saveException = null;
await new ImageSaver(_configurationManager, _libraryMonitor, _fileSystem, _logger).SaveImage(item, fileStream, mimeType, type, imageIndex, saveLocallyWithMedia, cancellationToken);
try try
{ {
File.Delete(source); var fileStream = AsyncFile.OpenRead(source);
await new ImageSaver(_configurationManager, _libraryMonitor, _fileSystem, _logger).SaveImage(item, fileStream, mimeType, type, imageIndex, saveLocallyWithMedia, cancellationToken);
} }
catch (IOException ex) catch (Exception ex)
{ {
_logger.LogError(ex, "Source file {Source} not found or in use, skip removing", source); saveException = ex;
_logger.LogError(ex, "Unable to save image {Source}", source);
}
finally
{
try
{
File.Delete(source);
}
catch (IOException ex)
{
_logger.LogError(ex, "Source file {Source} not found or in use, skip removing", source);
}
catch (Exception ex)
{
saveException ??= ex;
}
}
if (saveException is not null)
{
throw saveException;
} }
} }