Commit Graph

359 Commits

Author SHA1 Message Date
Luke Brown abfbd04782 Moved IAsyncDisposable and IDisposable from WebSocketConnection to it's interface. Added private variable and guard statement to avoid disposing of WebSocketConnection unnecessarily. 2022-05-18 21:04:22 -05:00
Luke Brown a64eebe79f changes to use dispose 2022-05-16 22:09:41 -05:00
luke92brown 99df9c8fcd Replace redundant xml comments with inheritdoc. Make async changes to CloseSocket. 2022-05-09 23:44:37 -05:00
luke brown 4b563f4d7e Fix web sockets closing ungracefully 2022-05-09 23:44:24 -05:00
Bond_009 f50a250cd9 Optimize Guid comparisons
* Use Guid.Equals(Guid) instead of the == override
* Ban the usage of Guid.Equals(Object) to prevent accidental boxing
* Compare to default(Guid) instead of Guid.Empty
2022-02-21 14:15:09 +01:00
Cody Robibero 0765fd568f Use IAuthorizationContext for websocket 2022-01-01 12:34:22 -07:00
Bond_009 ea8f40e84a More cleanup 2021-12-27 14:20:05 +00:00
Bond_009 cbfa355e31 Update StyleCop 2021-12-24 18:28:27 +01:00
Cody Robibero 634ce40c2f Merge branch 'master' into comparisons 2021-12-24 02:41:50 +00:00
cvium b880dc8a4a Use our own Contains extension 2021-12-20 13:31:07 +01:00
Cody Robibero 4a28f46cac Don't throw exception on unauthenticated requests 2021-11-13 07:27:28 -07:00
Patrick Barron 80223c548c Fix warnings in WebSocketConnection 2021-10-03 21:41:22 -04:00
Cody Robibero ff9d14c811 Merge remote-tracking branch 'upstream/master' into authenticationdb-efcore 2021-09-03 11:01:55 -06:00
Cody Robibero cba07b1ca6 Remove more and more warnings 2021-08-28 16:32:50 -06:00
Bond_009 1f99c9b90c Minor fixes 2021-07-06 00:01:33 +02:00
Patrick Barron ae878fa051 Merge branch 'master' into authenticationdb-efcore
# Conflicts:
#	Emby.Server.Implementations/QuickConnect/QuickConnectManager.cs
#	Emby.Server.Implementations/Session/SessionManager.cs
#	Jellyfin.Server.Implementations/Security/AuthorizationContext.cs
2021-06-23 20:22:12 -04:00
Bond_009 6f8ccab788 Move non-jellyfin extensions to separate project 2021-06-19 18:04:46 +02:00
BaronGreenback 6648b7d7da Merge branch 'master' into comparisons 2021-06-19 15:04:30 +01:00
Patrick Barron be88efce3c Merge branch 'master' into authenticationdb-efcore
# Conflicts:
#	Emby.Server.Implementations/Devices/DeviceManager.cs
#	Emby.Server.Implementations/HttpServer/Security/SessionContext.cs
#	Emby.Server.Implementations/Security/AuthenticationRepository.cs
#	Emby.Server.Implementations/Session/SessionManager.cs
#	Jellyfin.Server.Implementations/Security/AuthorizationContext.cs
#	MediaBrowser.Controller/Library/IUserManager.cs
#	MediaBrowser.Controller/Net/ISessionContext.cs
2021-06-18 18:56:10 -04:00
Patrick Barron a0c6f72762 Migrate authentication db to EF Core 2021-05-20 23:56:59 -04:00
Bond_009 7e8428e588 Enable nullable reference types for Emby.Server.Implementations 2021-05-20 22:48:53 +02:00
Patrick Barron a225f34796 Merge branch 'master' into authenticationdb-efcore
# Conflicts:
#	Jellyfin.Api/Helpers/RequestHelpers.cs
2021-05-18 18:09:46 -04:00
Claus Vium 652909e8a5 Update Emby.Server.Implementations/HttpServer/Security/AuthorizationContext.cs
Co-authored-by: Cody Robibero <cody@robibe.ro>
2021-05-16 15:27:31 +02:00
cvium 1b49435a0e Reduce some allocations 2021-05-16 14:49:11 +02:00
BaronGreenback e682c230bd Merge branch 'master' into comparisons 2021-05-05 23:22:54 +01:00
BaronGreenback bc1cc2d04a Remove unused using directives 2021-04-17 11:37:55 +01:00
BaronGreenback 80877aa945 Cleaned up "value assigned is not used in any execution path" 2021-04-17 09:27:58 +01:00
Patrick Barron 8607b52541 Make device/session code async 2021-04-10 16:57:25 -04:00
cvium 14d0acf285 add simple auth handling to websocketmanager 2021-04-05 15:12:47 +02:00
David 19e4ef82dd Remove conversion from IPAddress to string to IPAddress 2021-03-23 17:16:10 +01:00
Bond_009 a8ed753f6c FxCop -> Net Analyzers (part 2) 2021-03-13 22:33:28 +01:00
Bond_009 9a5ceb34d1 Improve WebSocket Deserialization 2021-01-13 01:11:25 +01:00
Ryan Petris 875562e580 This is only used in one place and therefore will always be HttpRequest. 2020-12-15 22:17:04 -07:00
Ryan Petris 1b3fcab6a4 If requestContext is HttpRequest, get the context from it properly. 2020-12-15 22:02:08 -07:00
crobibero 2478c8fa64 Fix inverted condition when authenticating with an ApiKey 2020-12-09 23:15:33 -07:00
Joshua M. Boniface bba01bf7b9 Merge pull request #3194 from OancaAndrei/syncplay-enhanced
SyncPlay for TV series (and Music)
2020-12-04 20:22:30 -05:00
crobibero cd459c51f3 Return NoResult only when request doesn't have a token. 2020-12-01 14:47:42 -07:00
cvium 65e6211c03 Remove circular dependency between websocket listeners and manager 2020-11-28 11:21:53 +01:00
cvium 1a0d8aef80 Revert "Removed Lazy implementation." 2020-11-28 09:50:16 +01:00
Greenback 5cd5a7d4ce Removed Lazy implementation. 2020-11-28 00:25:20 +00:00
Bond_009 9041389f65 Use string.Trim(char) instead of string.Trim(char[]) where possible 2020-11-14 20:27:59 +01:00
Bond_009 bc7359f87d Use string.Split(char) where possible instead of string.Split(char[]) 2020-11-14 20:27:48 +01:00
cvium e78c63c4dc Remove OriginalAuthenticationInfo and add IsAuthenticated property 2020-11-08 16:10:33 +01:00
Claus Vium c17f84ae48 Merge pull request #4330 from crobibero/api-key-auth
Fix ApiKey authentication
2020-11-08 08:20:50 +01:00
crobibero 981f000437 Use proper IsApiKey flag 2020-10-28 08:40:11 -06:00
crobibero eee95336b5 Fix setting duplicate keys from auth header 2020-10-26 17:18:54 -06:00
crobibero d5c226b1c3 Move SecurityException 2020-10-15 08:02:59 -06:00
crobibero 39924f9992 Allow apikey to authenticate as admin 2020-10-14 17:58:33 -06:00
cvium 38cb8fee8a Fix IWebSocketListener service registration 2020-10-06 14:44:07 +02:00
Niels van Velzen 72534f9d66 Use SessionMessageType for WebSocket messages 2020-09-27 10:00:20 +02:00