Commit Graph

172 Commits

Author SHA1 Message Date
Michael Jones b555de4cea Fix CA2007 warnings in InstallationManager
Wrap the downloaded stream in an explicit await using block with
ConfigureAwait(false), matching the pattern already used in
LiveStreamHelper and similar callers. Also add ConfigureAwait(false)
to the ZipFile.ExtractToDirectoryAsync call.

Part of #2149
2026-05-26 22:24:16 -05:00
Richard Torhan 50dcec1ff5 Fix error CA2016: Forward the 'cancellationToken' parameter to the 'ExtractToDirectoryAsync' method or pass in 'CancellationToken.None' explicitly to indicate intentionally not propagating the token 2026-01-14 18:55:47 +01:00
Richard Torhan d089537bca Fix error CA1849: 'ZipFile.ExtractToDirectory(Stream, string, bool)' synchronously blocks. Await 'ZipFile.ExtractToDirectoryAsync(Stream, string, bool, CancellationToken)' instead. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1849) 2026-01-14 18:55:47 +01:00
theguymadmax cf9051c277 Backport pull request #15961 from jellyfin/release-10.11.z
Fix crash when plugin repository has an invalid URL

Original-merge: 317a3a47c3

Merged-by: Bond-009 <bond.009@outlook.com>

Backported-by: Bond_009 <bond.009@outlook.com>
2026-01-10 06:11:27 -05:00
crobibero 4dc826644d Backport pull request #15197 from jellyfin/release-10.11.z
Filter plugins by id instead of name

Original-merge: 5691eee4f1

Merged-by: crobibero <cody@robibe.ro>

Backported-by: Bond_009 <bond.009@outlook.com>
2025-10-27 15:43:26 -04:00
Josh Soref 044cf9fb85 chore: fix spelling
* a
* acceleration
* addition
* altogether
* api clients
* artist
* associated
* bandwidth
* cannot
* capabilities
* case-insensitive
* case-sensitive
* configuration
* delimiter
* dependent
* diacritics
* directors
* enable
* explicitly
* filters
* finish
* have
* hierarchy
* implicit
* include
* information
* into
* its
* keepalive
* localization
* macos
* manual
* matching
* metadata
* nonexistent
* options
* overridden
* parsed
* parser
* playback
* preferring
* processes
* processing
* provider
* ratings
* retrieval
* running
* segments
* separate
* should
* station
* subdirectories
* superseded
* supported
* system
* than
* the
* throws
* transpose
* valid
* was

link: forum or chat rooms

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
2025-01-25 20:05:15 -05:00
Daniyar Alpyspayev 2614fecf8d move to new System.Threading.Lock type for better performance 2024-12-12 18:10:06 +05:00
Cody Robibero e7b8d45bbb Use helper function to compare guid (#10825) 2024-01-17 08:51:39 -07:00
Çağrı Sakaoğlu 435c143140 Fix:Plugin Installed Alerts missing from Admin Dashboard #10620 2023-11-26 13:20:31 +00:00
Bond_009 464de13acf Use new static ZipFile functions 2023-11-16 00:49:23 +01:00
Bond_009 d7748cfa04 Multiple Stream changes
* Remove useless MemoryStream in DlnaHttpClient
* Use HttpContent.ReadFromJsonAsync extension
* Call ConfigureAwait for IAsyncDisposable
* Use HttpContent.CopyToAsync where possible
2023-10-11 18:32:57 +02:00
Bond_009 b176beb88e Reduce string allocations
Some simple changes to reduce the number of allocated strings
2023-10-06 01:04:25 +02:00
AmbulantRex 7dd4201971 Reconcile pre-packaged meta.json against manifest on install 2023-04-09 10:53:09 -06:00
Bond_009 52194f56b5 Replace != null with is not null 2022-12-05 15:01:13 +01:00
Bond_009 c7d50d640e Replace == null with is null 2022-12-05 15:00:20 +01:00
Bond_009 a9a5fcde81 Use ArgumentNullException.ThrowIfNull helper method
Did a simple search/replace on the whole repo (except the RSSDP project)
This reduces LOC and should improve performance (methods containing a throw statement don't get inlined)

```
if \((\w+) == null\)
\s+\{
\s+throw new ArgumentNullException\((.*)\);
\s+\}
```

```
ArgumentNullException.ThrowIfNull($1);
```
2022-10-06 20:21:23 +02:00
Bond_009 f50a250cd9 Optimize Guid comparisons
* Use Guid.Equals(Guid) instead of the == override
* Ban the usage of Guid.Equals(Object) to prevent accidental boxing
* Compare to default(Guid) instead of Guid.Empty
2022-02-21 14:15:09 +01:00
Cody Robibero 7bfc6b5679 Remove more warnings 2021-12-27 07:38:06 -07:00
cvium b880dc8a4a Use our own Contains extension 2021-12-20 13:31:07 +01:00
Bond_009 a4565da4a9 Use System.IO.Compression instead of SharpCompress for zips
Also removes unused methods from ZipClient
2021-12-18 17:52:38 +01:00
Bond_009 1d19a5be61 Fix some warnings
down to 580
2021-11-09 22:29:33 +01:00
Patrick Barron 7ea4c844c8 Fix warnings in InstallationManager 2021-10-03 21:41:22 -04:00
Bond_009 6f8ccab788 Move non-jellyfin extensions to separate project 2021-06-19 18:04:46 +02:00
Bond_009 383c2d7374 Remove useless nullable directives 2021-06-11 23:36:10 +02:00
Bond_009 c78457e6d3 Minor fixes 2021-06-06 18:11:51 +02:00
Bond_009 7e8428e588 Enable nullable reference types for Emby.Server.Implementations 2021-05-20 22:48:53 +02:00
BaronGreenback b645bb20de Update Emby.Server.Implementations/Updates/InstallationManager.cs
Co-authored-by: Cody Robibero <cody@robibe.ro>
2021-04-08 14:38:25 +01:00
BaronGreenback 65f880be32 Keep plugin status after update. 2021-04-06 20:59:47 +01:00
Bond_009 a8ed753f6c FxCop -> Net Analyzers (part 2) 2021-03-13 22:33:28 +01:00
dkanada 64cc5889f2 add suggested changes 2021-02-23 23:11:17 +09:00
dkanada 9caf311925 handle plugin manifests automatically 2021-02-12 22:33:10 +09:00
BaronGreenback 8e04e6c837 Update Emby.Server.Implementations/Updates/InstallationManager.cs
Co-authored-by: Claus Vium <cvium@users.noreply.github.com>
2020-12-23 10:27:27 +00:00
BaronGreenback 63c290f878 Update Emby.Server.Implementations/Updates/InstallationManager.cs
Co-authored-by: Claus Vium <cvium@users.noreply.github.com>
2020-12-23 10:26:20 +00:00
BaronGreenback 4757824a82 Update Emby.Server.Implementations/Updates/InstallationManager.cs
Co-authored-by: Cody Robibero <cody@robibe.ro>
2020-12-18 21:55:50 +00:00
Greenback cb793af30e Renamed guid to id 2020-12-18 21:11:29 +00:00
Greenback 5c4fdaa253 MaxAbi property removed. 2020-12-18 21:05:27 +00:00
Greenback ce19f2be55 Renamed Guid property to Id 2020-12-18 20:37:35 +00:00
Greenback 486148dd6b Removed maxAbi 2020-12-18 09:44:57 +00:00
Greenback 1ed25ebd9a Corrections as recommended. 2020-12-16 22:36:25 +00:00
Greenback 5323887540 Replaced TryGetPlugin with GetPlugin 2020-12-15 20:27:42 +00:00
Greenback eb2439f23b Changes as recommended. 2020-12-15 16:37:11 +00:00
Greenback 208d545cfe Changed as suggested. 2020-12-15 10:05:04 +00:00
Greenback cddc87e2af Fixed gitmerge. 2020-12-15 01:23:52 +00:00
BaronGreenback 67c480ad53 Merge branch 'master' into PluginDowngrade 2020-12-15 01:15:54 +00:00
Greenback 0d4aa6bad6 Enable local file repositories 2020-12-15 01:13:11 +00:00
Greenback 7986465cf7 Initial upload 2020-12-14 16:14:39 +00:00
Claus Vium f322866127 Merge pull request #4737 from crobibero/missing-ensure-success 2020-12-11 09:53:43 +01:00
crobibero e621244405 Add missing EnsureSuccessStatusCode 2020-12-08 08:28:19 -07:00
crobibero 8df2213d6b Don't return plugin versions that target newer Jellyfin version 2020-12-06 10:13:08 -07:00
Bond_009 8c8a71692e Remove Hex class as the BCL has one now 2020-11-25 23:40:31 +01:00