Bond_009 
							
						 
					 
					
						
						
						
						
							
						
						
							19824bff94 
							
						 
					 
					
						
						
							
							Minor improvements  
						
						
						
						
					 
					
						2021-08-15 23:48:19 +02:00 
						 
				 
			
				
					
						
							
							
								Bond_009 
							
						 
					 
					
						
						
						
						
							
						
						
							6f8ccab788 
							
						 
					 
					
						
						
							
							Move non-jellyfin extensions to separate project  
						
						
						
						
					 
					
						2021-06-19 18:04:46 +02:00 
						 
				 
			
				
					
						
							
							
								Bond_009 
							
						 
					 
					
						
						
						
						
							
						
						
							7e8428e588 
							
						 
					 
					
						
						
							
							Enable nullable reference types for Emby.Server.Implementations  
						
						
						
						
					 
					
						2021-05-20 22:48:53 +02:00 
						 
				 
			
				
					
						
							
							
								BaronGreenback 
							
						 
					 
					
						
						
						
						
							
						
						
							bc1cc2d04a 
							
						 
					 
					
						
						
							
							Remove unused using directives  
						
						
						
						
					 
					
						2021-04-17 11:37:55 +01:00 
						 
				 
			
				
					
						
							
							
								Bond_009 
							
						 
					 
					
						
						
						
						
							
						
						
							a8ed753f6c 
							
						 
					 
					
						
						
							
							FxCop -> Net Analyzers (part 2)  
						
						
						
						
					 
					
						2021-03-13 22:33:28 +01:00 
						 
				 
			
				
					
						
							
							
								Bond_009 
							
						 
					 
					
						
						
						
						
							
						
						
							1ea2b200c0 
							
						 
					 
					
						
						
							
							JsonSerializer deserialize from bytes where possible  
						
						... 
						
						
						
						This is faster and uses way less memory
```
BenchmarkDotNet=v0.12.1, OS=fedora 32
Intel Core i7-6700HQ CPU 2.60GHz (Skylake), 1 CPU, 8 logical and 4 physical cores
.NET Core SDK=5.0.100
  [Host]     : .NET Core 5.0.0 (CoreCLR 5.0.20.51904, CoreFX 5.0.20.51904), X64 RyuJIT
  DefaultJob : .NET Core 5.0.0 (CoreCLR 5.0.20.51904, CoreFX 5.0.20.51904), X64 RyuJIT
| Method |     Mean |   Error |  StdDev |   Gen 0 | Gen 1 | Gen 2 | Allocated |
|------- |---------:|--------:|--------:|--------:|------:|------:|----------:|
|  Bytes | 158.4 us | 2.56 us | 2.14 us | 16.8457 |     - |     - |  52.08 KB |
| String | 172.8 us | 0.78 us | 0.70 us | 41.5039 |     - |     - | 127.82 KB |
| Custom | 155.5 us | 2.95 us | 2.76 us | 10.0098 |     - |     - |  31.27 KB |
``` 
						
						
					 
					
						2021-01-12 15:28:02 +01:00 
						 
				 
			
				
					
						
							
							
								David 
							
						 
					 
					
						
						
						
						
							
						
						
							3dec1fd6b2 
							
						 
					 
					
						
						
							
							Use UTF8 encoding and async correctly  
						
						
						
						
					 
					
						2020-12-29 00:35:59 +01:00 
						 
				 
			
				
					
						
							
							
								David 
							
						 
					 
					
						
						
						
						
							
						
						
							043d045448 
							
						 
					 
					
						
						
							
							Put json serializer options in private field  
						
						
						
						
					 
					
						2020-12-24 11:22:34 +01:00 
						 
				 
			
				
					
						
							
							
								David 
							
						 
					 
					
						
						
						
						
							
						
						
							e835dfb27d 
							
						 
					 
					
						
						
							
							Use sync string instead of file  
						
						
						
						
					 
					
						2020-12-24 10:31:51 +01:00 
						 
				 
			
				
					
						
							
							
								David 
							
						 
					 
					
						
						
						
						
							
						
						
							a714008b59 
							
						 
					 
					
						
						
							
							Add missing FileStreams  
						
						
						
						
					 
					
						2020-12-23 21:00:50 +01:00 
						 
				 
			
				
					
						
							
							
								David 
							
						 
					 
					
						
						
						
						
							
						
						
							2a574914ea 
							
						 
					 
					
						
						
							
							Use streams instead of strings  
						
						
						
						
					 
					
						2020-12-23 19:24:58 +01:00 
						 
				 
			
				
					
						
							
							
								David 
							
						 
					 
					
						
						
						
						
							
						
						
							f38970cbd3 
							
						 
					 
					
						
						
							
							Remove xml docs  
						
						
						
						
					 
					
						2020-12-23 15:03:14 +01:00 
						 
				 
			
				
					
						
							
							
								David 
							
						 
					 
					
						
						
						
						
							
						
						
							196388d607 
							
						 
					 
					
						
						
							
							Remove custom Json serializer from Emby.Server.Implementations  
						
						
						
						
					 
					
						2020-12-23 13:14:40 +01:00 
						 
				 
			
				
					
						
							
							
								crobibero 
							
						 
					 
					
						
						
						
						
							
						
						
							821ad79992 
							
						 
					 
					
						
						
							
							fix spacing  
						
						
						
						
					 
					
						2020-12-01 11:09:01 -07:00 
						 
				 
			
				
					
						
							
							
								crobibero 
							
						 
					 
					
						
						
						
						
							
						
						
							c083b29e29 
							
						 
					 
					
						
						
							
							Use Guid as API parameter type where possible  
						
						
						
						
					 
					
						2020-12-01 11:07:41 -07:00 
						 
				 
			
				
					
						
							
							
								crobibero 
							
						 
					 
					
						
						
						
						
							
						
						
							3cc0dd7e12 
							
						 
					 
					
						
						
							
							Reduce RequestHelpers.Split usage and remove RequestHelpers.GetGuids usage.  
						
						
						
						
					 
					
						2020-11-16 20:29:46 -07:00 
						 
				 
			
				
					
						
							
							
								Bond_009 
							
						 
					 
					
						
						
						
						
							
						
						
							b21919c7f4 
							
						 
					 
					
						
						
							
							Minor perf improvements  
						
						
						
						
					 
					
						2020-11-06 16:15:30 +01:00 
						 
				 
			
				
					
						
							
							
								Bond_009 
							
						 
					 
					
						
						
						
						
							
						
						
							49569ca0a0 
							
						 
					 
					
						
						
							
							Use nameof where possible  
						
						
						
						
					 
					
						2020-10-17 16:19:57 +02:00 
						 
				 
			
				
					
						
							
							
								Bond_009 
							
						 
					 
					
						
						
						
						
							
						
						
							e653eef44f 
							
						 
					 
					
						
						
							
							Fix some warnings  
						
						
						
						
					 
					
						2020-08-31 22:20:19 +02:00 
						 
				 
			
				
					
						
							
							
								Bond_009 
							
						 
					 
					
						
						
						
						
							
						
						
							119f64f5e7 
							
						 
					 
					
						
						
							
							Make some methods async  
						
						
						
						
					 
					
						2020-08-21 22:01:19 +02:00 
						 
				 
			
				
					
						
							
							
								Patrick Barron 
							
						 
					 
					
						
						
						
						
							
						
						
							bea519de5b 
							
						 
					 
					
						
						
							
							Fix MemoryCache Usage.  
						
						
						
						
					 
					
						2020-08-07 13:22:18 -04:00 
						 
				 
			
				
					
						
							
							
								Bond-009 
							
						 
					 
					
						
						
							
							
						
						
						
							
						
						
							b7421db5fe 
							
						 
					 
					
						
						
							
							Merge pull request  #3578  from barronpm/displaypreferences-efcore  
						
						... 
						
						
						
						Migrate Display Preferences to EF Core 
						
						
					 
					
						2020-08-01 21:51:49 +02:00 
						 
				 
			
				
					
						
							
							
								Patrick Barron 
							
						 
					 
					
						
						
						
						
							
						
						
							c77abca31a 
							
						 
					 
					
						
						
							
							Use MemoryCache in ChannelManager  
						
						
						
						
					 
					
						2020-07-29 17:33:40 -04:00 
						 
				 
			
				
					
						
							
							
								Patrick Barron 
							
						 
					 
					
						
						
						
						
							
						
						
							ab396225ea 
							
						 
					 
					
						
						
							
							Migrate Display Preferences to EF Core  
						
						
						
						
					 
					
						2020-07-17 16:11:53 -04:00 
						 
				 
			
				
					
						
							
							
								telans 
							
						 
					 
					
						
						
							
							
						
						
						
							
						
						
							acd4389653 
							
						 
					 
					
						
						
							
							fix SA1005  
						
						
						
						
					 
					
						2020-06-15 10:41:00 +12:00 
						 
				 
			
				
					
						
							
							
								Patrick Barron 
							
						 
					 
					
						
						
						
						
							
						
						
							42b4f0aa2e 
							
						 
					 
					
						
						
							
							Merge branch 'master' into userdb-efcore  
						
						... 
						
						
						
						# Conflicts:
#	Emby.Server.Implementations/Library/UserManager.cs
#	Jellyfin.Data/Jellyfin.Data.csproj 
						
						
					 
					
						2020-06-13 19:41:05 -04:00 
						 
				 
			
				
					
						
							
							
								crobibero 
							
						 
					 
					
						
						
						
						
							
						
						
							44957c5a9a 
							
						 
					 
					
						
						
							
							Use typed logger where possible  
						
						
						
						
					 
					
						2020-06-05 18:15:56 -06:00 
						 
				 
			
				
					
						
							
							
								Patrick Barron 
							
						 
					 
					
						
						
						
						
							
						
						
							06f9cde22f 
							
						 
					 
					
						
						
							
							Merge branch 'master' into userdb-efcore  
						
						... 
						
						
						
						# Conflicts:
#	Emby.Server.Implementations/EntryPoints/ServerEventNotifier.cs
#	Emby.Server.Implementations/Library/UserManager.cs
#	Emby.Server.Implementations/Sorting/IsFavoriteOrLikeComparer.cs
#	Emby.Server.Implementations/Sorting/IsPlayedComparer.cs
#	Emby.Server.Implementations/Sorting/IsUnplayedComparer.cs
#	Emby.Server.Implementations/TV/TVSeriesManager.cs
#	Jellyfin.Server.Implementations/Users/DefaultAuthenticationProvider.cs 
						
						
					 
					
						2020-06-04 16:52:23 -04:00 
						 
				 
			
				
					
						
							
							
								Bond_009 
							
						 
					 
					
						
						
						
						
							
						
						
							4748105dce 
							
						 
					 
					
						
						
							
							Enable TreatWarningsAsErrors for Jellyfin.Server.Implementations in Release mode  
						
						
						
						
					 
					
						2020-05-29 11:28:19 +02:00 
						 
				 
			
				
					
						
							
							
								Patrick Barron 
							
						 
					 
					
						
						
						
						
							
						
						
							c464f700db 
							
						 
					 
					
						
						
							
							Remove redundant qualifiers  
						
						
						
						
					 
					
						2020-05-20 13:07:53 -04:00 
						 
				 
			
				
					
						
							
							
								Patrick Barron 
							
						 
					 
					
						
						
						
						
							
						
						
							9ad839c776 
							
						 
					 
					
						
						
							
							Initial migration code  
						
						
						
						
					 
					
						2020-05-12 22:10:35 -04:00 
						 
				 
			
				
					
						
							
							
								Patrick Barron 
							
						 
					 
					
						
						
							
							
						
						
						
							
						
						
							7586c60224 
							
						 
					 
					
						
						
							
							Merge branch 'master' into warnings-cleanup1  
						
						
						
						
					 
					
						2020-04-22 13:44:20 +00:00 
						 
				 
			
				
					
						
							
							
								Patrick Barron 
							
						 
					 
					
						
						
						
						
							
						
						
							f26f44acaf 
							
						 
					 
					
						
						
							
							Apply code review suggestions  
						
						
						
						
					 
					
						2020-04-19 13:39:12 -04:00 
						 
				 
			
				
					
						
							
							
								Patrick Barron 
							
						 
					 
					
						
						
						
						
							
						
						
							c4e6329e58 
							
						 
					 
					
						
						
							
							Clean up and document ChannelManager.cs and implement suggestions  
						
						
						
						
					 
					
						2020-04-15 15:00:45 -04:00 
						 
				 
			
				
					
						
							
							
								Bond_009 
							
						 
					 
					
						
						
						
						
							
						
						
							49fe5e0a21 
							
						 
					 
					
						
						
							
							Fix some warnings  
						
						
						
						
					 
					
						2020-04-11 12:03:10 +02:00 
						 
				 
			
				
					
						
							
							
								Bond_009 
							
						 
					 
					
						
						
						
						
							
						
						
							07cc4be6a7 
							
						 
					 
					
						
						
							
							Fix some warnings  
						
						... 
						
						
						
						* Add analyzers to MediaBrowser.XbmcMetadata
* Enable TreatWarningsAsErrors for MediaBrowser.XbmcMetadata
* Add analyzers to MediaBrowser.WebDashboard
* Enable TreatWarningsAsErrors for MediaBrowser.WebDashboard
* Disable SA1600 in favor of CS1591 
						
						
					 
					
						2020-02-23 12:11:43 +01:00 
						 
				 
			
				
					
						
							
							
								Bond_009 
							
						 
					 
					
						
						
						
						
							
						
						
							2ef4ffd698 
							
						 
					 
					
						
						
							
							More warnings (removed)  
						
						
						
						
					 
					
						2019-12-11 00:13:57 +01:00 
						 
				 
			
				
					
						
							
							
								dkanada 
							
						 
					 
					
						
						
							
							
						
						
						
							
						
						
							67922dff50 
							
						 
					 
					
						
						
							
							Merge pull request  #2041  from Bond-009/warn11  
						
						... 
						
						
						
						Fix more warnings 
						
						
					 
					
						2019-12-11 01:14:55 +09:00 
						 
				 
			
				
					
						
							
							
								Bond-009 
							
						 
					 
					
						
						
						
						
							
						
						
							a2c35e6dba 
							
						 
					 
					
						
						
							
							Merge remote-tracking branch 'upstream/master' into random  
						
						
						
						
					 
					
						2019-12-06 12:06:13 +01:00 
						 
				 
			
				
					
						
							
							
								Bond_009 
							
						 
					 
					
						
						
						
						
							
						
						
							42ffddc269 
							
						 
					 
					
						
						
							
							Fix more warnings  
						
						
						
						
					 
					
						2019-11-27 16:29:56 +01:00 
						 
				 
			
				
					
						
							
							
								Bond-009 
							
						 
					 
					
						
						
						
						
							
						
						
							b477b3874e 
							
						 
					 
					
						
						
							
							Fix some warnings  
						
						
						
						
					 
					
						2019-11-22 16:15:31 +01:00 
						 
				 
			
				
					
						
							
							
								Bond_009 
							
						 
					 
					
						
						
						
						
							
						
						
							d9a03c9bb1 
							
						 
					 
					
						
						
							
							Fix more warnings  
						
						
						
						
					 
					
						2019-10-29 17:55:16 +01:00 
						 
				 
			
				
					
						
							
							
								Bond_009 
							
						 
					 
					
						
						
						
						
							
						
						
							bbc0875387 
							
						 
					 
					
						
						
							
							Don't shuffle some types by default  
						
						
						
						
					 
					
						2019-10-20 16:08:40 +02:00 
						 
				 
			
				
					
						
							
							
								Bond-009 
							
						 
					 
					
						
						
						
						
							
						
						
							6032f31aa6 
							
						 
					 
					
						
						
							
							Use CultureInvariant string conversion for Guids  
						
						
						
						
					 
					
						2019-08-09 23:17:54 +02:00 
						 
				 
			
				
					
						
							
							
								Bond-009 
							
						 
					 
					
						
						
						
						
							
						
						
							6566c91360 
							
						 
					 
					
						
						
							
							Seperate changes from  #1023  
						
						... 
						
						
						
						The unrelated changes from #1023  (and more) 
						
						
					 
					
						2019-03-25 21:27:03 +01:00 
						 
				 
			
				
					
						
							
							
								Bond-009 
							
						 
					 
					
						
						
						
						
							
						
						
							9993dafe54 
							
						 
					 
					
						
						
							
							Don't mix LINQ and roreach loops for readability  
						
						
						
						
					 
					
						2019-03-01 17:12:22 +01:00 
						 
				 
			
				
					
						
							
							
								Erwin de Haan 
							
						 
					 
					
						
						
						
						
							
						
						
							d7c6d16250 
							
						 
					 
					
						
						
							
							Unwrapped CreateDirectory and DeleteDirectory  
						
						
						
						
					 
					
						2019-01-28 22:09:56 +01:00 
						 
				 
			
				
					
						
							
							
								Erwin de Haan 
							
						 
					 
					
						
						
						
						
							
						
						
							3a831994f6 
							
						 
					 
					
						
						
							
							Unwrapped GetDirectoryName and DirectorySeperatorChar  
						
						
						
						
					 
					
						2019-01-28 22:06:34 +01:00 
						 
				 
			
				
					
						
							
							
								Bond_009 
							
						 
					 
					
						
						
						
						
							
						
						
							722120af74 
							
						 
					 
					
						
						
							
							Remove conditions that are always true/false  
						
						
						
						
					 
					
						2019-01-22 23:49:51 +01:00 
						 
				 
			
				
					
						
							
							
								William Taylor 
							
						 
					 
					
						
						
						
						
							
						
						
							65cd3ed597 
							
						 
					 
					
						
						
							
							Replaced injections of ILogger with ILoggerFactory  
						
						... 
						
						
						
						This makes resolving dependencies from the container much easier as
you cannot resolve with primitives parameters in a way that is any
more readable.
The aim of this commit is to change as little as possible with the end
result, loggers that were newed up for the parent object were given the same
name. Objects that used the base or app loggers, were given a new logger with
an appropriate name.
Also removed some unused dependencies. 
						
						
					 
					
						2019-01-20 21:05:12 +00:00