mirror of
https://github.com/jellyfin/jellyfin.git
synced 2025-05-24 02:02:29 -04:00
Fix parallel use of not thread-safe SubtitleFormat instance Original-merge: 0b2a59e9631269c7e3261895e2e45d9dc07de848 Merged-by: joshuaboniface <joshua@boniface.me> Backported-by: Bond_009 <bond.009@outlook.com>
139 lines
5.4 KiB
C#
139 lines
5.4 KiB
C#
using System;
|
|
using System.Collections.Generic;
|
|
using System.Globalization;
|
|
using System.IO;
|
|
using System.Linq;
|
|
using Jellyfin.Extensions;
|
|
using MediaBrowser.Model.MediaInfo;
|
|
using Microsoft.Extensions.Logging;
|
|
using Nikse.SubtitleEdit.Core.Common;
|
|
using SubtitleFormat = Nikse.SubtitleEdit.Core.SubtitleFormats.SubtitleFormat;
|
|
|
|
namespace MediaBrowser.MediaEncoding.Subtitles
|
|
{
|
|
/// <summary>
|
|
/// SubStation Alpha subtitle parser.
|
|
/// </summary>
|
|
public class SubtitleEditParser : ISubtitleParser
|
|
{
|
|
private readonly ILogger<SubtitleEditParser> _logger;
|
|
private readonly Dictionary<string, List<Type>> _subtitleFormatTypes;
|
|
|
|
/// <summary>
|
|
/// Initializes a new instance of the <see cref="SubtitleEditParser"/> class.
|
|
/// </summary>
|
|
/// <param name="logger">The logger.</param>
|
|
public SubtitleEditParser(ILogger<SubtitleEditParser> logger)
|
|
{
|
|
_logger = logger;
|
|
_subtitleFormatTypes = GetSubtitleFormatTypes();
|
|
}
|
|
|
|
/// <inheritdoc />
|
|
public SubtitleTrackInfo Parse(Stream stream, string fileExtension)
|
|
{
|
|
var subtitle = new Subtitle();
|
|
var lines = stream.ReadAllLines().ToList();
|
|
|
|
if (!_subtitleFormatTypes.TryGetValue(fileExtension, out var subtitleFormatTypesForExtension))
|
|
{
|
|
throw new ArgumentException($"Unsupported file extension: {fileExtension}", nameof(fileExtension));
|
|
}
|
|
|
|
foreach (var subtitleFormatType in subtitleFormatTypesForExtension)
|
|
{
|
|
var subtitleFormat = (SubtitleFormat)Activator.CreateInstance(subtitleFormatType, true)!;
|
|
_logger.LogDebug(
|
|
"Trying to parse '{FileExtension}' subtitle using the {SubtitleFormatParser} format parser",
|
|
fileExtension,
|
|
subtitleFormat.Name);
|
|
subtitleFormat.LoadSubtitle(subtitle, lines, fileExtension);
|
|
if (subtitleFormat.ErrorCount == 0)
|
|
{
|
|
break;
|
|
}
|
|
else if (subtitleFormat.TryGetErrors(out var errors))
|
|
{
|
|
_logger.LogError(
|
|
"{ErrorCount} errors encountered while parsing '{FileExtension}' subtitle using the {SubtitleFormatParser} format parser, errors: {Errors}",
|
|
subtitleFormat.ErrorCount,
|
|
fileExtension,
|
|
subtitleFormat.Name,
|
|
errors);
|
|
}
|
|
else
|
|
{
|
|
_logger.LogError(
|
|
"{ErrorCount} errors encountered while parsing '{FileExtension}' subtitle using the {SubtitleFormatParser} format parser",
|
|
subtitleFormat.ErrorCount,
|
|
fileExtension,
|
|
subtitleFormat.Name);
|
|
}
|
|
}
|
|
|
|
if (subtitle.Paragraphs.Count == 0)
|
|
{
|
|
throw new ArgumentException("Unsupported format: " + fileExtension);
|
|
}
|
|
|
|
var trackInfo = new SubtitleTrackInfo();
|
|
int len = subtitle.Paragraphs.Count;
|
|
var trackEvents = new SubtitleTrackEvent[len];
|
|
for (int i = 0; i < len; i++)
|
|
{
|
|
var p = subtitle.Paragraphs[i];
|
|
trackEvents[i] = new SubtitleTrackEvent(p.Number.ToString(CultureInfo.InvariantCulture), p.Text)
|
|
{
|
|
StartPositionTicks = p.StartTime.TimeSpan.Ticks,
|
|
EndPositionTicks = p.EndTime.TimeSpan.Ticks
|
|
};
|
|
}
|
|
|
|
trackInfo.TrackEvents = trackEvents;
|
|
return trackInfo;
|
|
}
|
|
|
|
/// <inheritdoc />
|
|
public bool SupportsFileExtension(string fileExtension)
|
|
=> _subtitleFormatTypes.ContainsKey(fileExtension);
|
|
|
|
private Dictionary<string, List<Type>> GetSubtitleFormatTypes()
|
|
{
|
|
var subtitleFormatTypes = new Dictionary<string, List<Type>>(StringComparer.OrdinalIgnoreCase);
|
|
var assembly = typeof(SubtitleFormat).Assembly;
|
|
|
|
foreach (var type in assembly.GetTypes())
|
|
{
|
|
if (!type.IsSubclassOf(typeof(SubtitleFormat)) || type.IsAbstract)
|
|
{
|
|
continue;
|
|
}
|
|
|
|
try
|
|
{
|
|
var tempInstance = (SubtitleFormat)Activator.CreateInstance(type, true)!;
|
|
var extension = tempInstance.Extension.TrimStart('.');
|
|
if (!string.IsNullOrEmpty(extension))
|
|
{
|
|
// Store only the type, we will instantiate from it later
|
|
if (!subtitleFormatTypes.TryGetValue(extension, out var subtitleFormatTypesForExtension))
|
|
{
|
|
subtitleFormatTypes[extension] = [type];
|
|
}
|
|
else
|
|
{
|
|
subtitleFormatTypesForExtension.Add(type);
|
|
}
|
|
}
|
|
}
|
|
catch (Exception ex)
|
|
{
|
|
_logger.LogWarning(ex, "Failed to create instance of the subtitle format {SubtitleFormatType}", type.Name);
|
|
}
|
|
}
|
|
|
|
return subtitleFormatTypes;
|
|
}
|
|
}
|
|
}
|