Cutlery/jellyfin
1
0
Fork 0
mirror of https://github.com/jellyfin/jellyfin.git synced 2025-08-11 09:13:54 -04:00
Code Issues Packages Projects Releases Wiki Activity

Updated Contributing to Jellyfin (markdown)

Joshua M. Boniface 2019-01-01 16:22:37 -05:00
parent 093e7453c8
commit 3a0af22a33
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
Contributing-to-Jellyfin.md

@ -60,7 +60,7 @@ When submitting a new PR, please ensure you do the following things. If you have
1. *Why* the changes are being made. Reference specific issues with keywords (`fixes`, `closes`, `addresses`, etc.) if at all possible. 1. *Why* the changes are being made. Reference specific issues with keywords (`fixes`, `closes`, `addresses`, etc.) if at all possible.
1. *How*, in broad strokes, you approached the issue (if applicable) and briefly describe the changes, especially for large PRs. 1. *How*, in broad strokes, you approached the issue (if applicable) and briefly describe the changes, especially for large PRs.
* Manually update the target branch from `master` to `dev`; PRs against `master` are only considered in the most exceptional circumstances and all new work should go to `dev`. We intentionally keep `master` as the main face of the code on GitHub, so this must be done manually for each PR. Don't worry if you forget; this will be corrected before merging. * Manually update the target branch from `master` to `dev`; PRs against `master` are only considered in the most exceptional circumstances and all new work should go to `dev`. We intentionally keep `master` as the main face of the code on GitHub, so this must be done manually for each PR. Don't worry if you forget; this will be corrected before merging.
* Expect review and discussion. If you can't back up your changes with a good description and through review, please reconsider whether it should be done at all. All PRs to `dev` require at least one approving review from an administrative team member, however we welcome and encourage reviews from any contributor, especially if it's in an area you are knowledgeable in. More eyes are always better. * Expect review and discussion. If you can't back up your changes with a good description and through review, please reconsider whether it should be done at all. All PRs to `dev` require at least one approving review from an administrative team member, however we welcome and encourage reviews from any contributor, especially if it's in an area you are knowledgeable about. More eyes are always better.
## The Master branch ## The Master branch