From cb8b39e40f74fd1dfb193ff4d75042a3b4da751a Mon Sep 17 00:00:00 2001 From: "Joshua M. Boniface" Date: Tue, 1 Jan 2019 16:20:40 -0500 Subject: [PATCH] Updated Contributing to Jellyfin (markdown) --- Contributing-to-Jellyfin.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Contributing-to-Jellyfin.md b/Contributing-to-Jellyfin.md index 389688a..68977b4 100644 --- a/Contributing-to-Jellyfin.md +++ b/Contributing-to-Jellyfin.md @@ -56,7 +56,7 @@ If it's your first time contributing code, please add yourself to the `CONTRIBUT When submitting a new PR, please ensure you do the following things. If you haven't, please read [How to Write a Git Commit Message](https://chris.beams.io/posts/git-commit/) as it is a great resource for writing useful commit messages. * Write a good title that quickly describes what has been changed. For example, "Adds LDAP support to Jellyfin". -* For anything but the most trivial changes that can be described fully in the title, write a detailed PR body to describe, in detail: +* For anything but the most trivial changes that can be described fully in the title, write a PR body to describe, in as much detail as possible: 1. *Why* the changes are being made. Reference specific issues with keywords (`fixes`, `closes`, `addresses`, etc.) if at all possible. 1. *How*, in broad strokes, you approached the issue (if applicable) and briefly describe the changes, especially for large PRs. * Manually update the target branch from `master` to `dev`; PRs against `master` are only considered in the most exceptional circumstances and all new work should go to `dev`. GitHub does not know this, so you must be explicit with every PR.