From cc955a99af3dcff1400cbf472f962839b95a76d9 Mon Sep 17 00:00:00 2001 From: "Joshua M. Boniface" Date: Sun, 16 Dec 2018 11:49:06 -0500 Subject: [PATCH] Updated Contributing to Jellyfin (markdown) --- Contributing-to-Jellyfin.md | 2 ++ 1 file changed, 2 insertions(+) diff --git a/Contributing-to-Jellyfin.md b/Contributing-to-Jellyfin.md index 6696b94..0193413 100644 --- a/Contributing-to-Jellyfin.md +++ b/Contributing-to-Jellyfin.md @@ -32,6 +32,8 @@ We adhere to a fairly standard fork-and-PR model of development: 3. Submit a pull request from your feature branch back to the upstream `develop` branch. PRs that target `master` will be changed to target `develop`, so please double-check this when submitting. +Please ensure you provide a detailed explanation, in each pull request discription, of what problems the PR solves (with action keywords ans links to issue numbers if at all possible), and how the PR solves them. This aids both in review, as well as in future understanding of why a given set of changes were made. + All PRs to the `develop` branch require review by at least 1 member of the core team. Once that is done, if the PR is not tagged with the WIP label, it should be merged by the reviewer if able. We do however encourage reviews from any contributor as more eyes always helps. Merges from `develop` back into `master` will occur when needed, and must be reviewed by at least 2 members of the core team. Once that is done, a third core team member should review the reviews and merge the commit.