From 0dfb3a84cbf844a5e21e027db01c23416a07b45c Mon Sep 17 00:00:00 2001 From: Michael Genson <71845777+michael-genson@users.noreply.github.com> Date: Thu, 27 Oct 2022 13:46:53 -0500 Subject: [PATCH] fix: properly format SMTP from address/name (#1782) --- mealie/services/email/email_senders.py | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/mealie/services/email/email_senders.py b/mealie/services/email/email_senders.py index 037abae6dbec..1a77d8839b4c 100644 --- a/mealie/services/email/email_senders.py +++ b/mealie/services/email/email_senders.py @@ -28,12 +28,13 @@ class SMTPResponse: class Message: subject: str html: str - mail_from: tuple[str, str] + mail_from_name: str + mail_from_address: str def send(self, to: str, smtp: EmailOptions) -> SMTPResponse: msg = message.EmailMessage() msg["Subject"] = self.subject - msg["From"] = self.mail_from + msg["From"] = f"{self.mail_from_name} <{self.mail_from_address}>" msg["To"] = to msg.add_alternative(self.html, subtype="html") @@ -75,7 +76,8 @@ class DefaultEmailSender(ABCEmailSender, BaseService): message = Message( subject=subject, html=html, - mail_from=(self.settings.SMTP_FROM_NAME, self.settings.SMTP_FROM_EMAIL), + mail_from_name=self.settings.SMTP_FROM_NAME, + mail_from_address=self.settings.SMTP_FROM_EMAIL, ) if self.settings.SMTP_HOST is None or self.settings.SMTP_PORT is None: