From 3ed197a843048035bb8d8f2da47a4dcd18ca563c Mon Sep 17 00:00:00 2001
From: hay-kot <hay-kot@pm.me>
Date: Sat, 7 Aug 2021 16:49:55 -0800
Subject: [PATCH] fix linter issues

---
 .../Domain/MealPlan/MealPlanCard.vue          |  0
 .../Domain/MealPlan/MealPlanEditor.vue        |  0
 .../Domain/MealPlan/MealPlanNew.vue           |  0
 .../Domain/User/UserAvatar.vue                |  0
 .../Page/Recipe/RecipeEditor.vue              |  0
 .../Page/Recipe/RecipeViewer.vue              |  0
 .../Domain/Recipe/RecipeComments.vue          |  4 ++-
 .../Domain/Recipe/RecipeDialogBulkAdd.vue     |  2 +-
 .../Recipe/RecipeDialogExtrasEditor.vue       |  9 ++++---
 .../Domain/Recipe/RecipeIngredients.vue       |  1 +
 .../Domain/Recipe/RecipeInstructions.vue      |  7 +++--
 .../components/Domain/Recipe/RecipeNotes.vue  |  1 +
 .../Domain/Recipe/RecipeNutrition.vue         |  7 +++--
 .../Domain/Recipe/RecipePrintView.vue         |  5 +++-
 .../Domain/Recipe/RecipeSettingsMenu.vue      |  5 +++-
 frontend/components/global/AppButtonCopy.vue  |  2 ++
 frontend/components/global/AppLoader.vue      |  3 ++-
 .../components/global/BaseColorPicker.vue     | 10 +++++--
 frontend/plugins/globals.js                   |  3 ++-
 frontend/utils/index.js                       | 26 +++++++++----------
 frontend/utils/recipe.js                      |  6 ++---
 21 files changed, 58 insertions(+), 33 deletions(-)
 rename {frontend => frontend.old}/component-stagin/Domain/MealPlan/MealPlanCard.vue (100%)
 rename {frontend => frontend.old}/component-stagin/Domain/MealPlan/MealPlanEditor.vue (100%)
 rename {frontend => frontend.old}/component-stagin/Domain/MealPlan/MealPlanNew.vue (100%)
 rename {frontend => frontend.old}/component-stagin/Domain/User/UserAvatar.vue (100%)
 rename {frontend => frontend.old}/component-stagin/Page/Recipe/RecipeEditor.vue (100%)
 rename {frontend => frontend.old}/component-stagin/Page/Recipe/RecipeViewer.vue (100%)

diff --git a/frontend/component-stagin/Domain/MealPlan/MealPlanCard.vue b/frontend.old/component-stagin/Domain/MealPlan/MealPlanCard.vue
similarity index 100%
rename from frontend/component-stagin/Domain/MealPlan/MealPlanCard.vue
rename to frontend.old/component-stagin/Domain/MealPlan/MealPlanCard.vue
diff --git a/frontend/component-stagin/Domain/MealPlan/MealPlanEditor.vue b/frontend.old/component-stagin/Domain/MealPlan/MealPlanEditor.vue
similarity index 100%
rename from frontend/component-stagin/Domain/MealPlan/MealPlanEditor.vue
rename to frontend.old/component-stagin/Domain/MealPlan/MealPlanEditor.vue
diff --git a/frontend/component-stagin/Domain/MealPlan/MealPlanNew.vue b/frontend.old/component-stagin/Domain/MealPlan/MealPlanNew.vue
similarity index 100%
rename from frontend/component-stagin/Domain/MealPlan/MealPlanNew.vue
rename to frontend.old/component-stagin/Domain/MealPlan/MealPlanNew.vue
diff --git a/frontend/component-stagin/Domain/User/UserAvatar.vue b/frontend.old/component-stagin/Domain/User/UserAvatar.vue
similarity index 100%
rename from frontend/component-stagin/Domain/User/UserAvatar.vue
rename to frontend.old/component-stagin/Domain/User/UserAvatar.vue
diff --git a/frontend/component-stagin/Page/Recipe/RecipeEditor.vue b/frontend.old/component-stagin/Page/Recipe/RecipeEditor.vue
similarity index 100%
rename from frontend/component-stagin/Page/Recipe/RecipeEditor.vue
rename to frontend.old/component-stagin/Page/Recipe/RecipeEditor.vue
diff --git a/frontend/component-stagin/Page/Recipe/RecipeViewer.vue b/frontend.old/component-stagin/Page/Recipe/RecipeViewer.vue
similarity index 100%
rename from frontend/component-stagin/Page/Recipe/RecipeViewer.vue
rename to frontend.old/component-stagin/Page/Recipe/RecipeViewer.vue
diff --git a/frontend/components/Domain/Recipe/RecipeComments.vue b/frontend/components/Domain/Recipe/RecipeComments.vue
index b6a11a22d461..3b595fafc562 100644
--- a/frontend/components/Domain/Recipe/RecipeComments.vue
+++ b/frontend/components/Domain/Recipe/RecipeComments.vue
@@ -57,9 +57,11 @@ export default {
   props: {
     comments: {
       type: Array,
+      default: () => [],
     },
     slug: {
       type: String,
+      required: true,
     },
   },
   data() {
@@ -85,7 +87,7 @@ export default {
   },
   methods: {
     resetImage() {
-      this.hideImage == false;
+      this.hideImage = false;
     },
     getProfileImage(id) {
       return api.users.userProfileImage(id);
diff --git a/frontend/components/Domain/Recipe/RecipeDialogBulkAdd.vue b/frontend/components/Domain/Recipe/RecipeDialogBulkAdd.vue
index e7649384c39d..0c1abc0b413a 100644
--- a/frontend/components/Domain/Recipe/RecipeDialogBulkAdd.vue
+++ b/frontend/components/Domain/Recipe/RecipeDialogBulkAdd.vue
@@ -41,7 +41,7 @@ export default {
       const split = this.inputText.split("\n");
 
       split.forEach((element, index) => {
-        if ((element === "\n") | (element == false)) {
+        if ((element === "\n") | (element === false)) {
           split.splice(index, 1);
         }
       });
diff --git a/frontend/components/Domain/Recipe/RecipeDialogExtrasEditor.vue b/frontend/components/Domain/Recipe/RecipeDialogExtrasEditor.vue
index 5a4eb9d2d07b..9b38b61640b9 100644
--- a/frontend/components/Domain/Recipe/RecipeDialogExtrasEditor.vue
+++ b/frontend/components/Domain/Recipe/RecipeDialogExtrasEditor.vue
@@ -49,7 +49,10 @@
 <script>
 export default {
   props: {
-    extras: Object,
+    extras: {
+      type: Object,
+      default: () => ({}),
+    },
   },
   data() {
     return {
@@ -57,8 +60,8 @@ export default {
       dialog: false,
       formKey: 1,
       rules: {
-        required: v => !!v || this.$i18n.t("recipe.key-name-required"),
-        whiteSpace: v => !v || v.split(" ").length <= 1 || this.$i18n.t("recipe.no-white-space-allowed"),
+        required: (v) => !!v || this.$i18n.t("recipe.key-name-required"),
+        whiteSpace: (v) => !v || v.split(" ").length <= 1 || this.$i18n.t("recipe.no-white-space-allowed"),
       },
     };
   },
diff --git a/frontend/components/Domain/Recipe/RecipeIngredients.vue b/frontend/components/Domain/Recipe/RecipeIngredients.vue
index 4d9af98ee49b..5e819a73ed3b 100644
--- a/frontend/components/Domain/Recipe/RecipeIngredients.vue
+++ b/frontend/components/Domain/Recipe/RecipeIngredients.vue
@@ -84,6 +84,7 @@ export default {
   props: {
     value: {
       type: Array,
+      default: () => [],
     },
 
     edit: {
diff --git a/frontend/components/Domain/Recipe/RecipeInstructions.vue b/frontend/components/Domain/Recipe/RecipeInstructions.vue
index 09b4eefbfb8d..317c6c75191b 100644
--- a/frontend/components/Domain/Recipe/RecipeInstructions.vue
+++ b/frontend/components/Domain/Recipe/RecipeInstructions.vue
@@ -97,6 +97,7 @@ export default {
   props: {
     value: {
       type: Array,
+      required: true,
     },
 
     edit: {
@@ -115,13 +116,13 @@ export default {
     value: {
       handler() {
         this.disabledSteps = [];
-        this.showTitleEditor = this.value.map(x => this.validateTitle(x.title));
+        this.showTitleEditor = this.value.map((x) => this.validateTitle(x.title));
       },
     },
   },
 
   mounted() {
-    this.showTitleEditor = this.value.map(x => this.validateTitle(x.title));
+    this.showTitleEditor = this.value.map((x) => this.validateTitle(x.title));
   },
 
   methods: {
@@ -148,8 +149,6 @@ export default {
     isChecked(stepIndex) {
       if (this.disabledSteps.includes(stepIndex) && !this.edit) {
         return "disabled-card";
-      } else {
-        
       }
     },
     toggleShowTitle(index) {
diff --git a/frontend/components/Domain/Recipe/RecipeNotes.vue b/frontend/components/Domain/Recipe/RecipeNotes.vue
index b9df319a3f34..41c8debf4f18 100644
--- a/frontend/components/Domain/Recipe/RecipeNotes.vue
+++ b/frontend/components/Domain/Recipe/RecipeNotes.vue
@@ -43,6 +43,7 @@ export default {
   props: {
     value: {
       type: Array,
+      required: true,
     },
 
     edit: {
diff --git a/frontend/components/Domain/Recipe/RecipeNutrition.vue b/frontend/components/Domain/Recipe/RecipeNutrition.vue
index 60a2d52faa2b..682d36226dc1 100644
--- a/frontend/components/Domain/Recipe/RecipeNutrition.vue
+++ b/frontend/components/Domain/Recipe/RecipeNutrition.vue
@@ -21,7 +21,7 @@
       <v-list v-if="showViewer" dense class="mt-0 pt-0">
         <v-list-item v-for="(item, key, index) in labels" :key="index">
           <v-list-item-content>
-            <v-list-item-title class="pl-4 text-subtitle-1 flex row ">
+            <v-list-item-title class="pl-4 text-subtitle-1 flex row">
               <div>{{ item.label }}</div>
               <div class="ml-auto mr-1">{{ value[key] }}</div>
               <div>{{ item.suffix }}</div>
@@ -36,7 +36,10 @@
 <script>
 export default {
   props: {
-    value: {},
+    value: {
+      type: Object,
+      required: true,
+    },
     edit: {
       type: Boolean,
       default: true,
diff --git a/frontend/components/Domain/Recipe/RecipePrintView.vue b/frontend/components/Domain/Recipe/RecipePrintView.vue
index 9bb1ede1f6bc..c46132bad50a 100644
--- a/frontend/components/Domain/Recipe/RecipePrintView.vue
+++ b/frontend/components/Domain/Recipe/RecipePrintView.vue
@@ -69,7 +69,10 @@ export default {
     VueMarkdown,
   },
   props: {
-    recipe: Object,
+    recipe: {
+      type: Object,
+      required: true,
+    },
   },
 };
 </script>
diff --git a/frontend/components/Domain/Recipe/RecipeSettingsMenu.vue b/frontend/components/Domain/Recipe/RecipeSettingsMenu.vue
index 97de8987a7fe..1bb68d26c671 100644
--- a/frontend/components/Domain/Recipe/RecipeSettingsMenu.vue
+++ b/frontend/components/Domain/Recipe/RecipeSettingsMenu.vue
@@ -37,7 +37,10 @@
 export default {
   components: {},
   props: {
-    value: Object,
+    value: {
+      type: Object,
+      required: true,
+    },
   },
 
   computed: {
diff --git a/frontend/components/global/AppButtonCopy.vue b/frontend/components/global/AppButtonCopy.vue
index 89b6b6b0a06a..c2dda842fc7f 100644
--- a/frontend/components/global/AppButtonCopy.vue
+++ b/frontend/components/global/AppButtonCopy.vue
@@ -36,9 +36,11 @@
 export default {
   props: {
     copyText: {
+      type: String,
       default: "Default Copy Text",
     },
     color: {
+      type: String,
       default: "primary",
     },
   },
diff --git a/frontend/components/global/AppLoader.vue b/frontend/components/global/AppLoader.vue
index 7415bebda6d0..6b3e55dec256 100644
--- a/frontend/components/global/AppLoader.vue
+++ b/frontend/components/global/AppLoader.vue
@@ -24,6 +24,7 @@
 export default {
   props: {
     loading: {
+      type: Boolean,
       default: true,
     },
     small: {
@@ -62,7 +63,7 @@ export default {
     },
     waitingText() {
       return this.$t("general.loading-recipes");
-    }
+    },
   },
 };
 </script>
diff --git a/frontend/components/global/BaseColorPicker.vue b/frontend/components/global/BaseColorPicker.vue
index 40f6649aebb6..c522fdf53adb 100644
--- a/frontend/components/global/BaseColorPicker.vue
+++ b/frontend/components/global/BaseColorPicker.vue
@@ -23,8 +23,14 @@
 <script>
 export default {
   props: {
-    buttonText: String,
-    value: String,
+    buttonText: {
+      type: String,
+      default: "Choose a color",
+    },
+    value: {
+      type: String,
+      default: "#ff0000",
+    },
   },
   data() {
     return {
diff --git a/frontend/plugins/globals.js b/frontend/plugins/globals.js
index 27b4b6363925..3d71328fc005 100644
--- a/frontend/plugins/globals.js
+++ b/frontend/plugins/globals.js
@@ -200,7 +200,8 @@ const icons = {
   accountPlusOutline: mdiAccountPlusOutline,
 };
 
-export default ({ app }, inject) => {
+// eslint-disable-next-line no-empty-pattern
+export default ({}, inject) => {
   // Inject $hello(msg) in Vue, context and store.
   inject("globals", { icons });
 };
diff --git a/frontend/utils/index.js b/frontend/utils/index.js
index 18093474d884..756617d1fd9c 100644
--- a/frontend/utils/index.js
+++ b/frontend/utils/index.js
@@ -4,7 +4,7 @@ import { store } from "@/store";
 // TODO: Migrate to Mixins
 
 export const utils = {
-  recipe: recipe,
+  recipe,
   generateUniqueKey(item, index) {
     return `${item}-${index}`;
   },
@@ -16,35 +16,35 @@ export const utils = {
     return `${year}-${month}-${day}`;
   },
   notify: {
-    info: function(text, title = null) {
+    info(text, title = null) {
       store.commit("setSnackbar", {
         open: true,
-        title: title,
-        text: text,
+        title,
+        text,
         color: "info",
       });
     },
-    success: function(text, title = null) {
+    success(text, title = null) {
       store.commit("setSnackbar", {
         open: true,
-        title: title,
-        text: text,
+        title,
+        text,
         color: "success",
       });
     },
-    error: function(text, title = null) {
+    error(text, title = null) {
       store.commit("setSnackbar", {
         open: true,
-        title: title,
-        text: text,
+        title,
+        text,
         color: "error",
       });
     },
-    warning: function(text, title = null) {
+    warning(text, title = null) {
       store.commit("setSnackbar", {
         open: true,
-        title: title,
-        text: text,
+        title,
+        text,
         color: "warning",
       });
     },
diff --git a/frontend/utils/recipe.js b/frontend/utils/recipe.js
index a04cdf5e98ff..a406c674f9a7 100644
--- a/frontend/utils/recipe.js
+++ b/frontend/utils/recipe.js
@@ -6,8 +6,8 @@ export const recipe = {
    */
   sortAToZ(list) {
     list.sort((a, b) => {
-      var textA = a.name.toUpperCase();
-      var textB = b.name.toUpperCase();
+      const textA = a.name.toUpperCase();
+      const textB = b.name.toUpperCase();
       return textA < textB ? -1 : textA > textB ? 1 : 0;
     });
   },
@@ -42,7 +42,7 @@ const rand = n =>
   Math.floor(Math.random() * n)
 
 function swap(t, i, j) {
-  let q = t[i];
+  const q = t[i];
   t[i] = t[j];
   t[j] = q;
   return t;