From 31579d09a3088baaf3edc26cfca08788818a5315 Mon Sep 17 00:00:00 2001 From: Michael Genson <71845777+michael-genson@users.noreply.github.com> Date: Wed, 22 Nov 2023 17:40:53 +0000 Subject: [PATCH 1/2] updated deprecated devcontainer settings re-formatted structure removed deprecated linting settings added pylint extension to replace old linting setting --- .devcontainer/devcontainer.json | 43 +++++++++++++++------------------ 1 file changed, 19 insertions(+), 24 deletions(-) diff --git a/.devcontainer/devcontainer.json b/.devcontainer/devcontainer.json index c17a8260b56a..32bd1e18a1f7 100644 --- a/.devcontainer/devcontainer.json +++ b/.devcontainer/devcontainer.json @@ -18,31 +18,26 @@ "source=mealie-devcontainer-workspace,target=/workspaces/mealie/frontend/node_modules,type=volume", "source=mealie-bashhistory,target=/home/vscode/commandhistory,type=volume" ], - // Set *default* container specific settings.json values on container create. - "settings": { - "python.defaultInterpreterPath": "/usr/local/bin/python", - "python.linting.enabled": true, - "python.linting.pylintEnabled": true, - "python.formatting.autopep8Path": "/usr/local/py-utils/bin/autopep8", - "python.formatting.blackPath": "/usr/local/py-utils/bin/black", - "python.formatting.yapfPath": "/usr/local/py-utils/bin/yapf", - "python.linting.banditPath": "/usr/local/py-utils/bin/bandit", - "python.linting.flake8Path": "/usr/local/py-utils/bin/flake8", - "python.linting.mypyPath": "/usr/local/py-utils/bin/mypy", - "python.linting.pycodestylePath": "/usr/local/py-utils/bin/pycodestyle", - "python.linting.pydocstylePath": "/usr/local/py-utils/bin/pydocstyle", - "python.linting.pylintPath": "/usr/local/py-utils/bin/pylint" + "customizations": { + "vscode": { + "settings": { + "python.defaultInterpreterPath": "/usr/local/bin/python", + "python.formatting.autopep8Path": "/usr/local/py-utils/bin/autopep8", + "python.formatting.blackPath": "/usr/local/py-utils/bin/black", + "python.formatting.yapfPath": "/usr/local/py-utils/bin/yapf", + }, + "extensions": [ + "dbaeumer.vscode-eslint", + "matangover.mypy", + "ms-python.black-formatter", + "ms-python.isort", + "ms-python.pylint", + "ms-python.python", + "ms-python.vscode-pylance", + "Vue.volar" + ] + } }, - // Add the IDs of extensions you want installed when the container is created. - "extensions": [ - "dbaeumer.vscode-eslint", - "matangover.mypy", - "ms-python.black-formatter", - "ms-python.isort", - "ms-python.python", - "ms-python.vscode-pylance", - "Vue.volar" - ], // Use 'forwardPorts' to make a list of ports inside the container available locally. "forwardPorts": [ 3000, From a7bb02ffbde015ad5d2bb41e79ea9259f3600070 Mon Sep 17 00:00:00 2001 From: Michael Genson <71845777+michael-genson@users.noreply.github.com> Date: Wed, 22 Nov 2023 17:41:07 +0000 Subject: [PATCH 2/2] removed deprecated lint settings --- .vscode/settings.json | 11 +++-------- 1 file changed, 3 insertions(+), 8 deletions(-) diff --git a/.vscode/settings.json b/.vscode/settings.json index 89b301f013c7..7a225c846d5f 100644 --- a/.vscode/settings.json +++ b/.vscode/settings.json @@ -36,13 +36,6 @@ "i18n-ally.localesPaths": "frontend/lang/messages", "i18n-ally.sourceLanguage": "en-US", "python.defaultInterpreterPath": "${workspaceFolder}/.venv/bin/python", - "python.formatting.provider": "black", - "python.linting.enabled": true, - "python.linting.flake8Enabled": false, - "python.linting.pylintEnabled": false, - "python.linting.pylintArgs": [ - "--rcfile=${workspaceFolder}/.pylintrc" - ], "python.testing.autoTestDiscoverOnSaveEnabled": false, "python.testing.pytestArgs": [ "tests" @@ -50,7 +43,6 @@ "python.testing.pytestEnabled": true, "python.testing.unittestEnabled": false, "python.analysis.typeCheckingMode": "off", - "python.linting.mypyEnabled": true, "search.mode": "reuseEditor", "python.testing.unittestArgs": [ "-v", @@ -69,4 +61,7 @@ "[vue]": { "editor.formatOnSave": false }, + "[python]": { + "editor.defaultFormatter": "ms-python.black-formatter", + }, }