From a56bedb022b943a885427f911437bf37d85466cb Mon Sep 17 00:00:00 2001
From: Hayden <64056131+hay-kot@users.noreply.github.com>
Date: Fri, 21 Oct 2022 20:35:45 -0800
Subject: [PATCH] fix: mis-ordered shoppinglist after checking item (#1749)

---
 frontend/pages/shopping-lists/_id.vue | 17 ++++++++++++++---
 1 file changed, 14 insertions(+), 3 deletions(-)

diff --git a/frontend/pages/shopping-lists/_id.vue b/frontend/pages/shopping-lists/_id.vue
index 4f5497146cc0..d1cb4d8dd490 100644
--- a/frontend/pages/shopping-lists/_id.vue
+++ b/frontend/pages/shopping-lists/_id.vue
@@ -15,7 +15,7 @@
             <ShoppingListItem
               v-model="listItems.unchecked[index]"
               class="my-2 my-sm-0"
-              :labels="allLabels"
+              :labels="allLabels || []"
               :units="allUnits || []"
               :foods="allFoods || []"
               @checked="saveListItem(item)"
@@ -40,7 +40,7 @@
           <v-lazy v-for="(item, index) in value" :key="item.id">
             <ShoppingListItem
               v-model="value[index]"
-              :labels="allLabels"
+              :labels="allLabels || []"
               :units="allUnits || []"
               :foods="allFoods || []"
               @checked="saveListItem(item)"
@@ -56,7 +56,7 @@
         <ShoppingListItemEditor
           v-model="createListItemData"
           class="my-4"
-          :labels="allLabels"
+          :labels="allLabels || []"
           :units="allUnits || []"
           :foods="allFoods || []"
           @delete="createEditorOpen = false"
@@ -439,11 +439,22 @@ export default defineComponent({
     // =====================================
     // List Item CRUD
 
+    /*
+     * saveListItem updates and update on the backend server. Additionally, if the item is
+     * checked it will also append that item to the end of the list so that the unchecked items
+     * are at the top of the list.
+     */
     async function saveListItem(item: ShoppingListItemOut) {
       if (!shoppingList.value) {
         return;
       }
 
+      if (item.checked && shoppingList.value.listItems) {
+        const lst = shoppingList.value.listItems.filter((itm) => itm.id !== item.id);
+        lst.push(item);
+        updateIndex(lst);
+      }
+
       const { data } = await userApi.shopping.items.updateOne(item.id, item);
 
       if (data) {