Cutlery/mealie
1
0
Fork 0
mirror of https://github.com/mealie-recipes/mealie.git synced 2025-06-23 15:31:37 -04:00
Code Issues Packages Projects Releases Wiki Activity

Fix some pytests (#265)

Browse Source 
* Fix encoding issue in cleaner unit test

* Add VS Code task to run pytests

* Fix FileExistsError when running Windows
This commit is contained in:
sephrat 2021-04-08 07:00:05 +02:00 committed by GitHub
parent 1ae063a796
commit bb52c78c5b
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
3 changed files with 14 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
.vscode/tasks.json vendored
View File

@ -52,6 +52,15 @@
"group": "groupA" "group": "groupA"
}, },
"problemMatcher": [] "problemMatcher": []
},
{
"label": "Run python tests",
"command": "make test",
"type": "shell",
"presentation": {
"reveal": "always"
},
"problemMatcher": []
} }
] ]
} }

5
mealie/services/image/minify.py
View File

@ -60,7 +60,10 @@ def move_all_images():
continue continue
new_folder = app_dirs.IMG_DIR.joinpath(image_file.stem) new_folder = app_dirs.IMG_DIR.joinpath(image_file.stem)
new_folder.mkdir(parents=True, exist_ok=True) new_folder.mkdir(parents=True, exist_ok=True)
image_file.rename(new_folder.joinpath(f"original{image_file.suffix}")) new_file = new_folder.joinpath(f"original{image_file.suffix}")
if new_file.is_file():
new_file.unlink()
image_file.rename(new_file)
def validate_slugs_in_database(session: Session = None): def validate_slugs_in_database(session: Session = None):

2
tests/unit_tests/test_cleaner.py
View File

@ -80,7 +80,7 @@ def test_cleaner_instructions(instructions):
def test_html_with_recipe_data(): def test_html_with_recipe_data():
path = TEST_RAW_HTML.joinpath("healthy_pasta_bake_60759.html") path = TEST_RAW_HTML.joinpath("healthy_pasta_bake_60759.html")
url = "https://www.bbc.co.uk/food/recipes/healthy_pasta_bake_60759" url = "https://www.bbc.co.uk/food/recipes/healthy_pasta_bake_60759"
recipe_data = extract_recipe_from_html(open(path).read(), url) recipe_data = extract_recipe_from_html(open(path,encoding="utf8").read(), url)
assert len(recipe_data["name"]) > 10 assert len(recipe_data["name"]) > 10
assert len(recipe_data["slug"]) > 10 assert len(recipe_data["slug"]) > 10