mirror of
https://github.com/mealie-recipes/mealie.git
synced 2025-05-24 01:12:54 -04:00
9ecef4c25f
This PR does too many things :(
1. Major refactoring of the dev/scripts and dev/code-generation folders.
Primarily this was removing duplicate code and cleaning up some poorly written code snippets as well as making them more idempotent so then can be re-run over and over again but still maintain the same results. This is working on my machine, but I've been having problems in CI and comparing diffs so running generators in CI will have to wait.
2. Re-Implement using the generated api routes for testing
This was a _huge_ refactor that touched damn near every test file but now we have auto-generated typed routes with inline hints and it's used for nearly every test excluding a few that use classes for better parameterization. This should greatly reduce errors when writing new tests.
3. Minor Perf improvements for the All Recipes endpoint
A. Removed redundant loops
B. Uses orjson to do the encoding directly and returns a byte response instead of relying on the default
jsonable_encoder.
4. Fix some TS type errors that cropped up for seemingly no reason half way through the PR.
See this issue https://github.com/phillipdupuis/pydantic-to-typescript/issues/28
Basically, the generated TS type is not-correct since Pydantic will automatically fill in null fields. The resulting TS type is generated with a ? to indicate it can be null even though we _know_ that i can't be.
111 lines
4.0 KiB
Python
111 lines
4.0 KiB
Python
import pytest
|
|
from fastapi.testclient import TestClient
|
|
from pydantic import UUID4
|
|
|
|
from mealie.schema.recipe.recipe import Recipe
|
|
from tests.utils import api_routes
|
|
from tests.utils.factories import random_string
|
|
from tests.utils.fixture_schemas import TestUser
|
|
|
|
|
|
@pytest.fixture(scope="function")
|
|
def unique_recipe(api_client: TestClient, unique_user: TestUser):
|
|
payload = {"name": random_string(length=20)}
|
|
response = api_client.post(api_routes.recipes, json=payload, headers=unique_user.token)
|
|
assert response.status_code == 201
|
|
|
|
response_data = response.json()
|
|
recipe_response = api_client.get(api_routes.recipes_slug(response_data), headers=unique_user.token)
|
|
|
|
return Recipe(**recipe_response.json())
|
|
|
|
|
|
def random_comment(recipe_id: UUID4) -> dict:
|
|
if recipe_id is None:
|
|
raise ValueError("recipe_id is required")
|
|
return {
|
|
"recipeId": str(recipe_id),
|
|
"text": random_string(length=50),
|
|
}
|
|
|
|
|
|
def test_create_comment(api_client: TestClient, unique_recipe: Recipe, unique_user: TestUser):
|
|
# Create Comment
|
|
create_data = random_comment(unique_recipe.id)
|
|
response = api_client.post(api_routes.comments, json=create_data, headers=unique_user.token)
|
|
assert response.status_code == 201
|
|
|
|
response_data = response.json()
|
|
|
|
assert response_data["recipeId"] == str(unique_recipe.id)
|
|
assert response_data["text"] == create_data["text"]
|
|
assert response_data["userId"] == unique_user.user_id
|
|
|
|
# Check for Proper Association
|
|
response = api_client.get(api_routes.recipes_slug_comments(unique_recipe.slug), headers=unique_user.token)
|
|
assert response.status_code == 200
|
|
|
|
response_data = response.json()
|
|
|
|
assert len(response_data) == 1
|
|
assert response_data[0]["recipeId"] == str(unique_recipe.id)
|
|
assert response_data[0]["text"] == create_data["text"]
|
|
assert response_data[0]["userId"] == unique_user.user_id
|
|
|
|
|
|
def test_update_comment(api_client: TestClient, unique_recipe: Recipe, unique_user: TestUser):
|
|
# Create Comment
|
|
create_data = random_comment(unique_recipe.id)
|
|
response = api_client.post(api_routes.comments, json=create_data, headers=unique_user.token)
|
|
assert response.status_code == 201
|
|
|
|
comment_id = response.json()["id"]
|
|
|
|
# Update Comment
|
|
update_data = random_comment(unique_recipe.id)
|
|
update_data["id"] = comment_id
|
|
|
|
response = api_client.put(api_routes.comments_item_id(comment_id), json=update_data, headers=unique_user.token)
|
|
|
|
assert response.status_code == 200
|
|
|
|
response_data = response.json()
|
|
|
|
assert response_data["recipeId"] == str(unique_recipe.id)
|
|
assert response_data["text"] == update_data["text"]
|
|
assert response_data["userId"] == unique_user.user_id
|
|
|
|
|
|
def test_delete_comment(api_client: TestClient, unique_recipe: Recipe, unique_user: TestUser):
|
|
# Create Comment
|
|
create_data = random_comment(unique_recipe.id)
|
|
response = api_client.post(api_routes.comments, json=create_data, headers=unique_user.token)
|
|
assert response.status_code == 201
|
|
|
|
# Delete Comment
|
|
comment_id = response.json()["id"]
|
|
response = api_client.delete(api_routes.comments_item_id(comment_id), headers=unique_user.token)
|
|
assert response.status_code == 200
|
|
|
|
# Validate Deletion
|
|
response = api_client.get(api_routes.comments_item_id(comment_id), headers=unique_user.token)
|
|
|
|
assert response.status_code == 404
|
|
|
|
|
|
def test_admin_can_delete(api_client: TestClient, unique_recipe: Recipe, unique_user: TestUser, admin_user: TestUser):
|
|
# Create Comment
|
|
create_data = random_comment(unique_recipe.id)
|
|
response = api_client.post(api_routes.comments, json=create_data, headers=unique_user.token)
|
|
assert response.status_code == 201
|
|
|
|
# Delete Comment
|
|
comment_id = response.json()["id"]
|
|
response = api_client.delete(api_routes.comments_item_id(comment_id), headers=admin_user.token)
|
|
assert response.status_code == 200
|
|
|
|
# Validate Deletion
|
|
response = api_client.get(api_routes.comments_item_id(comment_id), headers=admin_user.token)
|
|
|
|
assert response.status_code == 404
|