From 42d3bd9e8ca97089494cfe55175f34b5a0d2dac1 Mon Sep 17 00:00:00 2001 From: Jef Roelandt Date: Fri, 19 Apr 2024 20:41:15 +0200 Subject: [PATCH 1/3] Make Dockerfile compatible with podman --- Dockerfile | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/Dockerfile b/Dockerfile index bd30c8f..e8325f0 100644 --- a/Dockerfile +++ b/Dockerfile @@ -1,11 +1,11 @@ -FROM node:20-alpine3.18 AS build +FROM docker.io/node:20-alpine3.18 AS build WORKDIR /app COPY package*.json ./ RUN npm install COPY . . RUN npm run build -FROM nginx:alpine AS runtime +FROM docker.io/nginx:alpine AS runtime COPY ./docker/nginx/nginx.conf /etc/nginx/nginx.conf COPY --from=build /app/dist /usr/share/nginx/html From 4f4ffe3e3aea4306a098f991e5b30ff79bf539a4 Mon Sep 17 00:00:00 2001 From: Jef Roelandt Date: Fri, 19 Apr 2024 20:35:24 +0200 Subject: [PATCH 2/3] Add visibility on buttons focus --- src/components/about/about.module.css | 4 ++++ src/components/buttons/play/play.module.css | 4 ++++ src/components/buttons/unselect/unselect.module.css | 4 ++++ src/components/sound/favorite/favorite.module.css | 4 ++++ 4 files changed, 16 insertions(+) diff --git a/src/components/about/about.module.css b/src/components/about/about.module.css index aaba9aa..641d30d 100644 --- a/src/components/about/about.module.css +++ b/src/components/about/about.module.css @@ -86,5 +86,9 @@ &:hover { background-color: var(--color-neutral-100); } + + &:focus-visible { + outline: 1px solid white; + } } } diff --git a/src/components/buttons/play/play.module.css b/src/components/buttons/play/play.module.css index f40798a..af84c78 100644 --- a/src/components/buttons/play/play.module.css +++ b/src/components/buttons/play/play.module.css @@ -27,4 +27,8 @@ & span { font-size: var(--font-lg); } + + &:focus-visible { + outline: 1px solid white; + } } diff --git a/src/components/buttons/unselect/unselect.module.css b/src/components/buttons/unselect/unselect.module.css index 797d0a7..23fcdcd 100644 --- a/src/components/buttons/unselect/unselect.module.css +++ b/src/components/buttons/unselect/unselect.module.css @@ -23,6 +23,10 @@ &:hover { background-color: var(--color-neutral-200); } + + &:focus-visible { + outline: 1px solid white; + } } .tooltip { diff --git a/src/components/sound/favorite/favorite.module.css b/src/components/sound/favorite/favorite.module.css index c12cb04..f915be1 100644 --- a/src/components/sound/favorite/favorite.module.css +++ b/src/components/sound/favorite/favorite.module.css @@ -24,4 +24,8 @@ &.isFavorite { color: var(--color-foreground); } + + &:focus-visible { + outline: 1px solid white; + } } From 86694897475d1e85452796f80021f62707428691 Mon Sep 17 00:00:00 2001 From: Jef Roelandt Date: Sun, 21 Apr 2024 16:24:08 +0200 Subject: [PATCH 3/3] Fix keyboard focus on Sound cards --- src/components/sound/sound.tsx | 24 +++++++++++++++++++----- 1 file changed, 19 insertions(+), 5 deletions(-) diff --git a/src/components/sound/sound.tsx b/src/components/sound/sound.tsx index dba6639..d65bef9 100644 --- a/src/components/sound/sound.tsx +++ b/src/components/sound/sound.tsx @@ -65,20 +65,34 @@ export function Sound({ }, [unselect, setVolume, id]); const toggle = useCallback(() => { - if (isSelected) return _unselect(); + if (isSelected) _unselect(); + else _select(); + }, [isSelected, _select, _unselect]); - _select(); - }, [isSelected, _unselect, _select]); + const handleClick = useCallback(() => { + toggle(); + }, [toggle]); + + const handleKeyDown = useCallback( + (event: React.KeyboardEvent) => { + if (event.key === 'Enter') { + toggle(); + } + }, + [toggle], + ); return (