From 29c7663caab35ca8d23cea132f41134a705a3c92 Mon Sep 17 00:00:00 2001
From: martabal <74269598+martabal@users.noreply.github.com>
Date: Thu, 22 Feb 2024 18:41:17 +0100
Subject: [PATCH] fix: notification number of people when editing faces

---
 .../faces-page/person-side-panel.svelte           | 15 ++++++++-------
 1 file changed, 8 insertions(+), 7 deletions(-)

diff --git a/web/src/lib/components/faces-page/person-side-panel.svelte b/web/src/lib/components/faces-page/person-side-panel.svelte
index 91a958799..58571e488 100644
--- a/web/src/lib/components/faces-page/person-side-panel.svelte
+++ b/web/src/lib/components/faces-page/person-side-panel.svelte
@@ -33,8 +33,8 @@
 
   // faces
   let peopleWithFaces: AssetFaceResponseDto[] = [];
-  let selectedPersonToReassign: (PersonResponseDto | null)[];
-  let selectedPersonToCreate: (string | null)[];
+  let selectedPersonToReassign: (PersonResponseDto | undefined)[];
+  let selectedPersonToCreate: (string | undefined)[];
   let editedPersonIndex: number;
 
   // loading spinners
@@ -76,7 +76,7 @@
       isEqual(numberOfAssetFaceGenerated, numberOfPersonToCreate) &&
       loaderLoadingDoneTimeout &&
       automaticRefreshTimeout &&
-      selectedPersonToCreate.filter((person) => person !== null).length === numberOfPersonToCreate.length
+      selectedPersonToCreate.filter((person) => person).length === numberOfPersonToCreate.length
     ) {
       clearTimeout(loaderLoadingDoneTimeout);
       clearTimeout(automaticRefreshTimeout);
@@ -99,18 +99,19 @@
 
   const handleReset = (index: number) => {
     if (selectedPersonToReassign[index]) {
-      selectedPersonToReassign[index] = null;
+      selectedPersonToReassign[index] = undefined;
     }
     if (selectedPersonToCreate[index]) {
-      selectedPersonToCreate[index] = null;
+      selectedPersonToCreate[index] = undefined;
     }
   };
 
   const handleEditFaces = async () => {
     loaderLoadingDoneTimeout = setTimeout(() => (isShowLoadingDone = true), timeBeforeShowLoadingSpinner);
     const numberOfChanges =
-      selectedPersonToCreate.filter((person) => person !== null).length +
-      selectedPersonToReassign.filter((person) => person !== null).length;
+      selectedPersonToCreate.filter((person) => person).length +
+      selectedPersonToReassign.filter((person) => person).length;
+
     if (numberOfChanges > 0) {
       try {
         for (const [index, peopleWithFace] of peopleWithFaces.entries()) {