feat(mobile): Allow users to set profile picture from asset viewer (#25517)

* init * fix * styling * temporary workaround for 500 error **Root cause:** The autogenerated Dart OpenAPI client (`UsersApi.createProfileImage()`) had two issues: 1. It set `Content-Type: multipart/form-data` without a boundary, which overrode the correct header that Dart's `MultipartRequest` would set (`multipart/form-data; boundary=...`). 2. It added the file to both `mp.fields` and `mp.files`, creating a duplicate text field. **Result:** Multer on the server failed to parse the multipart body, so `@UploadedFile()` was `undefined` → accessing `file.path` in `UserService.createProfileImage()` threw → **500 Internal Server Error**. **Workaround:** Bypass the autogenerated method in `UserApiRepository.createProfileImage()` and send the multipart request directly using the same `ApiClient` (basePath + auth), ensuring: - No manual `Content-Type` header (let `MultipartRequest` set it with boundary) - File only in `mp.files`, not `mp.fields` - Proper filename fallback * Revert "temporary workaround for 500 error" This reverts commit 8436cd402632ca7be9272a1c72fdaf0763dcefb6. * generate route for ProfilePictureCropPage * add route import * simplify * try this * Revert "try this" This reverts commit fcf37d2801055c49010ddb4fd271feb900ee645a. * try patching * Reapply "temporary workaround for 500 error" This reverts commit faeed810c21e4c9f0839dfff1f34aa6183469e56. * Revert "Reapply "temporary workaround for 500 error"" This reverts commit a14a0b76d14975af98ef91748576a79cef959635. * fix upload * Refactor image conversion logic by introducing a new utility function. Replace inline image-to-Uint8List conversion with the new utility in EditImagePage, DriftEditImagePage, and ProfilePictureCropPage. * use toast over snack * format * Revert "try patching" This reverts commit 68a616522a1eee88c4a9755a314c0017e6450c0f. * Enhance toast notification in ProfilePictureCropPage to include success type for better user feedback. * Revert "simplify" This reverts commit 8e85057a40678c25bfffa8578ddcc8fd7d1e143e. * format * add tests * refactor to use statefulwidget * format --------- Co-authored-by: Alex <alex.tran1502@gmail.com>
2026-02-22 07:02:33 +01:00
parent 3ce0654cab
commit f0cf3311d5
10 changed files with 367 additions and 41 deletions
@@ -637,6 +637,76 @@ void main() {
      });
    });

+    group('setProfilePicture button', () {
+      test('should show when owner, not locked, and asset is RemoteAsset', () {
+        final remoteAsset = createRemoteAsset();
+        final context = ActionButtonContext(
+          asset: remoteAsset,
+          isOwner: true,
+          isArchived: false,
+          isTrashEnabled: true,
+          isInLockedView: false,
+          currentAlbum: null,
+          advancedTroubleshooting: false,
+          isStacked: false,
+          source: ActionSource.timeline,
+        );
+
+        expect(ActionButtonType.setProfilePicture.shouldShow(context), isTrue);
+      });
+
+      test('should not show when not owner', () {
+        final remoteAsset = createRemoteAsset();
+        final context = ActionButtonContext(
+          asset: remoteAsset,
+          isOwner: false,
+          isArchived: false,
+          isTrashEnabled: true,
+          isInLockedView: false,
+          currentAlbum: null,
+          advancedTroubleshooting: false,
+          isStacked: false,
+          source: ActionSource.timeline,
+        );
+
+        expect(ActionButtonType.setProfilePicture.shouldShow(context), isFalse);
+      });
+
+      test('should not show when in locked view', () {
+        final remoteAsset = createRemoteAsset();
+        final context = ActionButtonContext(
+          asset: remoteAsset,
+          isOwner: true,
+          isArchived: false,
+          isTrashEnabled: true,
+          isInLockedView: true,
+          currentAlbum: null,
+          advancedTroubleshooting: false,
+          isStacked: false,
+          source: ActionSource.timeline,
+        );
+
+        expect(ActionButtonType.setProfilePicture.shouldShow(context), isFalse);
+      });
+
+      test('should not show when asset is not RemoteAsset', () {
+        final localAsset = createLocalAsset();
+        final context = ActionButtonContext(
+          asset: localAsset,
+          isOwner: true,
+          isArchived: false,
+          isTrashEnabled: true,
+          isInLockedView: false,
+          currentAlbum: null,
+          advancedTroubleshooting: false,
+          isStacked: false,
+          source: ActionSource.timeline,
+        );
+
+        expect(ActionButtonType.setProfilePicture.shouldShow(context), isFalse);
+      });
+    });
+
    group('setAlbumCover button', () {
      test('should show when owner, not locked, has album, and selectedCount is 1', () {
        final album = createRemoteAlbum();